Skip to contentSkip to conversation

btrfs: a few performance improvements for fsync and rename/link

PATCH In review [email protected] 2 participants 4 messages Aug 11, 2020 – Aug 19, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

cover btrfs: a few performance improvements for fsync and rename/link

From: Filipe Manana <[email protected]>

A small group of changes to improve performance of fsync, rename and link operations. They are farily independent, but patch 3 needs to be applied before patch 2, the order can be changed if needed.
Details and performance tests are mentioned in the change log of each patch.

Filipe Manana (3):
btrfs: do not take the log_mutex of the subvolume when pinning the log
btrfs: do not commit logs and transactions during link and rename
operations
btrfs: make fast fsyncs wait only for writeback

 fs/btrfs/btrfs_inode.h  |   5 +
 fs/btrfs/file.c         |  97 +++++++++-----
 fs/btrfs/inode.c        | 115 ++---------------
 fs/btrfs/ordered-data.c |  59 +++++++++
 fs/btrfs/ordered-data.h |  11 ++
 fs/btrfs/transaction.c  |  10 ++
 fs/btrfs/transaction.h  |   7 ++
 fs/btrfs/tree-log.c     | 272 +++++++++++++++++++++-------------------
 fs/btrfs/tree-log.h     |  32 +++--
 9 files changed, 334 insertions(+), 274 deletions(-)
Signature · 1 line
2.26.2
#1 lore raw
Quoted 3 lines · On Tue, Aug 11, 2020 at 12:43:28PM +0100, [email protected] wrote:

From: Filipe Manana <[email protected]>

A small group of changes to improve performance of fsync, rename and link operations.

Thank you very much!

Quoted 3 lines

They are farily independent, but patch 3 needs to be applied before patch 2, the order can be changed if needed.
Details and performance tests are mentioned in the change log of each patch.

A lot of two-digit improvements in throughput and runtime, that's great.

#2 lore raw
Quoted 6 lines · David Sterba
Quoted 3 lines · On Tue, Aug 11, 2020 at 12:43:28PM +0100, [email protected] wrote:

From: Filipe Manana <[email protected]>

A small group of changes to improve performance of fsync, rename and link operations.

Quoted 7 lines

Thank you very much!

Quoted 3 lines

They are farily independent, but patch 3 needs to be applied before patch 2, the order can be changed if needed.
Details and performance tests are mentioned in the change log of each patch.

A lot of two-digit improvements in throughput and runtime, that's great.

Btw, could you fold the following into patch 3?

https://pastebin.com/raw/hmmmnzJY

It just silences a warning that one of the kernel test robots reported last sunday:

https://lists.01.org/hyperkitty/list/[email protected]/thread/CRTG5J2M2D7Q7M5GPHXKHOKGKN3GSVWJ/

It doesn't change anything in terms of behaviour.

Thanks.

#3 lore raw
Quoted 13 lines · Filipe Manana
Quoted 12 lines · David Sterba
Quoted 3 lines · On Tue, Aug 11, 2020 at 12:43:28PM +0100, [email protected] wrote:

From: Filipe Manana <[email protected]>

A small group of changes to improve performance of fsync, rename and link operations.

Thank you very much!

Quoted 3 lines

They are farily independent, but patch 3 needs to be applied before patch 2, the order can be changed if needed.
Details and performance tests are mentioned in the change log of each patch.

Quoted 5 lines
Quoted 1 line

A lot of two-digit improvements in throughput and runtime, that's great.

Btw, could you fold the following into patch 3?

https://pastebin.com/raw/hmmmnzJY

Updated and pushed, thanks.