Skip to contentSkip to conversation

crypto: virtio - don't use 'default m'

PATCH In review Eric Biggers 2 participants 2 messages Aug 12, 2020 – Aug 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: virtio - don't use 'default m'

From: Ram Muthiah <[email protected]>

Drivers shouldn't be enabled by default unless there is a very good reason to do so. There doesn't seem to be any such reason for the virtio crypto driver, so change it to the default of 'n'.

[EB: adjusted commit message]
---
 drivers/crypto/virtio/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/crypto/virtio/Kconfig +0 -1
index fb294174e408..b894e3a8be4f 100644
@@ -5,7 +5,6 @@ config CRYPTO_DEV_VIRTIO
 	select CRYPTO_AEAD
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
-	default m
 	help
 	  This driver provides support for virtio crypto device. If you
 	  choose 'M' here, this module will be called virtio_crypto.
Signature · 1 line
2.28.0.236.gb10cc79966-goog
maintainer
#1 lore raw
Quoted 6 lines · Eric Biggers

From: Ram Muthiah <[email protected]>

Drivers shouldn't be enabled by default unless there is a very good reason to do so. There doesn't seem to be any such reason for the virtio crypto driver, so change it to the default of 'n'.

Quoted 6 lines
[EB: adjusted commit message]

---
drivers/crypto/virtio/Kconfig | 1 -

1 file changed, 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt