perf parse-events: Set exclude_guest for user-space counting
PATCH v2 1/1 perf parse-events: Set exclude_guest for user-space counting
Currently if we run 'perf record -e cycles:u', exclude_guest is 0.
But it doesn't make sense that we request for user-space counting but we also get the guest report.
To keep perf semantics consistent and clear, this patch sets exclude_guest for user-space counting.
Before:
perf record -e cycles:u ./div
perf evlist -v
cycles:u: ..., exclude_kernel: 1, exclude_hv: 1, ...
After:
perf record -e cycles:u ./div
perf evlist -v
cycles:u: ..., exclude_kernel: 1, exclude_hv: 1, exclude_guest: 1, ...
perf test 6
6: Parse event definition strings : Ok
Signed-off-by Jin Yao <[email protected]>
---
v2:
---
Fix the 'perf test 6' failure.
tools/perf/tests/parse-events.c | 4 ++-- tools/perf/util/parse-events.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)
tools/perf/tests/parse-events.c +2 -2
@@ -719,7 +719,7 @@ static int test__group2(struct evlist *evlist)TEST_ASSERT_VAL ("wrong exclude_user" , !evsel->core.attr.exclude_user);TEST_ASSERT_VAL ("wrong exclude_kernel" , !evsel->core.attr.exclude_kernel);TEST_ASSERT_VAL ("wrong exclude_hv" , evsel->core.attr.exclude_hv); -TEST_ASSERT_VAL ("wrong exclude guest" , !evsel->core.attr.exclude_guest); +TEST_ASSERT_VAL ("wrong exclude guest" , evsel->core.attr.exclude_guest);TEST_ASSERT_VAL ("wrong exclude host" , !evsel->core.attr.exclude_host);TEST_ASSERT_VAL ("wrong precise_ip" , !evsel->core.attr.precise_ip);TEST_ASSERT_VAL ("wrong leader" ,evsel__is_group_leader (evsel));
@@ -842,7 +842,7 @@ static int test__group3(struct evlist *evlist __maybe_unused)TEST_ASSERT_VAL ("wrong exclude_user" , !evsel->core.attr.exclude_user);TEST_ASSERT_VAL ("wrong exclude_kernel" , evsel->core.attr.exclude_kernel);TEST_ASSERT_VAL ("wrong exclude_hv" , evsel->core.attr.exclude_hv); -TEST_ASSERT_VAL ("wrong exclude guest" , !evsel->core.attr.exclude_guest); +TEST_ASSERT_VAL ("wrong exclude guest" , evsel->core.attr.exclude_guest);TEST_ASSERT_VAL ("wrong exclude host" , !evsel->core.attr.exclude_host);TEST_ASSERT_VAL ("wrong precise_ip" , !evsel->core.attr.precise_ip);TEST_ASSERT_VAL ("wrong leader" ,evsel__is_group_leader (evsel));
tools/perf/util/parse-events.c +2 -0
@@ -1794,6 +1794,8 @@ static int get_event_modifier(struct event_modifier *mod, char *str,if (*str =='u' ) {if (!exclude) exclude = eu = ek = eh =1 ; +if (!exclude_GH) + eG =1 ; eu =0 ; }else if (*str =='k' ) {if (!exclude)
Signature · 1 line
2.17.1