Skip to contentSkip to conversation

drivers/hwmon/adm1177.c: use simple i2c probe

PATCH In review Stephen Kitt 2 participants 4 messages Aug 13, 2020 – Aug 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/hwmon/adm1177.c: use simple i2c probe

This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form.

---
 drivers/hwmon/adm1177.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/hwmon/adm1177.c +2 -3
index d314223a404a..6e8bb661894b 100644
@@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
 	regulator_disable(st->reg);
 }
 
-static int adm1177_probe(struct i2c_client *client,
-			 const struct i2c_device_id *id)
+static int adm1177_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
 	struct device *hwmon_dev;
@@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
 		.name = "adm1177",
 		.of_match_table = adm1177_dt_ids,
 	},
-	.probe = adm1177_probe,
+	.probe_new = adm1177_probe,
 	.id_table = adm1177_id,
 };
 module_i2c_driver(adm1177_driver);
Signature · 1 line
2.25.4
maintainer
#1 lore raw
Quoted 5 lines · Stephen Kitt

This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form.

I'll apply the entire series, but please don't use entire path names as tag in the future but follow bubsystem rules.

Thanks,
Guenter

Quoted 27 lines
---
 drivers/hwmon/adm1177.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/hwmon/adm1177.c +2 -3
index d314223a404a..6e8bb661894b 100644
@@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
 	regulator_disable(st->reg);
 }
 
-static int adm1177_probe(struct i2c_client *client,
-			 const struct i2c_device_id *id)
+static int adm1177_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
 	struct device *hwmon_dev;
@@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
 		.name = "adm1177",
 		.of_match_table = adm1177_dt_ids,
 	},
-	.probe = adm1177_probe,
+	.probe_new = adm1177_probe,
 	.id_table = adm1177_id,
 };
 module_i2c_driver(adm1177_driver);
#2 lore raw
Quoted 9 lines · Guenter Roeck
Quoted 5 lines · Stephen Kitt

This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form.

I'll apply the entire series, but please don't use entire path names as tag in the future but follow bubsystem rules.

Sorry about that, I’ll bear that in mind for the remaining hwmon patches (and more generally).

Regards,

Stephen

maintainer
#3 lore raw
Quoted 11 lines · Stephen Kitt
Quoted 9 lines · Guenter Roeck
Quoted 5 lines · Stephen Kitt

This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form.

I'll apply the entire series, but please don't use entire path names as tag in the future but follow bubsystem rules.

"bubsystem". Sigh. Me and my fat fingers.

Guenter