cedrus: Add missing v4l2_ctrl_request_hdl_put()
PATCH 1/1 cedrus: Add missing v4l2_ctrl_request_hdl_put()
The check for a required control in the request was missing a call to v4l2_ctrl_request_hdl_put() in the error path. Fix it.
Fixes 50e761516f2b8c ("media: platform: Add Cedrus VPU decoder driver")
Signed-off-by Ezequiel Garcia <[email protected]>
--- drivers/staging/media/sunxi/cedrus/cedrus.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/staging/media/sunxi/cedrus/cedrus.c +6 -1
@@ -199,6 +199,7 @@ static int cedrus_request_validate(struct media_request *req)struct v4l2_ctrl *ctrl_test;unsigned int count;unsigned int i; +int ret =0 ;list_for_each_entry (obj, &req->objects, list) {struct vb2_buffer *vb;
@@ -243,12 +244,16 @@ static int cedrus_request_validate(struct media_request *req)if (!ctrl_test) {v4l2_info (&ctx->dev->v4l2_dev,"Missing required codec control\n" ); -return -ENOENT ; + ret = -ENOENT ; +break ; } }v4l2_ctrl_request_hdl_put (hdl); +if (ret) +return ret; +return vb2_request_validate (req); }
Signature · 1 line
2.27.0