mmc: test: remove ambiguity in test description
PATCH 1/1 mmc: test: remove ambiguity in test description
From: Wolfram Sang <[email protected]>
When reading the test description, I thought a correction of the xfer_size was tested, which is not the case. It is tested that the xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity.
---
This may be bike-shedding and I am not offended if you think it is minor. However, I ended up looking at the source wondering where is what automatically corrected.
drivers/mmc/core/mmc_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mmc/core/mmc_test.c +4 -4
@@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { }, { - .name = "Correct xfer_size at write (start failure)", + .name = "Proper xfer_size at write (start failure)", .run = mmc_test_xfersize_write, }, { - .name = "Correct xfer_size at read (start failure)", + .name = "Proper xfer_size at read (start failure)", .run = mmc_test_xfersize_read, }, { - .name = "Correct xfer_size at write (midway failure)", + .name = "Proper xfer_size at write (midway failure)", .run = mmc_test_multi_xfersize_write, }, { - .name = "Correct xfer_size at read (midway failure)", + .name = "Proper xfer_size at read (midway failure)", .run = mmc_test_multi_xfersize_read, },
Signature · 1 line
2.20.1
Hi Wolfram,
Thanks for your work.
Quoted 7 lines · Wolfram Sang
From: Wolfram Sang <[email protected]>
When reading the test description, I thought a correction of the
xfer_sizewas tested, which is not the case. It is tested that thexfer_sizeis correct. Use 'properxfer_size' to remove this ambiguity.Signed-off-by Wolfram Sang <[email protected]>
For what it's worth,
Quoted 43 lines
---
This may be bike-shedding and I am not offended if you think it is minor. However, I ended up looking at the source wondering where is what automatically corrected.
drivers/mmc/core/mmc_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/mmc/core/mmc_test.c +4
-4@@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { }, { - .name = "Correct xfer_size at write (start failure)", + .name = "Proper xfer_size at write (start failure)", .run = mmc_test_xfersize_write, }, { - .name = "Correct xfer_size at read (start failure)", + .name = "Proper xfer_size at read (start failure)", .run = mmc_test_xfersize_read, }, { - .name = "Correct xfer_size at write (midway failure)", + .name = "Proper xfer_size at write (midway failure)", .run = mmc_test_multi_xfersize_write, }, { - .name = "Correct xfer_size at read (midway failure)", + .name = "Proper xfer_size at read (midway failure)", .run = mmc_test_multi_xfersize_read, },Signature · 1 line
2.20.1
Signature · 2 lines
Regards, Niklas Söderlund
Quoted 8 lines · Wolfram Sang
From: Wolfram Sang <[email protected]>
When reading the test description, I thought a correction of the
xfer_sizewas tested, which is not the case. It is tested that thexfer_sizeis correct. Use 'properxfer_size' to remove this ambiguity.Signed-off-by Wolfram Sang <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 43 lines
---
This may be bike-shedding and I am not offended if you think it is minor. However, I ended up looking at the source wondering where is what automatically corrected.
drivers/mmc/core/mmc_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/mmc/core/mmc_test.c +4
-5@@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = { }, { - .name = "Correct xfer_size at write (start failure)", + .name = "Proper xfer_size at write (start failure)", .run = mmc_test_xfersize_write, }, { - .name = "Correct xfer_size at read (start failure)", + .name = "Proper xfer_size at read (start failure)", .run = mmc_test_xfersize_read, }, { - .name = "Correct xfer_size at write (midway failure)", + .name = "Proper xfer_size at write (midway failure)", .run = mmc_test_multi_xfersize_write, }, { - .name = "Correct xfer_size at read (midway failure)", + .name = "Proper xfer_size at read (midway failure)", .run = mmc_test_multi_xfersize_read, }, --2.20.1