kernel.h: Split out min()/max() et al. helpers
Subsystems (6)
PATCH v2 1/8 kernel.h: Split out min()/max() et al. helpers
kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out min()/max() et al. helpers.
At the same time convert users in header and lib folder to use new header. Though for time being include new header back to kernel.h to avoid twisted indirected includes for other existing users.
---
v2: new patch, prerequisite for the rest (Rafael)
include/linux/blkdev.h | 1 + include/linux/bvec.h | 6 +- include/linux/jiffies.h | 3 +- include/linux/kernel.h | 142 +------------------------------------ include/linux/minmax.h | 145 ++++++++++++++++++++++++++++++++++++++ include/linux/nodemask.h | 2 +- include/linux/uaccess.h | 1 + kernel/range.c | 3 +- lib/find_bit.c | 1 + lib/hexdump.c | 1 + lib/math/rational.c | 2 +- lib/math/reciprocal_div.c | 1 + 12 files changed, 162 insertions(+), 146 deletions(-) create mode 100644 include/linux/minmax.h
include/linux/blkdev.h +1 -0
@@ -8,6 +8,7 @@#include <linux/genhd.h> #include <linux/list.h> #include <linux/llist.h> +#include <linux/minmax.h> #include <linux/timer.h> #include <linux/workqueue.h> #include <linux/pagemap.h>
include/linux/bvec.h +5 -1
@@ -7,10 +7,14 @@#ifndef __LINUX_BVEC_ITER_H#define __LINUX_BVEC_ITER_H -#include <linux/kernel.h> #include <linux/bug.h> #include <linux/errno.h> +#include <linux/limits.h> +#include <linux/minmax.h> #include <linux/mm.h> +#include <linux/types.h> + +struct page ;/** * struct bio_vec - a contiguous range of physical memory addresses
include/linux/jiffies.h +2 -1
@@ -3,8 +3,9 @@#define _LINUX_JIFFIES_H#include <linux/cache.h> +#include <linux/limits.h> #include <linux/math64.h> -#include <linux/kernel.h> +#include <linux/minmax.h> #include <linux/types.h> #include <linux/time.h> #include <linux/timex.h>
include/linux/kernel.h +1 -141
154 lines not on this page · raw message
include/linux/minmax.h new file +145 -0
145 lines not on this page · raw message
include/linux/nodemask.h +1 -1
@@ -90,9 +90,9 @@* for such situations. See below and CPUMASK_ALLOC also. */ -#include <linux/kernel.h> #include <linux/threads.h> #include <linux/bitmap.h> +#include <linux/minmax.h> #include <linux/numa.h> typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); } nodemask_t;
include/linux/uaccess.h +1 -0
@@ -3,6 +3,7 @@#define __LINUX_UACCESS_H__#include <linux/instrumented.h> +#include <linux/minmax.h> #include <linux/sched.h> #include <linux/thread_info.h>
kernel/range.c +2 -1
@@ -2,8 +2,9 @@/* * Range add and subtract */ -#include <linux/kernel.h> #include <linux/init.h> +#include <linux/minmax.h> +#include <linux/printk.h> #include <linux/sort.h> #include <linux/string.h> #include <linux/range.h>
lib/find_bit.c +1 -0
@@ -16,6 +16,7 @@#include <linux/bitmap.h> #include <linux/export.h> #include <linux/kernel.h> +#include <linux/minmax.h> #if !defined(find_next_bit) || !defined(find_next_zero_bit) || \ !defined(find_next_bit_le) || !defined(find_next_zero_bit_le) || \
lib/hexdump.c +1 -0
@@ -7,6 +7,7 @@#include <linux/ctype.h> #include <linux/errno.h> #include <linux/kernel.h> +#include <linux/minmax.h> #include <linux/export.h> #include <asm/unaligned.h>
lib/math/rational.c +1 -1
@@ -11,7 +11,7 @@#include <linux/rational.h> #include <linux/compiler.h> #include <linux/export.h> -#include <linux/kernel.h> +#include <linux/minmax.h> /* * calculate best rational approximation for a given fraction
lib/math/reciprocal_div.c +1 -0
@@ -4,6 +4,7 @@#include <asm/div64.h> #include <linux/reciprocal_div.h> #include <linux/export.h> +#include <linux/minmax.h> /* * For a description of the algorithm please have a look at
Signature · 1 line
2.28.0
PATCH v2 2/8 resource: Simplify region_intersects() by reducing conditionals
Now we have for 'other' and 'type' variables
other type return
0 0 REGION_DISJOINT 0 x REGION_INTERSECTS x 0 REGION_DISJOINT x x REGION_MIXED
Obviously it's easier to check 'type' for 0 first instead of currently checked 'other'.
---
v2: converted ternary to usual if-cond (Rafael)
kernel/resource.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
kernel/resource.c +5 -5
@@ -554,13 +554,13 @@ int region_intersects(resource_size_t start, size_t size, unsigned long flags, }read_unlock (&resource_lock); -if (other ==0 ) -return type ?REGION_INTERSECTS :REGION_DISJOINT ; +if (type ==0 ) +return REGION_DISJOINT ; -if (type) -return REGION_MIXED ; +if (other ==0 ) +return REGION_INTERSECTS ; -return REGION_DISJOINT ; +return REGION_MIXED ; }EXPORT_SYMBOL_GPL (region_intersects);
Signature · 1 line
2.28.0
PATCH v2 3/8 resource: Group resource_overlaps() with other inline helpers
In reply to Andy ShevchenkoFor better maintenance group resource_overlaps() with other inline helpers. While at it, drop extra parentheses.
---
v2: dropped parentheses (Rafael)
include/linux/ioport.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
include/linux/ioport.h +5 -6
@@ -226,6 +226,11 @@ static inline bool resource_contains(struct resource *r1, struct resource *r2)return r1->start <= r2->start && r1->end >= r2->end; } +/* True if any part of r1 overlaps r2 */ +static inline bool resource_overlaps (struct resource *r1,struct resource *r2) +{ +return r1->start <= r2->end && r1->end >= r2->start; +}/* Convenience shorthand with allocation */ #define request_region (start,n,name) __request_region(&ioport_resource, (start), (n), (name), 0)
@@ -291,12 +296,6 @@ extern int walk_iomem_res_desc(unsigned long desc, unsigned long flags, u64 start, u64 end, void *arg, int (*func)(struct resource *, void *)); -/* True if any part of r1 overlaps r2 */ -static inline bool resource_overlaps (struct resource *r1,struct resource *r2) -{ -return (r1->start <= r2->end && r1->end >= r2->start); -} -struct resource *devm_request_free_mem_region (struct device *dev,struct resource *base,unsigned long size); struct resource *request_free_mem_region(struct resource *base,
Signature · 1 line
2.28.0
PATCH v2 4/8 resource: Introduce resource_union() for overlapping resources
In reply to Andy ShevchenkoSome already present users may utilize resource_union() helper. Provide it for them and for wider use in the future.
---
v2: reused min/max (Rafael)
include/linux/ioport.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
include/linux/ioport.h +12 -1
@@ -10,9 +10,10 @@#define _LINUX_IOPORT_H#ifndef __ASSEMBLY__ +#include <linux/bits.h> #include <linux/compiler.h> +#include <linux/minmax.h> #include <linux/types.h> -#include <linux/bits.h> /* * Resources are tree-like, allowing * nesting etc..
@@ -232,6 +233,16 @@ static inline bool resource_overlaps(struct resource *r1, struct resource *r2)return r1->start <= r2->end && r1->end >= r2->start; } +static inline bool +resource_union (struct resource *r1,struct resource *r2,struct resource *r) +{ +if (!resource_overlaps (r1, r2)) +return false; + r->start =min (r1->start, r2->start); + r->end =max (r1->end, r2->end); +return true; +} +/* Convenience shorthand with allocation */ #define request_region (start,n,name) __request_region(&ioport_resource, (start), (n), (name), 0)#define request_muxed_region (start,n,name) __request_region(&ioport_resource, (start), (n), (name), IORESOURCE_MUXED)
Signature · 1 line
2.28.0
PATCH v2 5/8 resource: Introduce resource_intersection() for overlapping resources
In reply to Andy ShevchenkoThere will be at least one user that can utilize new helper. Provide the helper for future user and for wider use.
---
v2: reused min/max (Rafael)
include/linux/ioport.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
include/linux/ioport.h +10 -0
@@ -233,6 +233,16 @@ static inline bool resource_overlaps(struct resource *r1, struct resource *r2)return r1->start <= r2->end && r1->end >= r2->start; } +static inline bool +resource_intersection (struct resource *r1,struct resource *r2,struct resource *r) +{ +if (!resource_overlaps (r1, r2)) +return false; + r->start =max (r1->start, r2->start); + r->end =min (r1->end, r2->end); +return true; +} +static inline bool resource_union (struct resource *r1,struct resource *r2,struct resource *r) {
Signature · 1 line
2.28.0
PATCH v2 6/8 PCI/ACPI: Replace open coded variant of resource_union()
In reply to Andy ShevchenkoSince we have resource_union() helper, let's utilize it here.
---
v2: added Rb tag (Rafael)
drivers/acpi/pci_root.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/acpi/pci_root.c +1 -3
@@ -724,9 +724,7 @@ static void acpi_pci_root_validate_resources(struct device *dev,* our resources no longer match the ACPI _CRS, but * the kernel resource tree doesn't allow overlaps. */ -if (resource_overlaps (res1, res2)) { - res2->start =min (res1->start, res2->start); - res2->end =max (res1->end, res2->end); +if (resource_union (res1, res2, res2)) {dev_info (dev,"host bridge window expanded to %pR; %pR ignored\n" , res2, res1); free = true;
Signature · 1 line
2.28.0
PATCH v2 7/8 PCI/ACPI: Fix description of @handle for acpi_is_root_bridge()
In reply to Andy ShevchenkoFix description of handle parameter in documentation of acpi_is_root_bridge(). Otherwise we get the following warning:
CHECK drivers/acpi/pci_root.c
drivers/acpi/pci_root.c:71: warning: Function parameter or member 'handle' not described in 'acpi_is_root_bridge'
---
v2: left in the series, but maintainers still may apply it separately
drivers/acpi/pci_root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/pci_root.c +1 -1
@@ -62,7 +62,7 @@ static DEFINE_MUTEX(osc_lock);/** * acpi_is_root_bridge - determine whether an ACPI CA node is a PCI root bridge -* @handle - the ACPI CA node in question. +* @handle: the ACPI CA node in question. * * Note: we could make this API take a struct acpi_device * instead, but * for now, it's more convenient to operate on an acpi_handle.
Signature · 1 line
2.28.0
PATCH v2 8/8 ACPI: watchdog: Replace open coded variant of resource_union()
In reply to Andy ShevchenkoSince we have resource_union() helper, let's utilize it here.
---
v2: added Rb tag (Rafael)
drivers/acpi/acpi_watchdog.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/acpi/acpi_watchdog.c +1 -5
@@ -151,11 +151,7 @@ void __init acpi_watchdog_init(void) found = false;resource_list_for_each_entry (rentry, &resource_list) {if (rentry->res->flags == res.flags && -resource_overlaps (rentry->res, &res)) { -if (res.start < rentry->res->start) - rentry->res->start = res.start; -if (res.end > rentry->res->end) - rentry->res->end = res.end; +resource_union (rentry->res, &res, rentry->res)) { found = true;break ; }
Signature · 1 line
2.28.0
Re: [PATCH v2 8/8] ACPI: watchdog: Replace open coded variant of resource_union()
Quoted 4 lines · Andy Shevchenko
Since we have
resource_union()helper, let's utilize it here.Signed-off-by Andy Shevchenko <[email protected]>Cc Mika Westerberg <[email protected]>
Quoted 7 lines · Andy Shevchenko
kernel.his being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out min()/max() et al. helpers.At the same time convert users in header and lib folder to use new header. Though for time being include new header back to
kernel.hto avoid twisted indirected includes for other existing users.
Rafael, does it look good now?
Quoted 470 lines
Signed-off-by Andy Shevchenko <[email protected]>---
v2: new patch, prerequisite for the rest (Rafael)include/linux/blkdev.h | 1 + include/linux/bvec.h | 6 +- include/linux/jiffies.h | 3 +- include/linux/kernel.h | 142 +------------------------------------ include/linux/minmax.h | 145 ++++++++++++++++++++++++++++++++++++++ include/linux/nodemask.h | 2 +- include/linux/uaccess.h | 1 + kernel/range.c | 3 +- lib/find_bit.c | 1 + lib/hexdump.c | 1 + lib/math/rational.c | 2 +- lib/math/reciprocal_div.c | 1 + 12 files changed, 162 insertions(+), 146 deletions(-) create mode 100644 include/linux/minmax.hinclude/linux/blkdev.h +1
-0@@ -8,6 +8,7 @@#include <linux/genhd.h> #include <linux/list.h> #include <linux/llist.h> +#include <linux/minmax.h> #include <linux/timer.h> #include <linux/workqueue.h> #include <linux/pagemap.h> include/linux/bvec.h +5
-1@@ -7,10 +7,14 @@#ifndef __LINUX_BVEC_ITER_H#define __LINUX_BVEC_ITER_H -#include <linux/kernel.h> #include <linux/bug.h> #include <linux/errno.h> +#include <linux/limits.h> +#include <linux/minmax.h> #include <linux/mm.h> +#include <linux/types.h> + +struct page ;/** * struct bio_vec - a contiguous range of physical memory addresses include/linux/jiffies.h +2
-1@@ -3,8 +3,9 @@#define _LINUX_JIFFIES_H#include <linux/cache.h> +#include <linux/limits.h> #include <linux/math64.h> -#include <linux/kernel.h> +#include <linux/minmax.h> #include <linux/types.h> #include <linux/time.h> #include <linux/timex.h> include/linux/kernel.h +1
-141@@ -11,6 +11,7 @@#include <linux/compiler.h> #include <linux/bitops.h> #include <linux/log2.h> +#include <linux/minmax.h> #include <linux/typecheck.h> #include <linux/printk.h> #include <linux/build_bug.h> @@ -834,147 +835,6 @@ ftrace_vprintk(const char *fmt, va_list ap)static inline void ftrace_dump (enum ftrace_dump_mode oops_dump_mode) { }#endif /* CONFIG_TRACING */ -/* -* min()/max()/clamp() macros must accomplish three things: -* -* - avoid multiple evaluations of the arguments (so side-effects like -* "x++" happen only once) when non-constant. -* - perform strict type-checking (to generate warnings instead of -* nasty runtime surprises). See the "unnecessary" pointer comparison -* in __typecheck(). -* - retain result as a constant expressions when called with only -* constant expressions (to avoid tripping VLA warnings in stack -* allocation usage). -*/ -#define __typecheck (x, y) \ - (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) - -/* -* This returns a constant expression while determining if an argument is -* a constant expression, most importantly without evaluating the argument. -* Glory to Martin Uecker <[email protected]> -*/ -#define __is_constexpr (x) \ - (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8))) - -#define __no_side_effects (x, y) \ - (__is_constexpr(x) && __is_constexpr(y)) - -#define __safe_cmp (x, y) \ - (__typecheck(x, y) && __no_side_effects(x, y)) - -#define __cmp (x, y, op) ((x) op (y) ? (x) : (y)) - -#define __cmp_once (x, y, unique_x, unique_y, op) ({ \ - typeof(x) unique_x = (x); \ - typeof(y) unique_y = (y); \ - __cmp(unique_x, unique_y, op); }) - -#define __careful_cmp (x, y, op) \ - __builtin_choose_expr(__safe_cmp(x, y), \ - __cmp(x, y, op), \ - __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) - -/** -* min - return minimum of two values of the same or compatible types -* @x: first value -* @y: second value -*/ -#define min (x, y) __careful_cmp(x, y, <) - -/** -* max - return maximum of two values of the same or compatible types -* @x: first value -* @y: second value -*/ -#define max (x, y) __careful_cmp(x, y, >) - -/** -* min3 - return minimum of three values -* @x: first value -* @y: second value -* @z: third value -*/ -#define min3 (x, y, z) min((typeof(x))min(x, y), z) - -/** -* max3 - return maximum of three values -* @x: first value -* @y: second value -* @z: third value -*/ -#define max3 (x, y, z) max((typeof(x))max(x, y), z) - -/** -* min_not_zero - return the minimum that is _not_ zero, unless both are zero -* @x: value1 -* @y: value2 -*/ -#define min_not_zero (x, y) ({ \ - typeof(x) __x = (x); \ - typeof(y) __y = (y); \ - __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); }) - -/** -* clamp - return a value clamped to a given range with strict typechecking -* @val: current value -* @lo: lowest allowable value -* @hi: highest allowable value -* -* This macro does strict typechecking of @lo/@hi to make sure they are of the -* same type as @val. See the unnecessary pointer comparisons. -*/ -#define clamp (val, lo, hi) min((typeof(val))max(val, lo), hi) - -/* -* ..and if you can't take the strict -* types, you can specify one yourself. -* -* Or not use min/max/clamp at all, of course. -*/ - -/** -* min_t - return minimum of two values, using the specified type -* @type: data type to use -* @x: first value -* @y: second value -*/ -#define min_t (type, x, y) __careful_cmp((type)(x), (type)(y), <) - -/** -* max_t - return maximum of two values, using the specified type -* @type: data type to use -* @x: first value -* @y: second value -*/ -#define max_t (type, x, y) __careful_cmp((type)(x), (type)(y), >) - -/** -* clamp_t - return a value clamped to a given range using a given type -* @type: the type of variable to use -* @val: current value -* @lo: minimum allowable value -* @hi: maximum allowable value -* -* This macro does no typechecking and uses temporary variables of type -* @type to make all the comparisons. -*/ -#define clamp_t (type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) - -/** -* clamp_val - return a value clamped to a given range using val's type -* @val: current value -* @lo: minimum allowable value -* @hi: maximum allowable value -* -* This macro does no typechecking and uses temporary variables of whatever -* type the input argument @val is. This is useful when @val is an unsigned -* type and @lo and @hi are literals that will otherwise be assigned a signed -* integer type. -*/ -#define clamp_val (val, lo, hi) clamp_t(typeof(val), val, lo, hi) - -/** * swap - swap values of @a and @b * @a: first value include/linux/minmax.h new file +145
-0@@ -0,0 +1,145 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_MINMAX_H +#define _LINUX_MINMAX_H + +/* +* min()/max()/clamp() macros must accomplish three things: +* +* - avoid multiple evaluations of the arguments (so side-effects like +* "x++" happen only once) when non-constant. +* - perform strict type-checking (to generate warnings instead of +* nasty runtime surprises). See the "unnecessary" pointer comparison +* in __typecheck(). +* - retain result as a constant expressions when called with only +* constant expressions (to avoid tripping VLA warnings in stack +* allocation usage). +*/ +#define __typecheck (x, y) \ + (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) + +/* +* This returns a constant expression while determining if an argument is +* a constant expression, most importantly without evaluating the argument. +* Glory to Martin Uecker <[email protected]> +*/ +#define __is_constexpr (x) \ + (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8))) + +#define __no_side_effects (x, y) \ + (__is_constexpr(x) && __is_constexpr(y)) + +#define __safe_cmp (x, y) \ + (__typecheck(x, y) && __no_side_effects(x, y)) + +#define __cmp (x, y, op) ((x) op (y) ? (x) : (y)) + +#define __cmp_once (x, y, unique_x, unique_y, op) ({ \ + typeof(x) unique_x = (x); \ + typeof(y) unique_y = (y); \ + __cmp(unique_x, unique_y, op); }) + +#define __careful_cmp (x, y, op) \ + __builtin_choose_expr(__safe_cmp(x, y), \ + __cmp(x, y, op), \ + __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) + +/** +* min - return minimum of two values of the same or compatible types +* @x: first value +* @y: second value +*/ +#define min (x, y) __careful_cmp(x, y, <) + +/** +* max - return maximum of two values of the same or compatible types +* @x: first value +* @y: second value +*/ +#define max (x, y) __careful_cmp(x, y, >) + +/** +* min3 - return minimum of three values +* @x: first value +* @y: second value +* @z: third value +*/ +#define min3 (x, y, z) min((typeof(x))min(x, y), z) + +/** +* max3 - return maximum of three values +* @x: first value +* @y: second value +* @z: third value +*/ +#define max3 (x, y, z) max((typeof(x))max(x, y), z) + +/** +* min_not_zero - return the minimum that is _not_ zero, unless both are zero +* @x: value1 +* @y: value2 +*/ +#define min_not_zero (x, y) ({ \ + typeof(x) __x = (x); \ + typeof(y) __y = (y); \ + __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); }) + +/** +* clamp - return a value clamped to a given range with strict typechecking +* @val: current value +* @lo: lowest allowable value +* @hi: highest allowable value +* +* This macro does strict typechecking of @lo/@hi to make sure they are of the +* same type as @val. See the unnecessary pointer comparisons. +*/ +#define clamp (val, lo, hi) min((typeof(val))max(val, lo), hi) + +/* +* ..and if you can't take the strict +* types, you can specify one yourself. +* +* Or not use min/max/clamp at all, of course. +*/ + +/** +* min_t - return minimum of two values, using the specified type +* @type: data type to use +* @x: first value +* @y: second value +*/ +#define min_t (type, x, y) __careful_cmp((type)(x), (type)(y), <) + +/** +* max_t - return maximum of two values, using the specified type +* @type: data type to use +* @x: first value +* @y: second value +*/ +#define max_t (type, x, y) __careful_cmp((type)(x), (type)(y), >) + +/** +* clamp_t - return a value clamped to a given range using a given type +* @type: the type of variable to use +* @val: current value +* @lo: minimum allowable value +* @hi: maximum allowable value +* +* This macro does no typechecking and uses temporary variables of type +* @type to make all the comparisons. +*/ +#define clamp_t (type, val, lo, hi) min_t(type, max_t(type, val, lo), hi) + +/** +* clamp_val - return a value clamped to a given range using val's type +* @val: current value +* @lo: minimum allowable value +* @hi: maximum allowable value +* +* This macro does no typechecking and uses temporary variables of whatever +* type the input argument @val is. This is useful when @val is an unsigned +* type and @lo and @hi are literals that will otherwise be assigned a signed +* integer type. +*/ +#define clamp_val (val, lo, hi) clamp_t(typeof(val), val, lo, hi) + +#endif /* _LINUX_MINMAX_H */ include/linux/nodemask.h +1
-1@@ -90,9 +90,9 @@* for such situations. See below and CPUMASK_ALLOC also. */ -#include <linux/kernel.h> #include <linux/threads.h> #include <linux/bitmap.h> +#include <linux/minmax.h> #include <linux/numa.h> typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); } nodemask_t;include/linux/uaccess.h +1
-0@@ -3,6 +3,7 @@#define __LINUX_UACCESS_H__#include <linux/instrumented.h> +#include <linux/minmax.h> #include <linux/sched.h> #include <linux/thread_info.h> kernel/range.c +2
-1@@ -2,8 +2,9 @@/* * Range add and subtract */ -#include <linux/kernel.h> #include <linux/init.h> +#include <linux/minmax.h> +#include <linux/printk.h> #include <linux/sort.h> #include <linux/string.h> #include <linux/range.h> lib/find_bit.c +1
-0@@ -16,6 +16,7 @@#include <linux/bitmap.h> #include <linux/export.h> #include <linux/kernel.h> +#include <linux/minmax.h> #if !defined(find_next_bit) || !defined(find_next_zero_bit) || \ !defined(find_next_bit_le) || !defined(find_next_zero_bit_le) || \lib/hexdump.c +1
-0@@ -7,6 +7,7 @@#include <linux/ctype.h> #include <linux/errno.h> #include <linux/kernel.h> +#include <linux/minmax.h> #include <linux/export.h> #include <asm/unaligned.h> lib/math/rational.c +1
-1@@ -11,7 +11,7 @@#include <linux/rational.h> #include <linux/compiler.h> #include <linux/export.h> -#include <linux/kernel.h> +#include <linux/minmax.h> /* * calculate best rational approximation for a given fraction lib/math/reciprocal_div.c +1
-0@@ -4,6 +4,7 @@#include <asm/div64.h> #include <linux/reciprocal_div.h> #include <linux/export.h> +#include <linux/minmax.h> /* * For a description of the algorithm please have a look at Signature · 1 line
2.28.0
Signature · 2 lines
With Best Regards, Andy Shevchenko