Skip to contentSkip to conversation

ARM: s3c24xx: drop s3c-camif setup platform code

PATCH Applied Krzysztof Kozlowski 1 participant 2 messages Aug 17, 2020 – Aug 19, 2020

Subsystems (5)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v3 1/1 ARM: s3c24xx: drop s3c-camif setup platform code

The s3c-camif driver setup platform code does not have any users so it can be safely removed.

Along with the code W=1 compile warnings go away:

arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes]

---

Continuation of v2 here:
https://patchwork.kernel.org/patch/11700881/

Changes since v2:
1. Drop setup-camif.

Changes since v1:
1. New patch.

---
 arch/arm/mach-s3c24xx/Kconfig       |  6 ---
 arch/arm/mach-s3c24xx/Makefile      |  1 -
 arch/arm/mach-s3c24xx/setup-camif.c | 67 -----------------------------
 include/media/drv-intf/s3c_camif.h  |  4 --
 4 files changed, 78 deletions(-)
 delete mode 100644 arch/arm/mach-s3c24xx/setup-camif.c
arch/arm/mach-s3c24xx/Kconfig +0 -6
index 7673dde9671a..eaea567fcbfe 100644
@@ -123,11 +123,6 @@ config S3C24XX_PLL
 	  This also means that the PLL tables for the selected CPU(s) will
 	  be built which may increase the size of the kernel image.
 
-config S3C_SETUP_CAMIF
-	bool
-	help
-	  Compile in common setup code for S3C CAMIF devices
-
 # cpu frequency items common between s3c2410 and s3c2440/s3c2442
 
 config S3C2410_IOTIMING
@@ -468,7 +463,6 @@ config MACH_MINI2440
 	select NEW_LEDS
 	select S3C_DEV_NAND
 	select S3C_DEV_USB_HOST
-	select S3C_SETUP_CAMIF
 	help
 	  Say Y here to select support for the MINI2440. Is a 10cm x 10cm board
 	  available via various sources. It can come with a 3.5" or 7" touch LCD.
arch/arm/mach-s3c24xx/Makefile +0 -1
index 6692f2de71b2..fbebc5f775e7 100644
@@ -97,4 +97,3 @@ obj-$(CONFIG_S3C2416_SETUP_SDHCI_GPIO)	+= setup-sdhci-gpio.o
 obj-$(CONFIG_S3C2443_SETUP_SPI)		+= setup-spi.o
 obj-$(CONFIG_ARCH_S3C24XX)		+= setup-i2c.o
 obj-$(CONFIG_S3C24XX_SETUP_TS)		+= setup-ts.o
-obj-$(CONFIG_S3C_SETUP_CAMIF)		+= setup-camif.o
arch/arm/mach-s3c24xx/setup-camif.c deleted +0 -67

67 lines not on this page · raw message

include/media/drv-intf/s3c_camif.h +0 -4
index d1200b40f53a..f746851a5ce6 100644
@@ -35,8 +35,4 @@ struct s3c_camif_plat_data {
 	int (*gpio_put)(void);
 };
 
-/* Platform default helper functions */
-int s3c_camif_gpio_get(void);
-int s3c_camif_gpio_put(void);
-
 #endif /* MEDIA_S3C_CAMIF_ */
Signature · 1 line
2.17.1
author maintainer Applied
#1 lore raw
Quoted 11 lines · Krzysztof Kozlowski

The s3c-camif driver setup platform code does not have any users so it can be safely removed.

Along with the code W=1 compile warnings go away:

arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes]

---

Applied to samsung-soc for S3C cleanup.

Best regards,
Krzysztof