Skip to contentSkip to conversation

arm64: dts: qcom: sc7180: Add Display Port dt node

PATCH In review Tanmay Shah 2 participants 3 messages Aug 17, 2020 – Aug 18, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 arm64: dts: qcom: sc7180: Add Display Port dt node

Add DP device node on sc7180.

Changes in v2:

- Add assigned-clocks and assigned-clock-parents
- Remove cell-index and pixel_rcg
- Change compatible to qcom,sc7180-dp

Changes in v3:
- Update commit text
- Make DP child node of MDSS
- Remove data-lanes property from SOC dts
- Disable DP node in SOC dts
- Assign DP to Port2 in MDP node
- Add MDSS AHB clock in DP device node

Changes in v4:
- Remove redundant reg-names property
- Use IRQ flag instead had hard coded value.
- Add link clock source in assigned-clocks list.

Changes in v5:
- Add OPP table and power-domains for DisplayPort

Changes in v6:
- Remove redundant IRQ flag

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 +++++++++++++++++++++++++++-
 1 file changed, 74 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +74 -2
index 31b9217bb5bf..bf2f2bb1aa79 100644
@@ -2371,6 +2371,13 @@ dpu_intf1_out: endpoint {
 							remote-endpoint = <&dsi0_in>;
 						};
 					};
+
+					port@2 {
+						reg = <2>;
+						dpu_intf0_out: endpoint {
+							remote-endpoint = <&dp_in>;
+						};
+					};
 				};
 			};
 
@@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 {
 
 				status = "disabled";
 			};
+
+			msm_dp: displayport-controller@ae90000 {
+				status = "disabled";
+				compatible = "qcom,sc7180-dp";
+
+				reg = <0 0x0ae90000 0 0x1400>;
+
+				interrupt-parent = <&mdss>;
+				interrupts = <12>;
+
+				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_AUX_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_LINK_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>,
+					 <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>;
+				clock-names = "core_iface", "core_aux", "ctrl_link",
+					      "ctrl_link_iface", "stream_pixel";
+				#clock-cells = <1>;
+				assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>,
+						  <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>;
+				assigned-clock-parents = <&msm_dp 0>, <&msm_dp 1>;
+
+				operating-points-v2 = <&dp_opp_table>;
+				power-domains = <&rpmhpd SC7180_CX>;
+
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					port@0 {
+						reg = <0>;
+						dp_in: endpoint {
+							remote-endpoint = <&dpu_intf0_out>;
+						};
+					};
+
+					port@1 {
+						reg = <1>;
+						dp_out: endpoint { };
+					};
+				};
+
+				dp_opp_table: dp-opp-table {
+					compatible = "operating-points-v2";
+
+					opp-160000000 {
+						opp-hz = /bits/ 64 <160000000>;
+						required-opps = <&rpmhpd_opp_low_svs>;
+					};
+
+					opp-270000000 {
+						opp-hz = /bits/ 64 <270000000>;
+						required-opps = <&rpmhpd_opp_svs>;
+					};
+
+					opp-540000000 {
+						opp-hz = /bits/ 64 <540000000>;
+						required-opps = <&rpmhpd_opp_svs_l1>;
+					};
+
+					opp-810000000 {
+						opp-hz = /bits/ 64 <810000000>;
+						required-opps = <&rpmhpd_opp_nom>;
+					};
+				};
+			};
 		};
 
 		dispcc: clock-controller@af00000 {
@@ -2449,8 +2521,8 @@ dispcc: clock-controller@af00000 {
 				 <&gcc GCC_DISP_GPLL0_CLK_SRC>,
 				 <&dsi_phy 0>,
 				 <&dsi_phy 1>,
-				 <0>,
-				 <0>;
+				 <&msm_dp 0>,
+				 <&msm_dp 1>;
 			clock-names = "bi_tcxo",
 				      "gcc_disp_gpll0_clk_src",
 				      "dsi0_phy_pll_out_byteclk",

base-commit: 62975d27d647a40c58d3b96c29b911fc4f33c310

Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Quoting Tanmay Shah (2020-08-17 15:53:00)

arch/arm64/boot/dts/qcom/sc7180.dtsi dsi_phy: dsi-phy@ae94400 { · line 2451

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -0
index 31b9217bb5bf..bf2f2bb1aa79 100644
@@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 {
 
                                status = "disabled";
                        };
+
+                       msm_dp: displayport-controller@ae90000 {

This should come before dsi-phy and dsi node. It should be sorted by the address (0xae90000).

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +8 -0
+                               status = "disabled";
+                               compatible = "qcom,sc7180-dp";
+
+                               reg = <0 0x0ae90000 0 0x1400>;
+
+                               interrupt-parent = <&mdss>;
+                               interrupts = <12>;
+

[...]

arch/arm64/boot/dts/qcom/sc7180.dtsi dispcc: clock-controller@af00000 { · line 2525

Quoted 11 lines
                };
 
                dispcc: clock-controller@af00000 {
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -2
@@ -2449,8 +2521,8 @@ dispcc: clock-controller@af00000 {
                                 <&gcc GCC_DISP_GPLL0_CLK_SRC>,
                                 <&dsi_phy 0>,
                                 <&dsi_phy 1>,
-                                <0>,
-                                <0>;
+                                <&msm_dp 0>,
+                                <&msm_dp 1>;

Don't think we should apply this still because the binding will change when the phy is split out to qmp node. Maybe just leave this part off for now?

#2 lore raw
Quoted 26 lines · Stephen Boyd

Quoting Tanmay Shah (2020-08-17 15:53:00)

arch/arm64/boot/dts/qcom/sc7180.dtsi dsi_phy: dsi-phy@ae94400 { · line 2451

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -0
index 31b9217bb5bf..bf2f2bb1aa79 100644
@@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 {
 
                                status = "disabled";
                        };
+
+                       msm_dp: displayport-controller@ae90000 {

This should come before dsi-phy and dsi node. It should be sorted by the address (0xae90000).

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +8 -0
+                               status = "disabled";
+                               compatible = "qcom,sc7180-dp";
+
+                               reg = <0 0x0ae90000 0 0x1400>;
+
+                               interrupt-parent = <&mdss>;
+                               interrupts = <12>;
+

[...]

Quoted 2 lines
                };
Quoted 13 lines

arch/arm64/boot/dts/qcom/sc7180.dtsi dispcc: clock-controller@af00000 { · line 2525

Quoted 9 lines
                dispcc: clock-controller@af00000 {
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -2
@@ -2449,8 +2521,8 @@ dispcc: clock-controller@af00000 {
                                 <&gcc GCC_DISP_GPLL0_CLK_SRC>,
                                 <&dsi_phy 0>,
                                 <&dsi_phy 1>,
-                                <0>,
-                                <0>;
+                                <&msm_dp 0>,
+                                <&msm_dp 1>;

Don't think we should apply this still because the binding will change when the phy is split out to qmp node. Maybe just leave this part off for now?

Ok fine. But, that will break DP driver functionality.
_______________________________________________
dri-devel mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel