Skip to contentSkip to conversation

scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

PATCH Applied Stanley Chu 3 participants 3 messages Aug 19, 2020 – Sep 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

From: Andy Teng <[email protected]>

MediaTek UFS host starts to support 2 lanes, thus modify the minimum lane count to 2.

This modification shall not impact old 1-lane host because PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the target lanes properly during power mode change. So we could relax the limitation in ufs_dev_params.

---
 drivers/scsi/ufs/ufs-mediatek.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/ufs/ufs-mediatek.h +2 -2
index 8ed24d5fcff9..87657376d27a 100644
@@ -33,8 +33,8 @@
 /*
  * Vendor specific pre-defined parameters
  */
-#define UFS_MTK_LIMIT_NUM_LANES_RX  1
-#define UFS_MTK_LIMIT_NUM_LANES_TX  1
+#define UFS_MTK_LIMIT_NUM_LANES_RX  2
+#define UFS_MTK_LIMIT_NUM_LANES_TX  2
 #define UFS_MTK_LIMIT_HSGEAR_RX     UFS_HS_G3
 #define UFS_MTK_LIMIT_HSGEAR_TX     UFS_HS_G3
 #define UFS_MTK_LIMIT_PWMGEAR_RX    UFS_PWM_G4
Signature · 1 line
2.18.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines

From: Andy Teng <[email protected]>

MediaTek UFS host starts to support 2 lanes, thus modify the minimum lane count to 2.

This modification shall not impact old 1-lane host because PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
target lanes properly during power mode change. So we could relax the limitation in ufs_dev_params.

Quoted 3 lines

But then again, why those constants needs to be re-negotiated every pre-change?

Thanks,
Avri

#2 lore raw
In reply to Stanley Chu
Quoted 7 lines · Stanley Chu

MediaTek UFS host starts to support 2 lanes, thus modify the minimum lane count to 2.

This modification shall not impact old 1-lane host because PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the target lanes properly during power mode change. So we could relax the limitation in ufs_dev_params.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-mediatek: Modify the minimum RX/TX lane count to 2

      https://git.kernel.org/mkp/scsi/c/460d74a0911c
Signature · 6 lines
Martin K. Petersen	Oracle Linux Engineering

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek