libceph: add __maybe_unused to DEFINE_CEPH_FEATURE
Ilya Dryomov
maintainerPATCH 1/1 libceph: add __maybe_unused to DEFINE_CEPH_FEATURE
Avoid -Wunused-const-variable warnings for "make W=1".
Reported-by Leon Romanovsky <[email protected]>
Signed-off-by Ilya Dryomov <[email protected]>
--- include/linux/ceph/ceph_features.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/ceph/ceph_features.h +4 -4
@@ -11,14 +11,14 @@#define CEPH_FEATURE_INCARNATION_2 (1ull<<57) // CEPH_FEATURE_SERVER_JEWEL#define DEFINE_CEPH_FEATURE (bit, incarnation, name) \ - static const uint64_t CEPH_FEATURE_##name = (1ULL<<bit); \ - static const uint64_t CEPH_FEATUREMASK_##name = \ + static const uint64_t __maybe_unused CEPH_FEATURE_##name = (1ULL<<bit); \ + static const uint64_t __maybe_unused CEPH_FEATUREMASK_##name = \ (1ULL<<bit | CEPH_FEATURE_INCARNATION_##incarnation);/* this bit is ignored but still advertised by release *when* */ #define DEFINE_CEPH_FEATURE_DEPRECATED (bit, incarnation, name, when) \ - static const uint64_t DEPRECATED_CEPH_FEATURE_##name = (1ULL<<bit); \ - static const uint64_t DEPRECATED_CEPH_FEATUREMASK_##name = \ + static const uint64_t __maybe_unused DEPRECATED_CEPH_FEATURE_##name = (1ULL<<bit); \ + static const uint64_t __maybe_unused DEPRECATED_CEPH_FEATUREMASK_##name = \ (1ULL<<bit | CEPH_FEATURE_INCARNATION_##incarnation);/*
Signature · 1 line
2.19.2
Quoted 8 lines · Ilya Dryomov
Avoid -Wunused-const-variable warnings for "make W=1".
Reported-by Leon Romanovsky <[email protected]>Signed-off-by Ilya Dryomov <[email protected]>--- include/linux/ceph/ceph_features.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Even better,
It will be great to see this patch in -rc pull request.
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>