Follow up to "Add new board: Xen guest for ARM64" series
Subsystems (2)
cover Follow up to "Add new board: Xen guest for ARM64" series
From: Anastasiia Lukianenko <[email protected]>
Removed unnecessary defines, fixed code style errors and added maintainers to XEN section.
Anastasiia Lukianenko (5):
board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and
board_early_init_f function
MAINTAINERS: Add maintainers to XEN section
board: xen: Remove CONFIG_CMD_RUN define as it is set on by default in
Kconfig
board: xen: Remove unnecessary CONFIG_INITRD_TAG and
CONFIG_CMDLINE_TAG
xen: Code style conformity
MAINTAINERS | 20 ++++++++++++++++++++ board/xen/xenguest_arm64/xenguest_arm64.c | 5 ----- configs/xenguest_arm64_defconfig | 1 - drivers/xen/gnttab.c | 3 ++- drivers/xen/pvblock.c | 12 ++++++------ include/configs/xenguest_arm64.h | 7 ------- include/xen/gnttab.h | 3 +-- lib/sscanf.c | 3 ++- 8 files changed, 31 insertions(+), 23 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/5 board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and board_early_init_f function
From: Anastasiia Lukianenko <[email protected]>
--- board/xen/xenguest_arm64/xenguest_arm64.c | 5 ----- include/configs/xenguest_arm64.h | 2 -- 2 files changed, 7 deletions(-)
board/xen/xenguest_arm64/xenguest_arm64.c +0 -5
@@ -184,11 +184,6 @@ int ft_board_setup(void *blob, bd_t *bd)return 0 ; } -int board_early_init_f (void ) -{ -return 0 ; -} -int print_cpuinfo (void ) {printf ("Xen virtual CPU\n" );
include/configs/xenguest_arm64.h +0 -2
@@ -9,8 +9,6 @@#include <linux/types.h> #endif -#define CONFIG_BOARD_EARLY_INIT_F -#define CONFIG_EXTRA_ENV_SETTINGS #undef CONFIG_NR_DRAM_BANKS
Signature · 1 line
2.17.1
PATCH 1/5 board: xen: Remove unnecessary CONFIG_BOARD_EARLY_INIT_F define and board_early_init_f function
Quoted 3 lines · Anastasiia Lukianenko
From: Anastasiia Lukianenko <[email protected]>
Signed-off-by Anastasiia Lukianenko <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/0ce5dbbc/attachment.sig>
PATCH 2/5 MAINTAINERS: Add maintainers to XEN section
In reply to Anastasiia LukianenkoFrom: Anastasiia Lukianenko <[email protected]>
--- MAINTAINERS | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
MAINTAINERS +20 -0
@@ -1028,6 +1028,26 @@ T: git https://gitlab.denx.de/u-boot/custodians/u-boot-x86.git F: arch/x86/ F: cmd/x86/ +XEN +M: Anastasiia Lukianenko <[email protected]> +M: Oleksandr Andrushchenko <[email protected]> +S: Maintained +F: arch/arm/cpu/armv8/xen/ +F: arch/arm/include/asm/xen.h +F: arch/arm/include/asm/xen/ +F: board/xen/xenguest_arm64/ +F: cmd/pvblock.c +F: configs/xenguest_arm64_defconfig +F: doc/board/xen/ +F: drivers/serial/serial_xen.c +F: drivers/xen/ +F: include/configs/xenguest_arm64.h +F: include/pvblock.h +F: include/xen/ +F: include/xen.h +F: lib/sscanf.c +F: test/lib/sscanf.c + XTENSA M: Max Filippov <[email protected]> S: Maintained
Signature · 1 line
2.17.1
PATCH 2/5 MAINTAINERS: Add maintainers to XEN section
Quoted 24 lines · Anastasiia Lukianenko
From: Anastasiia Lukianenko <[email protected]>
Signed-off-by Anastasiia Lukianenko <[email protected]>--- MAINTAINERS | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)MAINTAINERS +9
-0@@ -1028,6 +1028,26 @@ T: git https://gitlab.denx.de/u-boot/custodians/u-boot-x86.git F: arch/x86/ F: cmd/x86/ +XEN +M: Anastasiia Lukianenko <[email protected]> +M: Oleksandr Andrushchenko <[email protected]> +S: Maintained +F: arch/arm/cpu/armv8/xen/ +F: arch/arm/include/asm/xen.h +F: arch/arm/include/asm/xen/ +F: board/xen/xenguest_arm64/ +F: cmd/pvblock.c
MAINTAINERS T: git https://gitlab.denx.de/u-boot/custodians/u-boot-x86.git · line 1049
Quoted 10 lines
MAINTAINERS +10
-0+F: configs/xenguest_arm64_defconfig +F: doc/board/xen/ +F: drivers/serial/serial_xen.c +F: drivers/xen/ +F: include/configs/xenguest_arm64.h +F: include/pvblock.h +F: include/xen/ +F: include/xen.h +F: lib/sscanf.c +F: test/lib/sscanf.c
Note that this duplicates some of board/xen/xenguest_arm64/MAINTAINERS and it's probably best to keep the board-specific parts under there anyhow.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/aef19fb3/attachment.sig>
PATCH 3/5 board: xen: Remove CONFIG_CMD_RUN define as it is set on by default in Kconfig
In reply to Anastasiia LukianenkoFrom: Anastasiia Lukianenko <[email protected]>
--- configs/xenguest_arm64_defconfig | 1 - include/configs/xenguest_arm64.h | 2 -- 2 files changed, 3 deletions(-)
configs/xenguest_arm64_defconfig +0 -1
@@ -17,7 +17,6 @@ CONFIG_CMD_ELF=n CONFIG_CMD_EXT4=y CONFIG_CMD_FAT=y CONFIG_CMD_GO=n -CONFIG_CMD_RUN=n CONFIG_CMD_IMI=n CONFIG_CMD_IMLS=n CONFIG_CMD_XIMG=n
include/configs/xenguest_arm64.h +0 -2
@@ -39,8 +39,6 @@#define CONFIG_CMDLINE_TAG 1#define CONFIG_INITRD_TAG 1 -#define CONFIG_CMD_RUN -#undef CONFIG_EXTRA_ENV_SETTINGS#define CONFIG_EXTRA_ENV_SETTINGS \ "loadimage=ext4load pvblock 0 0x90000000 /boot/Image;\0" \
Signature · 1 line
2.17.1
PATCH 3/5 board: xen: Remove CONFIG_CMD_RUN define as it is set on by default in Kconfig
Hi,
st 19. 8. 2020 v 14:43 odes?latel Anastasiia Lukianenko <[email protected]> napsal:
Quoted 2 lines
From: Anastasiia Lukianenko <[email protected]>
You really need to write something here.
Quoted 12 lines
Signed-off-by Anastasiia Lukianenko <[email protected]>--- configs/xenguest_arm64_defconfig | 1 - include/configs/xenguest_arm64.h | 2 -- 2 files changed, 3 deletions(-)configs/xenguest_arm64_defconfig +0
-0
configs/xenguest_arm64_defconfig CONFIG_CMD_ELF=n · line 20
Quoted 4 lines
configs/xenguest_arm64_defconfig +0
-1@@ -17,7 +17,6 @@ CONFIG_CMD_ELF=n CONFIG_CMD_EXT4=y CONFIG_CMD_FAT=y CONFIG_CMD_GO=n -CONFIG_CMD_RUN=n
I have seen one message where you got a recommendation to use savedefconfig. That's why please use it. All these options =n are just wrong.
Thanks,
Michal
Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
PATCH 4/5 board: xen: Remove unnecessary CONFIG_INITRD_TAG and CONFIG_CMDLINE_TAG
In reply to Anastasiia LukianenkoFrom: Anastasiia Lukianenko <[email protected]>
--- include/configs/xenguest_arm64.h | 3 --- 1 file changed, 3 deletions(-)
include/configs/xenguest_arm64.h +0 -3
@@ -36,9 +36,6 @@#define CONFIG_OF_SYSTEM_SETUP -#define CONFIG_CMDLINE_TAG 1 -#define CONFIG_INITRD_TAG 1 -#undef CONFIG_EXTRA_ENV_SETTINGS#define CONFIG_EXTRA_ENV_SETTINGS \ "loadimage=ext4load pvblock 0 0x90000000 /boot/Image;\0" \
Signature · 1 line
2.17.1
PATCH 5/5 xen: Code style conformity
In reply to Anastasiia LukianenkoFrom: Anastasiia Lukianenko <[email protected]>
--- drivers/xen/gnttab.c | 3 ++- drivers/xen/pvblock.c | 12 ++++++------ include/xen/gnttab.h | 3 +-- lib/sscanf.c | 3 ++- 4 files changed, 11 insertions(+), 10 deletions(-)
drivers/xen/gnttab.c +2 -1
@@ -100,7 +100,8 @@ int gnttab_end_access(grant_ref_t ref) nflags = gnttab_table[ref].flags; do { - if ((flags = nflags) & (GTF_reading | GTF_writing)) { + flags = nflags; + if ((flags) & (GTF_reading | GTF_writing)) { printf("WARNING: g.e. still in use! (%x)\n", flags); return 0; }
drivers/xen/pvblock.c +6 -6
@@ -294,8 +294,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev)snprintf (path,sizeof (path),"%s/state" , dev->backend);snprintf (nodename,sizeof (nodename),"%s/state" , dev->nodename); -if ((err =xenbus_switch_state (XBT_NIL , nodename, - XenbusStateClosing)) !=NULL ) { + err =xenbus_switch_state (XBT_NIL , nodename, XenbusStateClosing); +if (err !=NULL ) {printf ("%s: error changing state to %d: %s\n" , __func__, XenbusStateClosing, err); goto close;
@@ -306,8 +306,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev) err =xenbus_wait_for_state_change (path, &state);free (err); -if ((err =xenbus_switch_state (XBT_NIL , nodename, - XenbusStateClosed)) !=NULL ) { + err =xenbus_switch_state (XBT_NIL , nodename, XenbusStateClosed); +if (err !=NULL ) {printf ("%s: error changing state to %d: %s\n" , __func__, XenbusStateClosed, err); goto close;
@@ -319,8 +319,8 @@ static void shutdown_blkfront(struct blkfront_dev *dev)free (err); } -if ((err =xenbus_switch_state (XBT_NIL , nodename, - XenbusStateInitialising)) !=NULL ) { + err =xenbus_switch_state (XBT_NIL , nodename, XenbusStateInitialising); +if (err !=NULL ) {printf ("%s: error changing state to %d: %s\n" , __func__, XenbusStateInitialising, err); goto close;
include/xen/gnttab.h +1 -2
@@ -1,5 +1,4 @@ -/* -* SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 * * (C) 2006, Steven Smith <[email protected]> * (C) 2006, Grzegorz Milos <[email protected]>
lib/sscanf.c +2 -1
@@ -555,7 +555,8 @@ literal:if (flags &SUPPRESS ) {size_t sum =0 ; -if ((n = inr) < width) { + n = inr; +if (n < width) { sum += n; width -= n; inp += n;
Signature · 1 line
2.17.1
PATCH 5/5 xen: Code style conformity
Quoted 3 lines · Anastasiia Lukianenko
From: Anastasiia Lukianenko <[email protected]>
Signed-off-by Anastasiia Lukianenko <[email protected]>
Checkpatch still notes:
CHECK: Comparison to NULL could be written "err"
And please add a commit message saying what you're cleaning up. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200819/b5b6011a/attachment.sig>