iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable
Subsystems (7)
PATCH RESEND 1/5 iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable
The of_device_id is included unconditionally by of.h header and used in the driver as well. Remove of_match_ptr to fix W=1 compile test warning with !CONFIG_OF:
drivers/iommu/mtk_iommu.c:833:34: warning: 'mtk_iommu_of_ids' defined but not used [-Wunused-const-variable=]
833 | static const struct of_device_id mtk_iommu_of_ids[] = {
--- drivers/iommu/mtk_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/mtk_iommu.c +1 -1
@@ -843,7 +843,7 @@ static struct platform_driver mtk_iommu_driver = { .remove = mtk_iommu_remove, .driver = { .name = "mtk-iommu", - .of_match_table = of_match_ptr(mtk_iommu_of_ids), + .of_match_table = mtk_iommu_of_ids, .pm = &mtk_iommu_pm_ops, } };
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH RESEND 2/5 iommu: amd: Add missing function prototypes to fix -Wmissing-prototypes
Few exported functions from AMD IOMMU driver are missing prototypes. They have declaration in arch/x86/events/amd/iommu.h but this file cannot be included in the driver. Add prototypes to fix W=1 warnings like:
drivers/iommu/amd/init.c:3066:19: warning:
no previous prototype for 'get_amd_iommu' [-Wmissing-prototypes]
3066 | struct amd_iommu *get_amd_iommu(unsigned int idx)
--- drivers/iommu/amd/amd_iommu.h | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/iommu/amd/amd_iommu.h +9 -0
@@ -41,6 +41,15 @@ extern int amd_iommu_guest_ir;struct iommu_domain ;extern bool amd_iommu_v2_supported (void ); +extern struct amd_iommu *get_amd_iommu (unsigned int idx); +extern u8 amd_iommu_pc_get_max_banks (unsigned int idx); +extern bool amd_iommu_pc_supported (void ); +extern u8 amd_iommu_pc_get_max_counters (unsigned int idx); +extern int amd_iommu_pc_get_reg (struct amd_iommu *iommu,u8 bank,u8 cntr, +u8 fxn,u64 *value); +extern int amd_iommu_pc_set_reg (struct amd_iommu *iommu,u8 bank,u8 cntr, +u8 fxn,u64 *value); +extern int amd_iommu_register_ppr_notifier (struct notifier_block *nb);extern int amd_iommu_unregister_ppr_notifier (struct notifier_block *nb);extern void amd_iommu_domain_direct_map (struct iommu_domain *dom);
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH RESEND 3/5 iommu: amd: Fix kerneldoc
In reply to Krzysztof KozlowskiFix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type' drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
--- drivers/iommu/amd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/amd/init.c +2 -2
@@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)/** * get_highest_supported_ivhd_type - Look up the appropriate IVHD type -* @ivrs Pointer to the IVRS header +* @ivrs: Pointer to the IVRS header * * This function search through all IVDB of the maximum supported IVHD */
@@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu)#define XT_INT_VEC (x) (((x) & 0xFFULL) << 32)#define XT_INT_DEST_HI (x) ((((x) >> 24) & 0xFFULL) << 56) -/** +/* * Setup the IntCapXT registers with interrupt routing information * based on the PCI MSI capability block registers, accessed via * MMIO MSI address low/hi and MSI data registers.
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH RESEND 4/5 iommu: intel: Drop kerneldoc marker from regular comment
In reply to Krzysztof KozlowskiFix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel/dmar.c +1 -1
@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)return NULL ; } -/** +/* * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition * structure which uniquely represent one DMA remapping hardware unit * present in the platform
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
PATCH RESEND 5/5 iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
In reply to Krzysztof KozlowskiThe of_device_id is included unconditionally by of.h header and used in the driver as well. Remove of_match_ptr to fix W=1 compile test warning with !CONFIG_OF:
drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
910 | static const struct of_device_id qcom_iommu_of_match[] = {
--- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/arm/arm-smmu/qcom_iommu.c +2 -2
@@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {static struct platform_driver qcom_iommu_ctx_driver = { .driver = { .name ="qcom-iommu-ctx" , - .of_match_table =of_match_ptr (ctx_of_match), + .of_match_table = ctx_of_match, }, .probe = qcom_iommu_ctx_probe, .remove = qcom_iommu_ctx_remove,
@@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {static struct platform_driver qcom_iommu_driver = { .driver = { .name ="qcom-iommu" , - .of_match_table =of_match_ptr (qcom_iommu_of_match), + .of_match_table = qcom_iommu_of_match, .pm = &qcom_iommu_pm_ops, }, .probe = qcom_iommu_device_probe,
Signature · 1 line
2.17.1
Re: [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment
In reply to Krzysztof KozlowskiHi,
Quoted 5 lines · Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'Signed-off-by Krzysztof Kozlowski <[email protected]>
Adjust the commit title to "iommu/vt-d: Drop kerneldoc marker from regular comment",
Best regards,
baolu
Quoted 18 lines
--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/intel/dmar.c +1
-1@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)return NULL ; } -/** +/* * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition * structure which uniquely represent one DMA remapping hardware unit * present in the platform