Skip to contentSkip to conversation

Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error

PATCH In review Graeme Hayes 2 participants 2 messages Aug 19, 2020 – Aug 20, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: kbuild: modules.rst: Edit '$$' typo, avoid make error

Typo '$$' generates make error when run, and was pasted twice more.

---
 linux-kbuild/Documentation/kbuild/modules.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
linux-kbuild/Documentation/kbuild/modules.rst +0 -0
index 85ccc87..c7837a5 100644
@@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::

KDIR ?= /lib/modules/uname -r/build

default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD

# Module specific targets
genbin:
@@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
KDIR ?= /lib/modules/uname -r/build

default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD

# Module specific targets
genbin:
@@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
KDIR ?= /lib/modules/uname -r/build

default:
- $(MAKE) -C $(KDIR) M=$$PWD
+ $(MAKE) -C $(KDIR) M=$PWD

# Module specific targets
genbin:

Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Graeme Hayes

Typo '$$' generates make error when run, and was pasted twice more.

Are you sure?

$$PWD is the correct escape sequence
to expand $PWD in the shell instead of Make.

Quoted 40 lines
---
 linux-kbuild/Documentation/kbuild/modules.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
linux-kbuild/Documentation/kbuild/modules.rst +3 -4
index 85ccc87..c7837a5 100644
@@ -205,7 +205,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
@@ -239,7 +239,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
@@ -268,7 +268,7 @@ module 8123.ko, which is built from the following files::
                KDIR ?= /lib/modules/`uname -r`/build
 
                default:
-                       $(MAKE) -C $(KDIR) M=$$PWD
+                       $(MAKE) -C $(KDIR) M=$PWD
 
                # Module specific targets
                genbin:
--

2.17.1

Signature · 2 lines
Best Regards
Masahiro Yamada