drm/amdgpu: change reset lock from mutex to rw_semaphore
Subsystems (2)
PATCH 1/1 drm/amdgpu: change reset lock from mutex to rw_semaphore
clients don't need reset-lock for synchronization when no GPU recovery.
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -1
@@ -954,7 +954,7 @@ struct amdgpu_device {atomic_t in_gpu_reset;enum pp_mp1_state mp1_state; -struct mutex lock_reset; +struct rw_semaphore reset_sem;struct amdgpu_doorbell_index doorbell_index;struct mutex notifier_lock;
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +13 -6
@@ -101,14 +101,17 @@ static int amdgpu_debugfs_autodump_open(struct inode *inode, struct file *file) file->private_data = adev; -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ; +if (adev->autodump.dumping.done) {reinit_completion (&adev->autodump.dumping); ret =0 ; }else { ret = -EBUSY ; } -mutex_unlock (&adev->lock_reset); + +up_read (&adev->reset_sem);return ret; }
@@ -1242,7 +1245,8 @@ static int amdgpu_debugfs_test_ib(struct seq_file *m, void *data) }/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ;/* hold on the scheduler */ for (i =0 ; i <AMDGPU_MAX_RINGS ; i++) {
@@ -1269,7 +1273,7 @@ static int amdgpu_debugfs_test_ib(struct seq_file *m, void *data)kthread_unpark (ring->sched.thread); } -mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev);
@@ -1459,7 +1463,10 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)return -ENOMEM ;/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) { +kfree (fences); +return -EINTR ; + }/* stop the scheduler */ kthread_park (ring->sched.thread);
@@ -1500,7 +1507,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)/* restart the scheduler */ kthread_unpark (ring->sched.thread); -mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);ttm_bo_unlock_delayed_workqueue (&adev->mman.bdev, resched);
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -3
@@ -3054,7 +3054,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,mutex_init (&adev->virt.vf_errors.lock);hash_init (adev->mn_hash);atomic_set (&adev->in_gpu_reset,0 ); -mutex_init (&adev->lock_reset); +init_rwsem (&adev->reset_sem);mutex_init (&adev->psp.mutex);mutex_init (&adev->notifier_lock);
@@ -4206,7 +4206,7 @@ static bool amdgpu_device_lock_adev(struct amdgpu_device *adev)if (atomic_cmpxchg (&adev->in_gpu_reset,0 ,1 ) !=0 )return false; -mutex_lock (&adev->lock_reset); +down_write (&adev->reset_sem);atomic_inc (&adev->gpu_reset_counter);switch (amdgpu_asic_reset_method (adev)) {
@@ -4229,7 +4229,7 @@ static void amdgpu_device_unlock_adev(struct amdgpu_device *adev)amdgpu_vf_error_trans_all (adev); adev->mp1_state =PP_MP1_STATE_NONE ;atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); +up_write (&adev->reset_sem); }static void amdgpu_device_resume_display_audio (struct amdgpu_device *adev)
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +2 -12
@@ -238,19 +238,12 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =AI_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by * the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem); do { if (xgpu_ai_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)
@@ -261,10 +254,7 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) }while (timeout >1 ); flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c +2 -12
@@ -259,19 +259,12 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =NV_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by * the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem); do { if (xgpu_nv_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)
@@ -282,10 +275,7 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) }while (timeout >1 ); flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 20.08.20 um 04:09 schrieb Dennis Li:
Quoted 23 lines
clients don't need reset-lock for synchronization when no GPU recovery.
Signed-off-by Dennis Li <[email protected]>drivers/gpu/drm/amd/amdgpu/amdgpu.h +1
-1@@ -954,7 +954,7 @@ struct amdgpu_device {atomic_t in_gpu_reset;enum pp_mp1_state mp1_state; -struct mutex lock_reset; +struct rw_semaphore reset_sem;struct amdgpu_doorbell_index doorbell_index;struct mutex notifier_lock;drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_autodump_open(struct inode *inode, struct file *file) · line 105
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2
-1@@ -101,14 +101,17 @@ static int amdgpu_debugfs_autodump_open(struct inode *inode, struct file *file) file->private_data = adev; -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ;
Better use ret = down_read_killable(); if (ret) return ret; here. Same for all other places of course.
Quoted 33 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +6
-3+if (adev->autodump.dumping.done) {reinit_completion (&adev->autodump.dumping); ret =0 ; }else { ret = -EBUSY ; } -mutex_unlock (&adev->lock_reset); + +up_read (&adev->reset_sem);return ret; }@@ -1242,7 +1245,8 @@ static int amdgpu_debugfs_test_ib(struct seq_file *m, void *data) }/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ;/* hold on the scheduler */ for (i =0 ; i <AMDGPU_MAX_RINGS ; i++) {@@ -1269,7 +1273,7 @@ static int amdgpu_debugfs_test_ib(struct seq_file *m, void *data)kthread_unpark (ring->sched.thread); } -mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev);
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_ib_preempt(void *data, u64 val) · line 1468
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3
-1@@ -1459,7 +1463,10 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)return -ENOMEM ;/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) { +kfree (fences); +return -EINTR ;
Maybe better use a "goto err;" style error handling here.
Quoted 56 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2
-1+ }/* stop the scheduler */ kthread_park (ring->sched.thread);@@ -1500,7 +1507,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)/* restart the scheduler */ kthread_unpark (ring->sched.thread); -mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);ttm_bo_unlock_delayed_workqueue (&adev->mman.bdev, resched);drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3
-3@@ -3054,7 +3054,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,mutex_init (&adev->virt.vf_errors.lock);hash_init (adev->mn_hash);atomic_set (&adev->in_gpu_reset,0 ); -mutex_init (&adev->lock_reset); +init_rwsem (&adev->reset_sem);mutex_init (&adev->psp.mutex);mutex_init (&adev->notifier_lock);@@ -4206,7 +4206,7 @@ static bool amdgpu_device_lock_adev(struct amdgpu_device *adev)if (atomic_cmpxchg (&adev->in_gpu_reset,0 ,1 ) !=0 )return false; -mutex_lock (&adev->lock_reset); +down_write (&adev->reset_sem);atomic_inc (&adev->gpu_reset_counter);switch (amdgpu_asic_reset_method (adev)) {@@ -4229,7 +4229,7 @@ static void amdgpu_device_unlock_adev(struct amdgpu_device *adev)amdgpu_vf_error_trans_all (adev); adev->mp1_state =PP_MP1_STATE_NONE ;atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); +up_write (&adev->reset_sem); }static void amdgpu_device_resume_display_audio (struct amdgpu_device *adev)drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +0
-1@@ -238,19 +238,12 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =AI_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c static void xgpu_ai_mailbox_flr_work(struct work_struct *work) · line 246
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-7* the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem);
Somebody from the virtualization team should take a look at this as well.
Christian.
Quoted 42 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-4do { if (xgpu_ai_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)@@ -261,10 +254,7 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) }while (timeout >1 ); flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c +1
-8@@ -259,19 +259,12 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =NV_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by * the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem); do { if (xgpu_nv_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)@@ -282,10 +275,7 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) }while (timeout >1 );
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c static void xgpu_nv_mailbox_flr_work(struct work_struct *work) · line 281
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c +1
-4flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Hi, Christian,
Thanks for your review. I will update it according to your suggestion.
Best Regards
Dennis Li
-----Original Message-----
From: Christian König <[email protected]>
Sent: Thursday, August 20, 2020 5:11 PM
To: Li, Dennis <[email protected]>; [email protected]; Deucher, Alexander <[email protected]>; Kuehling, Felix <[email protected]>; Zhang, Hawking <[email protected]>; Koenig, Christian <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: change reset lock from mutex to rw_semaphore
Am 20.08.20 um 04:09 schrieb Dennis Li:
Quoted 25 lines
clients don't need reset-lock for synchronization when no GPU recovery.
Signed-off-by Dennis Li <[email protected]>drivers/gpu/drm/amd/amdgpu/amdgpu.h +1
-1@@ -954,7 +954,7 @@ struct amdgpu_device {atomic_t in_gpu_reset;enum pp_mp1_state mp1_state; -struct mutex lock_reset; +struct rw_semaphore reset_sem;struct amdgpu_doorbell_index doorbell_index;struct mutex notifier_lock;drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_autodump_open(struct · line 106
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2
-1@@ -101,14 +101,17 @@ static int amdgpu_debugfs_autodump_open(struct inode *inode, struct file *file) file->private_data = adev; -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ;
Better use ret = down_read_killable(); if (ret) return ret; here. Same for all other places of course.
Quoted 33 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3
-1+if (adev->autodump.dumping.done) {reinit_completion (&adev->autodump.dumping); ret =0 ; }else { ret = -EBUSY ; } -mutex_unlock (&adev->lock_reset); + +up_read (&adev->reset_sem);return ret;}drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2
-1@@ -1242,7 +1245,8 @@ static int amdgpu_debugfs_test_ib(struct seq_file *m, void *data) }/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) +return -EINTR ;/* hold on the scheduler */ for (i = 0; i < AMDGPU_MAX_RINGS; i++) { @@ -1269,7 +1273,7 @@static int
amdgpu_debugfs_test_ib(struct seq_file *m, void *data)
kthread_unpark(ring->sched.thread);
}drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1
-1-mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);pm_runtime_mark_last_busy (dev->dev);pm_runtime_put_autosuspend (dev->dev);
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static int amdgpu_debugfs_ib_preempt(void *data, u64 val) · line 1468
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3
-1@@ -1459,7 +1463,10 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)return -ENOMEM ;/* Avoid accidently unparking the sched thread during GPU reset */ -mutex_lock (&adev->lock_reset); +if (down_read_killable (&adev->reset_sem)) { +kfree (fences); +return -EINTR ;
Maybe better use a "goto err;" style error handling here.
Quoted 58 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2
-1+ }/* stop the scheduler */ kthread_park (ring->sched.thread);@@ -1500,7 +1507,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)/* restart the scheduler */ kthread_unpark (ring->sched.thread); -mutex_unlock (&adev->lock_reset); +up_read (&adev->reset_sem);ttm_bo_unlock_delayed_workqueue (&adev->mman.bdev, resched);drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-2@@ -3054,7 +3054,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,mutex_init (&adev->virt.vf_errors.lock);hash_init (adev->mn_hash);atomic_set (&adev->in_gpu_reset,0 ); -mutex_init (&adev->lock_reset); +init_rwsem (&adev->reset_sem);mutex_init (&adev->psp.mutex);mutex_init (&adev->notifier_lock);@@ -4206,7 +4206,7 @@ static bool amdgpu_device_lock_adev(struct amdgpu_device *adev)if (atomic_cmpxchg (&adev->in_gpu_reset,0 ,1 ) !=0 )return false; -mutex_lock (&adev->lock_reset); +down_write (&adev->reset_sem);atomic_inc (&adev->gpu_reset_counter); switch (amdgpu_asic_reset_method(adev)) { @@ -4229,7 +4229,7 @@static void
amdgpu_device_unlock_adev(struct amdgpu_device *adev)
amdgpu_vf_error_trans_all(adev);adev->mp1_state=PP_MP1_STATE_NONE;atomic_set(&adev->in_gpu_reset, 0);drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1-mutex_unlock (&adev->lock_reset); +up_write (&adev->reset_sem); } static void amdgpu_device_resume_display_audio(struct amdgpu_device*adev) diff --git
a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.cb/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
indexf27d83f2de78..8ac63f13fc6f100644drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +0
-1@@ -238,19 +238,12 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =AI_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c static void xgpu_ai_mailbox_flr_work(struct work_struct *work) · line 246
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-7* the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem);
Somebody from the virtualization team should take a look at this as well.
Christian.
Quoted 43 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +1
-4do { if (xgpu_ai_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)@@ -261,10 +254,7 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work) }while (timeout >1 ); flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c +1
-8@@ -259,19 +259,12 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) struct amdgpu_virt *virt = container_of(work, struct amdgpu_virt, flr_work); struct amdgpu_device *adev = container_of(virt, struct amdgpu_device, virt);int timeout =NV_MAILBOX_POLL_FLR_TIMEDOUT ; -int locked;/* block amdgpu_gpu_recover till msg FLR COMPLETE received, * otherwise the mailbox msg will be ruined/reseted by * the VF FLR. -* -* we can unlock the lock_reset to allow "amdgpu_job_timedout" -* to run gpu_recover() after FLR_NOTIFICATION_CMPL received -* which means host side had finished this VF's FLR. */ - locked =mutex_trylock (&adev->lock_reset); -if (locked) -atomic_set (&adev->in_gpu_reset,1 ); +down_read (&adev->reset_sem); do { if (xgpu_nv_mailbox_peek_msg(adev) == IDH_FLR_NOTIFICATION_CMPL)@@ -282,10 +275,7 @@ static void xgpu_nv_mailbox_flr_work(struct work_struct *work) }while (timeout >1 );
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c static void xgpu_nv_mailbox_flr_work(struct work_struct *work) · line 281
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c +1
-4flr_done: -if (locked) { -atomic_set (&adev->in_gpu_reset,0 ); -mutex_unlock (&adev->lock_reset); - } +up_read (&adev->reset_sem);/* Trigger recovery for world switch failure if no TDR */ if (amdgpu_device_should_recover_gpu(adev)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx