drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
Subsystems (3)
PATCH 1/1 drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
In amdgpu_dm_update_backlight_caps(), there is a local amdgpu_dm_backlight_caps object that is filled in by amdgpu_acpi_get_backlight_caps(). However, this object is uninitialized before the call and hence the subsequent check for aux_support can fail since it is not initialized by amdgpu_acpi_get_backlight_caps() as well. This change initializes this local amdgpu_dm_backlight_caps object to 0.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -2853,7 +2853,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)static void amdgpu_dm_update_backlight_caps (struct amdgpu_display_manager *dm) {#if defined(CONFIG_ACPI ) -struct amdgpu_dm_backlight_caps caps; +struct amdgpu_dm_backlight_caps caps = {0 };if (dm->backlight_caps.caps_valid)return ;
Signature · 1 line
2.28.0.297.g1956fa8f8d-goog
Christian König
maintainerAm 20.08.20 um 07:26 schrieb Furquan Shaikh:
Quoted 18 lines
In
amdgpu_dm_update_backlight_caps(), there is a localamdgpu_dm_backlight_capsobject that is filled in byamdgpu_acpi_get_backlight_caps(). However, this object is uninitialized before the call and hence the subsequent check foraux_supportcan fail since it is not initialized byamdgpu_acpi_get_backlight_caps()as well. This change initializes this localamdgpu_dm_backlight_capsobject to 0.Signed-off-by Furquan Shaikh <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev) · line 2856
Quoted 5 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-1@@ -2853,7 +2853,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)static void amdgpu_dm_update_backlight_caps (struct amdgpu_display_manager *dm) {#if defined(CONFIG_ACPI ) -struct amdgpu_dm_backlight_caps caps; +struct amdgpu_dm_backlight_caps caps = {0 };
Please use memset instead of "{ 0 }" for initialization.
Christian.
Quoted 3 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0if (dm->backlight_caps.caps_valid)return ;
PATCH v2 1/1 drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
In reply to Furquan ShaikhIn amdgpu_dm_update_backlight_caps(), there is a local amdgpu_dm_backlight_caps object that is filled in by amdgpu_acpi_get_backlight_caps(). However, this object is uninitialized before the call and hence the subsequent check for aux_support can fail since it is not initialized by amdgpu_acpi_get_backlight_caps() as well. This change initializes this local amdgpu_dm_backlight_caps object to 0.
---
v2: Switched to using memset for initialization of object.
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -0
@@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)#if defined(CONFIG_ACPI )struct amdgpu_dm_backlight_caps caps; +memset (&caps,0 ,sizeof (caps)); +if (dm->backlight_caps.caps_valid)return ;
Signature · 1 line
2.28.0.297.g1956fa8f8d-goog
Am 20.08.20 um 09:52 schrieb Furquan Shaikh:
Quoted 9 lines
In
amdgpu_dm_update_backlight_caps(), there is a localamdgpu_dm_backlight_capsobject that is filled in byamdgpu_acpi_get_backlight_caps(). However, this object is uninitialized before the call and hence the subsequent check foraux_supportcan fail since it is not initialized byamdgpu_acpi_get_backlight_caps()as well. This change initializes this localamdgpu_dm_backlight_capsobject to 0.Signed-off-by Furquan Shaikh <[email protected]>
Quoted 11 lines
---
v2: Switched to using memset for initialization of object.
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 2 ++1 file changed, 2 insertions(+)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm) · line 2862
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-0@@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)#if defined(CONFIG_ACPI )struct amdgpu_dm_backlight_caps caps; +memset (&caps,0 ,sizeof (caps)); +if (dm->backlight_caps.caps_valid)return ;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 28 lines · Christian König
Am 20.08.20 um 09:52 schrieb Furquan Shaikh:
Quoted 9 lines
In
amdgpu_dm_update_backlight_caps(), there is a localamdgpu_dm_backlight_capsobject that is filled in byamdgpu_acpi_get_backlight_caps(). However, this object is uninitialized before the call and hence the subsequent check foraux_supportcan fail since it is not initialized byamdgpu_acpi_get_backlight_caps()as well. This change initializes this localamdgpu_dm_backlight_capsobject to 0.Signed-off-by Furquan Shaikh <[email protected]>Reviewed-by Christian König <[email protected]>Quoted 14 lines
---
v2: Switched to using memset for initialization of object.
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 2 ++1 file changed, 2 insertions(+)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0@@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)#if defined(CONFIG_ACPI )struct amdgpu_dm_backlight_caps caps;
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm) · line 2862
Quoted 5 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-0+memset (&caps,0 ,sizeof (caps)); +if (dm->backlight_caps.caps_valid)return ;_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel