pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
PATCH 1/1 pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine
Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
--- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/pc_q35.c +1 -1
@@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m) m->numa_mem_supported = true;compat_props_add (m->compat_props, hw_compat_5_0, hw_compat_5_0_len);compat_props_add (m->compat_props, pc_compat_5_0, pc_compat_5_0_len); - m->auto_enable_numa_with_memhp = false; + m->auto_enable_numa_with_memdev = false; } DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
Signature · 1 line
2.26.2
Quoted 11 lines · * David Hildenbrand ([email protected]) wrote:
Unfortunately, a typo sneeked in: we want to set
auto_enable_numa_with_memdevto false, notauto_enable_numa_with_memhp.Cc [email protected] # v5.1Fixes 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)Reported-by Dr. David Alan Gilbert <[email protected]>Cc Paolo Bonzini <[email protected]>Cc Richard Henderson <[email protected]>Cc Eduardo Habkost <[email protected]>Cc "Michael S. Tsirkin" <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 20 lines
--- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/i386/pc_q35.c +1
-1@@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m) m->numa_mem_supported = true;compat_props_add (m->compat_props, hw_compat_5_0, hw_compat_5_0_len);compat_props_add (m->compat_props, pc_compat_5_0, pc_compat_5_0_len); - m->auto_enable_numa_with_memhp = false; + m->auto_enable_numa_with_memdev = false; } DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,Signature · 1 line
2.26.2
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 11 lines · On Thu, 20 Aug 2020 11:48:28 +0200 David Hildenbrand <[email protected]> wrote:
Unfortunately, a typo sneeked in: we want to set
auto_enable_numa_with_memdevto false, notauto_enable_numa_with_memhp.Cc [email protected] # v5.1Fixes 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)Reported-by Dr. David Alan Gilbert <[email protected]>Cc Paolo Bonzini <[email protected]>Cc Richard Henderson <[email protected]>Cc Eduardo Habkost <[email protected]>Cc "Michael S. Tsirkin" <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 17 lines
--- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/i386/pc_q35.c +1
-1@@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m) m->numa_mem_supported = true;compat_props_add (m->compat_props, hw_compat_5_0, hw_compat_5_0_len);compat_props_add (m->compat_props, pc_compat_5_0, pc_compat_5_0_len); - m->auto_enable_numa_with_memhp = false; + m->auto_enable_numa_with_memdev = false; } DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
Quoted 11 lines · David Hildenbrand
Unfortunately, a typo sneeked in: we want to set
auto_enable_numa_with_memdevto false, notauto_enable_numa_with_memhp.Cc [email protected] # v5.1Fixes 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)Reported-by Dr. David Alan Gilbert <[email protected]>Cc Paolo Bonzini <[email protected]>Cc Richard Henderson <[email protected]>Cc Eduardo Habkost <[email protected]>Cc "Michael S. Tsirkin" <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
@MST, do you want to queue this patch? thanks!
Signature · 3 lines
Thanks, David / dhildenb
Michael S. Tsirkin
AppliedQuoted 13 lines · David Hildenbrand
Quoted 11 lines · David Hildenbrand
Unfortunately, a typo sneeked in: we want to set
auto_enable_numa_with_memdevto false, notauto_enable_numa_with_memhp.Cc [email protected] # v5.1Fixes 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible)Reported-by Dr. David Alan Gilbert <[email protected]>Cc Paolo Bonzini <[email protected]>Cc Richard Henderson <[email protected]>Cc Eduardo Habkost <[email protected]>Cc "Michael S. Tsirkin" <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 1 line
@MST, do you want to queue this patch? thanks!
queued, thanks!
Quoted 5 lines
Signature · 4 lines
-- Thanks, David / dhildenb