Skip to contentSkip to conversation

ui: Add more mouse buttons to SPICE

PATCH In review Frediano Ziglio 2 participants 2 messages Aug 20, 2020 – Aug 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ui: Add more mouse buttons to SPICE

From: Frediano Ziglio <[email protected]>

Add support for SIDE and EXTRA buttons.

The constants for buttons in both SPICE and QEMU are defined as
LEFT
MIDDLE
RIGHT
UP
DOWN
SIDE
EXTRA
(same order).

"button_mask" contains for each bit the state of a button. Qemu currently uses bits 0, 1, 2 respectively as LEFT, RIGHT, MIDDLE; also add bits 4 and 5 as UP and DOWN (using wheel movements). SPICE protocol uses a bitmask based on the order above where LEFT is bit 0, MIDDLE is bit 1 and so on till EXTRA being bit 6. To avoid clash with Qemu usage SPICE bitmask from SIDE are move a bit more resulting respectively in 0x40 and 0x80 values.

---
 ui/spice-input.c | 2 ++
 1 file changed, 2 insertions(+)

See also https://gitlab.freedesktop.org/spice/spice/-/merge_requests/140

ui/spice-input.c +2 -0
index cd4bb0043f..d5bba231c9 100644
@@ -123,6 +123,8 @@ static void spice_update_buttons(QemuSpicePointer *pointer,
         [INPUT_BUTTON_RIGHT]       = 0x02,
         [INPUT_BUTTON_WHEEL_UP]    = 0x10,
         [INPUT_BUTTON_WHEEL_DOWN]  = 0x20,
+        [INPUT_BUTTON_SIDE]        = 0x40,
+        [INPUT_BUTTON_EXTRA]       = 0x80,
     };
 
     if (wheel < 0) {
Signature · 1 line
2.25.4
#1 lore raw

ui/spice-input.c static void spice_update_buttons(QemuSpicePointer *pointer, · line 127

Quoted 2 lines
ui/spice-input.c +2 -0
+        [INPUT_BUTTON_SIDE]        = 0x40,
+        [INPUT_BUTTON_EXTRA]       = 0x80,

Added to UI patch queue.

thanks,
Gerd