Skip to contentSkip to conversation

MAINTAINERS: Add entry for HPE Superdome Flex (UV) maintainers

PATCH Superseded Steve Wahl 4 participants 9 messages Aug 21, 2020 – Aug 24, 2020 GET_MAINTAINER script

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Steve Wahl

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Add entry for HPE Superdome Flex (UV) maintainers

---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
index deaafb617361..4c2143d8ae45 100644
@@ -18874,6 +18874,15 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
 F:	arch/x86/platform
 
+X86 PLATFORM UV HPE SUPERDOME FLEX
+M:	Steve Wahl <[email protected]>
+R:	Dimitri Sivanich <[email protected]>
+R:	Russ Anderson <[email protected]>
+S:	Supported
+F:	arch/x86/include/asm/uv/
+F:	arch/x86/kernel/apic/x2apic_uv_x.c
+F:	arch/x86/platform/uv/
+
 X86 VDSO
 M:	Andy Lutomirski <[email protected]>
 L:	[email protected]
Signature · 1 line
2.12.3
#1 lore raw

+Joe Perches

Quoted 3 lines · Steve Wahl

get_maintainers.pl doesn't work on MAINTAINERS. You need to send this to the maintainers of the files listed in the entry below. Looks like that would be the x86 maintainers.

What did Mauro, David and I do to become MAINTAINERS maintainers?

Mauro Carvalho Chehab <[email protected]> (commit_signer:127/806=16%,authored:80/806=10%)
Rob Herring <[email protected]> (commit_signer:103/806=13%) "David S. Miller" <[email protected]> (commit_signer:99/806=12%) [email protected] (open list)

Can we make --no-git-fallback the default? It's useful for informational purposes, but never for who to email patches to. Having no output would be better, then submitters have to think about where to send patches.

What ever happened to splitting up MAINTAINERS to subdirectories? That would help routing MAINTAINERS changes to the right maintainers.

Rob

Quoted 27 lines
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -1
index deaafb617361..4c2143d8ae45 100644
@@ -18874,6 +18874,15 @@ S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
 F:     arch/x86/platform
 
+X86 PLATFORM UV HPE SUPERDOME FLEX
+M:     Steve Wahl <[email protected]>
+R:     Dimitri Sivanich <[email protected]>
+R:     Russ Anderson <[email protected]>
+S:     Supported
+F:     arch/x86/include/asm/uv/
+F:     arch/x86/kernel/apic/x2apic_uv_x.c
+F:     arch/x86/platform/uv/
+
 X86 VDSO
 M:     Andy Lutomirski <[email protected]>
 L:     [email protected]
--

2.12.3

maintainer
#2 lore raw
Quoted 20 lines · Rob Herring

+Joe Perches

Quoted 2 lines · Steve Wahl

get_maintainers.pl doesn't work on MAINTAINERS. You need to send this to the maintainers of the files listed in the entry below. Looks like that would be the x86 maintainers.

What did Mauro, David and I do to become MAINTAINERS maintainers?

Mauro Carvalho Chehab <[email protected]> (commit_signer:127/806=16%,authored:80/806=10%)
Rob Herring <[email protected]> (commit_signer:103/806=13%) "David S. Miller" <[email protected]> (commit_signer:99/806=12%) [email protected] (open list)

Quoted 4 lines

Can we make --no-git-fallback the default? It's useful for informational purposes, but never for who to email patches to. Having no output would be better, then submitters have to think about where to send patches.

Doubtful that improves things. At least the --git-fallback option shows who modified or got patches accepted to files that are nominally unmaintained. It also shows the upstream path for those files via Signed-off-by: lines so I think --git-fallback is generally a good mechanism and control flag for directly unmaintained files.

Quoted 2 lines

What ever happened to splitting up MAINTAINERS to subdirectories? That would help routing MAINTAINERS changes to the right maintainers.

Splitting MAINTAINERS into subdirectories would do nothing to route patches. It would just be convenience to reduce the total number of changes to a single file.

Those large number of changes to the single MAINTAINERS file very rarely have any conflicts either, so it wouldn't really change the overall number of changes to MAINTAINERS entries spread around the tree.

You are be welcome to try to split the file and get Linus to accept it. I gave it a go. Try yourself.

https://lore.kernel.org/patchwork/patch/817857/

maintainer
#5 lore raw

PATCH 1/1 get_maintainer: Exclude MAINTAINERS file(s) from --git-fallback and --git-blame

In reply to Rob Herring

MAINTAINERS files generally have no specific maintainer but are updated by individuals for subsystems all over the source tree.

Exclude MAINTAINERS file(s) from --git-fallback and --git-blame searches so the unlucky individuals that update the files the most are not shown.

---
 scripts/get_maintainer.pl | 1 +
 1 file changed, 1 insertion(+)
scripts/get_maintainer.pl +1 -0
index 484d2fbf5921..4d5196a11329 100755
@@ -953,6 +953,7 @@ sub get_maintainers {
     }
 
     foreach my $file (@files) {
+	next if ($file =~ /MAINTAINERS$/);
 	if ($email &&
 	    ($email_git || ($email_git_fallback &&
 			    !$exact_pattern_match_hash{$file}))) {
maintainer
#6 lore raw

PATCH v2 1/1 get_maintainer: Exclude MAINTAINERS file(s) from --git-fallback

In reply to Rob Herring

MAINTAINERS files generally have no specific maintainer but are updated by individuals for subsystems all over the source tree.

Exclude MAINTAINERS file(s) from --git-fallback searches so the unlucky individuals that update the files the most are not shown by default.

---

V2:

Remove --git and --git-blame from the exclusion. Someone who _really_ wants that info should get it.

 scripts/get_maintainer.pl | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
scripts/get_maintainer.pl +4 -2
index 484d2fbf5921..7ea461dc208e 100755
@@ -954,8 +954,10 @@ sub get_maintainers {
 
     foreach my $file (@files) {
 	if ($email &&
-	    ($email_git || ($email_git_fallback &&
-			    !$exact_pattern_match_hash{$file}))) {
+	    ($email_git ||
+	     ($email_git_fallback &&
+	      $file !~ /MAINTAINERS$/ &&
+	      !$exact_pattern_match_hash{$file}))) {
 	    vcs_file_signoffs($file);
 	}
 	if ($email && $email_git_blame) {
#3 lore raw
In reply to Joe Perches
Quoted 33 lines · Joe Perches
Quoted 20 lines · Rob Herring

+Joe Perches

Quoted 2 lines · Steve Wahl

get_maintainers.pl doesn't work on MAINTAINERS. You need to send this to the maintainers of the files listed in the entry below. Looks like that would be the x86 maintainers.

What did Mauro, David and I do to become MAINTAINERS maintainers?

Mauro Carvalho Chehab <[email protected]> (commit_signer:127/806=16%,authored:80/806=10%)
Rob Herring <[email protected]> (commit_signer:103/806=13%) "David S. Miller" <[email protected]> (commit_signer:99/806=12%) [email protected] (open list)

Quoted 4 lines

Can we make --no-git-fallback the default? It's useful for informational purposes, but never for who to email patches to. Having no output would be better, then submitters have to think about where to send patches.

Doubtful that improves things. At least the --git-fallback option shows who modified or got patches accepted to files that are nominally unmaintained. It also shows the upstream path for those files via Signed-off-by: lines so I think --git-fallback is generally a good mechanism and control flag for directly unmaintained files.

Quoted 6 lines
Quoted 2 lines

What ever happened to splitting up MAINTAINERS to subdirectories? That would help routing MAINTAINERS changes to the right maintainers.

Splitting MAINTAINERS into subdirectories would do nothing to route patches. It would just be convenience to reduce the total number of changes to a single file.

In general no, but for MAINTAINERS changes it would. Let's say I add an entry for Documentation/devicetree/foo-bar.txt. With a per subsystem/path MAINTAINERS file in Documentation/devicetree/MAINTAINERS, you'd add an entry there and run get_maintainer.pl:

$ touch Documentation/devicetree/MAINTAINERS
$ scripts/get_maintainer.pl -f Documentation/devicetree/MAINTAINERS
Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS)
[email protected] (open list)
Quoted 9 lines

Those large number of changes to the single MAINTAINERS file very rarely have any conflicts either, so it wouldn't really change the overall number of changes to MAINTAINERS entries spread around the tree.

You are be welcome to try to split the file and get Linus to accept it. I gave it a go. Try yourself.

https://lore.kernel.org/patchwork/patch/817857/

Yes, I remember that. He didn't seem totally opposed to it which is why I asked.

I have another reason for wanting the split. I want to generate a MAINTAINERS file from the DT schema files. We have the data there and it's checked automatically. I don't care to either continually tell folks to add a MAINTAINERS entry or tell them to run checkpatch.pl to tell them that. But if the infrastructure got merged, would that already work?

Rob

maintainer
#4 lore raw
Quoted 6 lines · Rob Herring

I have another reason for wanting the split. I want to generate a MAINTAINERS file from the DT schema files. We have the data there and it's checked automatically. I don't care to either continually tell folks to add a MAINTAINERS entry or tell them to run checkpatch.pl to tell them that. But if the infrastructure got merged, would that already work?

It already gets addresses from yaml files.
The same could be done for dts/dtsi files.

Last month I proposed:

https://lore.kernel.org/linux-arm-kernel/[email protected]/

author
#7 lore raw
In reply to Steve Wahl

Added Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar, Borislav Petkov, and x86.kernel.org, after being told that get_maintainers.pl doesn't work on MAINTAINERS.

Thanks,

Steve Wahl, HPE

Quoted 29 lines · Steve Wahl
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
index deaafb617361..4c2143d8ae45 100644
@@ -18874,6 +18874,15 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
 F:	arch/x86/platform
 
+X86 PLATFORM UV HPE SUPERDOME FLEX
+M:	Steve Wahl <[email protected]>
+R:	Dimitri Sivanich <[email protected]>
+R:	Russ Anderson <[email protected]>
+S:	Supported
+F:	arch/x86/include/asm/uv/
+F:	arch/x86/kernel/apic/x2apic_uv_x.c
+F:	arch/x86/platform/uv/
+
 X86 VDSO
 M:	Andy Lutomirski <[email protected]>
 L:	[email protected]
Signature · 1 line
2.12.3
#8 lore raw
Quoted 9 lines · Steve Wahl

Added Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar, Borislav Petkov, and x86.kernel.org, after being told that get_maintainers.pl doesn't work on MAINTAINERS.

Thanks,

Steve Wahl, HPE

On Fri, Aug 21, 2020 at 10:48:49AM -0500, Steve Wahl wrote:

I could use a sentence here as a commit message, even if it repeats the subject line.

Quoted 13 lines
Quoted 13 lines
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +0 -0
index deaafb617361..4c2143d8ae45 100644
@@ -18874,6 +18874,15 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
 F:	arch/x86/platform
 
Quoted 13 lines

MAINTAINERS S: Maintained · line 18888

Quoted 13 lines
MAINTAINERS +9 -0
+X86 PLATFORM UV HPE SUPERDOME FLEX
+M:	Steve Wahl <[email protected]>
+R:	Dimitri Sivanich <[email protected]>
+R:	Russ Anderson <[email protected]>
+S:	Supported
+F:	arch/x86/include/asm/uv/
+F:	arch/x86/kernel/apic/x2apic_uv_x.c
+F:	arch/x86/platform/uv/
+
 X86 VDSO
 M:	Andy Lutomirski <[email protected]>
 L:	[email protected]

Looks ok to me, otherwise.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette