Skip to contentSkip to conversation

arm64: dts: imx8mm-evk: Replace deprecated phy reset properties

PATCH Applied Krzysztof Kozlowski 2 participants 6 messages Aug 23, 2020 – Aug 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 arm64: dts: imx8mm-evk: Replace deprecated phy reset properties

Use preferred properties of phy node instead of deprecated phy-reset-gpios (and others). This avoids copying deprecated code into future DTSes.

---

Not tested on HW.

---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +2 -2
index 19a22d0d0730..c1f7d44651df 100644
@@ -119,8 +119,6 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
-	phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <10>;
 	fsl,magic-packet;
 	status = "okay";
 
@@ -131,6 +129,8 @@
 		ethphy0: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0>;
+			reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
 		};
 	};
 };
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/5 arm64: dts: imx8mq-evk: Replace deprecated phy reset properties

Use preferred properties of phy node instead of deprecated phy-reset-gpios (and others). This avoids copying deprecated code into future DTSes.

---

Not tested on HW.

---
 arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq-evk.dts +2 -2
index c9241abf0df3..8aa9cd8e495a 100644
@@ -137,8 +137,6 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
-	phy-reset-gpios = <&gpio1 9  GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <10>;
 	fsl,magic-packet;
 	status = "okay";
 
@@ -149,6 +147,8 @@
 		ethphy0: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0>;
+			reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
 		};
 	};
 };
Signature · 1 line
2.17.1
#2 lore raw

PATCH 3/5 arm64: dts: imx8mq-phanbell: Replace deprecated phy reset properties

In reply to Krzysztof Kozlowski

Use preferred properties of phy node instead of deprecated phy-reset-gpios (and others). This avoids copying deprecated code into future DTSes.

---

Not tested on HW.

---
 arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts +3 -3
index 77ab568fae67..3f541ddf0768 100644
@@ -262,9 +262,6 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
-	phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <10>;
-	phy-reset-post-delay = <50>;
 	phy-handle = <&ethphy0>;
 	fsl,magic-packet;
 	status = "okay";
@@ -275,6 +272,9 @@
 		ethphy0: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0>;
+			reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
+			reset-deassert-us = <50000>;
 		};
 	};
 };
Signature · 1 line
2.17.1
#3 lore raw

PATCH 4/5 arm64: dts: imx8mq-sr-som: Replace deprecated phy reset properties

In reply to Krzysztof Kozlowski

Use preferred properties of phy node instead of deprecated phy-reset-gpios (and others). This avoids copying deprecated code into future DTSes.

---

Not tested on HW.

---
 arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi +2 -2
index 602c870a7ccb..404c46671b96 100644
@@ -20,8 +20,6 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
-	phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
-	phy-reset-duration = <2>;
 	fsl,magic-packet;
 	status = "okay";
 
@@ -32,6 +30,8 @@
 		ethphy0: ethernet-phy@4 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <4>;
+			reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <2000>;
 		};
 	};
 };
Signature · 1 line
2.17.1
#4 lore raw

PATCH 5/5 arm64: dts: imx8mq-thor96: Replace deprecated phy reset properties

In reply to Krzysztof Kozlowski

Use preferred properties of phy node instead of deprecated phy-reset-gpios (and others). This avoids copying deprecated code into future DTSes.

---

Not tested on HW.

---
 arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-thor96.dts +1 -1
index b4795a032fa2..5d5aa6537225 100644
@@ -122,7 +122,6 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
 	phy-mode = "rgmii-id";
-	phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
 	phy-handle = <&ethphy>;
 	fsl,magic-packet;
 	status = "okay";
@@ -134,6 +133,7 @@
 		ethphy: ethernet-phy@3 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <3>;
+			reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
 		};
 	};
 };
Signature · 1 line
2.17.1