meson: Add option to not build the assembler
PATCH 1/1 meson: Add option to not build the assembler
New option -Dassembler=disabled will omit assembler/ from the build.
--- meson.build | 4 +++- meson_options.txt | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)
meson.build +3 -1
@@ -82,6 +82,7 @@ endforeach build_chamelium = get_option('chamelium') build_docs = get_option('docs') build_tests = not get_option('tests').disabled() +build_assembler = get_option('assembler') with_libdrm = get_option('libdrm_drivers') build_info = ['Build type: ' + get_option('buildtype')]
@@ -306,9 +307,10 @@ build_info += 'Build tests: @0@'.format(build_tests) subdir('benchmarks') subdir('tools') subdir('runner') -if libdrm_intel.found() +if libdrm_intel.found() and build_assembler.enabled() subdir('assembler') endif +build_info += 'Build shader assembler: @0@'.format(build_assembler.enabled()) subdir('overlay') subdir('man')
meson_options.txt +4 -0
@@ -42,6 +42,10 @@ option('runner', type : 'feature', description : 'Build test runner') +option('assembler', + type : 'feature', + description : 'Build shader assembler') + option('oping', type : 'feature', description : 'Build test runner with liboping for pinging support')
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for meson: Add option to not build the assembler
== Series Details ==
== Series Details ==
Series: meson: Add option to not build the assembler
URL : https://patchwork.freedesktop.org/series/80934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8918 -> IGTPW_4903
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
Known issues
------------
Here are the changes found in IGTPW_4903 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][1] -> [DMESG-WARN][2] ([i915#62] / [i915#92] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-x1275/igt@kms_busy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([i915#2203])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-7500u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-bsw-kefka/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-bsw-kefka/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-byt-j1900/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-byt-j1900/igt@[email protected]
- fi-bsw-n3050: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-bsw-n3050/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-bsw-n3050/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][11] ([i915#2276]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-icl-y/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-icl-y/igt@i915_selftest@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][13] ([i915#2203]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-skl-guc/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-skl-guc/igt@kms_flip@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][17] ([i915#62] / [i915#95]) -> [DMESG-FAIL][18] ([i915#62])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-x1275/igt@[email protected]
- fi-kbl-guc: [DMESG-WARN][19] ([i915#2203]) -> [DMESG-FAIL][20] ([i915#2203])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-guc/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-guc/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#62] / [i915#92])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/fi-kbl-x1275/igt@[email protected]
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (37 -> 34)
------------------------------
Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5770 -> IGTPW_4903
CI-20190529: 20190529
CI_DRM_8918: 7296072da95d2d2550ef2d4836bc72663ee711cc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4903: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
IGT_5770: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for meson: Add option to not build the assembler
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: meson: Add option to not build the assembler
URL : https://patchwork.freedesktop.org/series/80934/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8918_full -> IGTPW_4903_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4903_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_4903_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4903_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_4903_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk6/igt@[email protected]
* igt@gem_reg_read@timestamp-moving:
- shard-snb: [PASS][5] -> [TIMEOUT][6] ([i915#1958]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][7] -> [WARN][8] ([i915#1519])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_atomic_interruptible@universal-setplane-cursor:
- shard-hsw: [PASS][9] -> [TIMEOUT][10] ([i915#1958]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-iclb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-iclb7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-iclb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#49])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk8/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb8/igt@[email protected]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-c-wait-forked-busy:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#1635] / [i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl6/igt@[email protected]
* igt@prime_busy@after@vecs0:
- shard-hsw: [PASS][27] -> [FAIL][28] ([i915#2258]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@prime_busy@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@prime_busy@[email protected]
#### Possible fixes ####
* igt@gem_exec_create@forked:
- shard-glk: [DMESG-WARN][29] ([i915#118] / [i915#95]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk1/igt@[email protected]
* igt@gem_flink_basic@basic:
- shard-snb: [TIMEOUT][31] ([i915#1958]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [INCOMPLETE][33] ([i915#151] / [i915#155]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-kbl: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-kbl: [FAIL][37] ([i915#54]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][39] ([i915#1635] / [i915#54]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-hsw: [TIMEOUT][41] ([i915#1958]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw8/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][43] ([i915#2055]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw4/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-apl: [DMESG-WARN][45] ([i915#1635] / [i915#1982]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: [SKIP][49] ([i915#1911]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb3/igt@kms_psr2_su@page_flip.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb3/igt@kms_psr2_su@page_flip.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@prime_busy@before@vecs0:
- shard-hsw: [FAIL][53] ([i915#2258]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw1/igt@prime_busy@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw7/igt@prime_busy@[email protected]
#### Warnings ####
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-snb: [TIMEOUT][55] ([i915#1958]) -> [SKIP][56] ([fdo#109271]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
- shard-glk: [INCOMPLETE][57] -> [SKIP][58] ([fdo#109271])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-hsw: [SKIP][59] ([fdo#109271]) -> [TIMEOUT][60] ([i915#1958]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_psr@suspend:
- shard-snb: [SKIP][61] ([fdo#109271]) -> [TIMEOUT][62] ([i915#1958]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@kms_vblank@pipe-d-accuracy-idle:
- shard-hsw: [TIMEOUT][63] ([i915#1958]) -> [SKIP][64] ([fdo#109271])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw7/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5770 -> IGTPW_4903
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8918: 7296072da95d2d2550ef2d4836bc72663ee711cc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4903: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
IGT_5770: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] ✗ Fi.CI.IGT: failure for meson: Add option to not build the assembler
Quoted 30 lines · Patchwork
== Series Details ==
Series: meson: Add option to not build the assembler
URL : https://patchwork.freedesktop.org/series/80934/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_8918_full->IGTPW_4903_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
IGTPW_4903_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
IGTPW_4903_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
Possible new issues
-------------------Here are the unknown changes that may have been introduced in
IGTPW_4903_full:
Quoted 8 lines
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@[email protected]
Lakshmi, false failure here.
Signature · 5 lines
Petri Latvala _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] ✗ Fi.CI.IGT: failure for meson: Add option to not build the assembler
Re-reported.
-----Original Message-----
From: Latvala, Petri <[email protected]>
Sent: Monday, August 24, 2020 5:22 AM
To: [email protected]; Vudum, Lakshminarayana <[email protected]>
Subject: Re: ✗ Fi.CI.IGT: failure for meson: Add option to not build the assembler
Quoted 33 lines · Patchwork
== Series Details ==
Series: meson: Add option to not build the assembler
URL : https://patchwork.freedesktop.org/series/80934/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_8918_full->IGTPW_4903_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
IGTPW_4903_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
IGTPW_4903_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.htmlPossible new issues
-------------------Here are the unknown changes that may have been introduced in
IGTPW_4903_full:### IGT changes ###
Quoted 8 lines
#### Possible regressions ####
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@kms
[email protected]
Lakshmi, false failure here.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for meson: Add option to not build the assembler
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: meson: Add option to not build the assembler
URL : https://patchwork.freedesktop.org/series/80934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8918_full -> IGTPW_4903_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
Known issues
------------
Here are the changes found in IGTPW_4903_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk6/igt@[email protected]
* igt@gem_reg_read@timestamp-moving:
- shard-snb: [PASS][3] -> [TIMEOUT][4] ([i915#1958]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][5] -> [WARN][6] ([i915#1519])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_atomic_interruptible@universal-setplane-cursor:
- shard-hsw: [PASS][7] -> [TIMEOUT][8] ([i915#1958]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-iclb: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-iclb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-iclb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl4/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#2370])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#49])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk8/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb8/igt@[email protected]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-c-wait-forked-busy:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#1635] / [i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl6/igt@[email protected]
* igt@prime_busy@after@vecs0:
- shard-hsw: [PASS][27] -> [FAIL][28] ([i915#2258]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw7/igt@prime_busy@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw1/igt@prime_busy@[email protected]
#### Possible fixes ####
* igt@gem_exec_create@forked:
- shard-glk: [DMESG-WARN][29] ([i915#118] / [i915#95]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk1/igt@[email protected]
* igt@gem_flink_basic@basic:
- shard-snb: [TIMEOUT][31] ([i915#1958]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [INCOMPLETE][33] ([i915#151] / [i915#155]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-kbl: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-kbl: [FAIL][37] ([i915#54]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][39] ([i915#1635] / [i915#54]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-hsw: [TIMEOUT][41] ([i915#1958]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw8/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][43] ([i915#2055]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw4/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-apl: [DMESG-WARN][45] ([i915#1635] / [i915#1982]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: [SKIP][49] ([i915#1911]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-tglb3/igt@kms_psr2_su@page_flip.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-tglb3/igt@kms_psr2_su@page_flip.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-kbl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-kbl2/igt@[email protected]
* igt@prime_busy@before@vecs0:
- shard-hsw: [FAIL][53] ([i915#2258]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw1/igt@prime_busy@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw7/igt@prime_busy@[email protected]
#### Warnings ####
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-snb: [TIMEOUT][55] ([i915#1958]) -> [SKIP][56] ([fdo#109271]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
- shard-glk: [INCOMPLETE][57] -> [SKIP][58] ([fdo#109271])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-glk2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-glk7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-hsw: [SKIP][59] ([fdo#109271]) -> [TIMEOUT][60] ([i915#1958]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw4/igt@[email protected]
* igt@kms_psr@suspend:
- shard-snb: [SKIP][61] ([fdo#109271]) -> [TIMEOUT][62] ([i915#1958]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-snb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-snb4/igt@[email protected]
* igt@kms_vblank@pipe-d-accuracy-idle:
- shard-hsw: [TIMEOUT][63] ([i915#1958]) -> [SKIP][64] ([fdo#109271])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8918/shard-hsw8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/shard-hsw7/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5770 -> IGTPW_4903
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8918: 7296072da95d2d2550ef2d4836bc72663ee711cc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4903: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
IGT_5770: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4903/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 24 lines · Petri Latvala
New option -Dassembler=disabled will omit assembler/ from the build.
Signed-off-by Petri Latvala <[email protected]>Cc Kalyan Kondapally <[email protected]>Cc Arkadiusz Hiler <[email protected]>Cc Lukasz Fiedorowicz <[email protected]>--- meson.build | 4 +++- meson_options.txt | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)meson.build +1
-0@@ -82,6 +82,7 @@ endforeach build_chamelium = get_option('chamelium') build_docs = get_option('docs') build_tests = not get_option('tests').disabled() +build_assembler = get_option('assembler') with_libdrm = get_option('libdrm_drivers') build_info = ['Build type: ' + get_option('buildtype')]
meson.build build_info += 'Build tests: @0@'.format(build_tests) · line 313
Quoted 8 lines
meson.build +2
-1@@ -306,9 +307,10 @@ build_info += 'Build tests: @0@'.format(build_tests) subdir('benchmarks') subdir('tools') subdir('runner') -if libdrm_intel.found() +if libdrm_intel.found() and build_assembler.enabled() subdir('assembler') endif +build_info += 'Build shader assembler: @0@'.format(build_assembler.enabled())
Are you sure this is going to do what you think it's going to do?
My understanding is that .enabled() on feature option object[0] evaluates to true only if you explicityly set the option to 'enabled'.
Features default to auto unless changed with 'auto_features', and we don't do that.
$ meson build ... Message: Build shader assembler: false
vs
$ meson -Dassembler=enabled build Message: Build shader assembler: true
This means we won't build assembler unless -Dassember=enabled, which doesn't match with the commit message.
Also, drop a note in the NEWS - it may make some package maintainers a bit happier :-)
[0]: https://mesonbuild.com/Reference-manual.html#feature-option-object
Signature · 6 lines
Cheers, Arek _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 23 lines · Arkadiusz Hiler
Quoted 22 lines · Petri Latvala
New option -Dassembler=disabled will omit assembler/ from the build.
Signed-off-by Petri Latvala <[email protected]>Cc Kalyan Kondapally <[email protected]>Cc Arkadiusz Hiler <[email protected]>Cc Lukasz Fiedorowicz <[email protected]>--- meson.build | 4 +++- meson_options.txt | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)meson.build +1
-0@@ -82,6 +82,7 @@ endforeach build_chamelium = get_option('chamelium') build_docs = get_option('docs') build_tests = not get_option('tests').disabled() +build_assembler = get_option('assembler') with_libdrm = get_option('libdrm_drivers')
Quoted 12 lines
meson.build build_info += 'Build tests: @0@'.format(build_tests) · line 313
Quoted 10 lines
meson.build +2
-1build_info = ['Build type: ' + get_option('buildtype')]@@ -306,9 +307,10 @@ build_info += 'Build tests: @0@'.format(build_tests) subdir('benchmarks') subdir('tools') subdir('runner') -if libdrm_intel.found() +if libdrm_intel.found() and build_assembler.enabled() subdir('assembler') endif +build_info += 'Build shader assembler: @0@'.format(build_assembler.enabled())Are you sure this is going to do what you think it's going to do?
Sure? Absolutely not!
Quoted 10 lines
My understanding is that .enabled() on feature option object[0] evaluates to true only if you explicityly set the option to 'enabled'.
Features default to auto unless changed with '
auto_features', and we don't do that.$ meson build ... Message: Build shader assembler: false
Quoted 7 lines
vs
$ meson -Dassembler=enabled build Message: Build shader assembler: trueThis means we won't build assembler unless -Dassember=enabled, which doesn't match with the commit message.
Well that explains why build_tests uses "not foo.disabled()"
Signature · 5 lines
Petri Latvala _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev