crypto/chtls: Fix double free in chtls_pass_accept_request()

PATCH New Dan Carpenter 1 participant 1 message Aug 24, 2020

Subsystems (3)

Kernel janitors Crypto API CXGB4 crypto driver (chcr)

lore

Share & tools

lore

Dan Carpenter

author

2020-08-24 08:59 UTC #0 lore raw

PATCH 1/1 crypto/chtls: Fix double free in chtls_pass_accept_request()

The chtls_recv_sock() function frees "oreq" so the free here is a double free.

Fixes 6abde0b24122 ("crypto/chtls: IPv6 support for inline TLS")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/crypto/chelsio/chtls/chtls_cm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/crypto/chelsio/chtls/chtls_cm.c +1 -3

index 05520dccd906..140342024bd1 100644
@@ -1381,7 +1381,7 @@ static void chtls_pass_accept_request(struct sock *sk,
 
 	newsk = chtls_recv_sock(sk, oreq, network_hdr, req, cdev);
 	if (!newsk)
-		goto free_oreq;
+		goto reject;
 
 	if (chtls_get_module(newsk))
 		goto reject;

@@ -1397,8 +1397,6 @@ static void chtls_pass_accept_request(struct sock *sk,
 	kfree_skb(skb);
 	return;
 
-free_oreq:
-	chtls_reqsk_free(oreq);
 reject:
 	mk_tid_release(reply_skb, 0, tid);
 	cxgb4_ofld_send(cdev->lldi->ports[0], reply_skb);

Signature · 1 line

2.28.0