Skip to contentSkip to conversation

scsi: libcxgbi: Fix a use after free in cxgbi_conn_xmit_pdu()

PATCH New Dan Carpenter 1 participant 1 message Aug 24, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: libcxgbi: Fix a use after free in cxgbi_conn_xmit_pdu()

We accidentally move this logging printk after the free, but that leads to a use after free.

Fixes e33c2482289b ("scsi: cxgb4i: Add support for iSCSI segmentation offload")
---
 drivers/scsi/cxgbi/libcxgbi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/cxgbi/libcxgbi.c +1 -1
index 71aebaf533ea..0e8621a6956d 100644
@@ -2457,10 +2457,10 @@ int cxgbi_conn_xmit_pdu(struct iscsi_task *task)
 		return err;
 	}
 
-	__kfree_skb(skb);
 	log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
 		  "itt 0x%x, skb 0x%p, len %u/%u, xmit err %d.\n",
 		  task->itt, skb, skb->len, skb->data_len, err);
+	__kfree_skb(skb);
 	iscsi_conn_printk(KERN_ERR, task->conn, "xmit err %d.\n", err);
 	iscsi_conn_failure(task->conn, ISCSI_ERR_XMIT_FAILED);
 	return err;
Signature · 1 line
2.28.0