crypto: arm/curve25519 - include <linux/scatterlist.h>
Subsystems (2)
PATCH 1/1 crypto: arm/curve25519 - include <linux/scatterlist.h>
Building ARM allmodconfig leads to the following warnings:
arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration] arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration] arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
Include <linux/scatterlist.h> to fix such warnings
--- arch/arm/crypto/curve25519-glue.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/crypto/curve25519-glue.c +1 -0
@@ -16,6 +16,7 @@#include <linux/module.h> #include <linux/init.h> #include <linux/jump_label.h> +#include <linux/scatterlist.h> #include <crypto/curve25519.h> asmlinkage void curve25519_neon(u8 mypublic[CURVE25519_KEY_SIZE],
Signature · 1 line
2.17.1
Quoted 11 lines · Fabio Estevam
Building ARM allmodconfig leads to the following warnings:
arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]Include <
linux/scatterlist.h> to fix such warningsReported-by Olof's autobuilder <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Thanks for the fix - I just hit this as well.
Quoted 19 lines
--- arch/arm/crypto/curve25519-glue.c | 1 + 1 file changed, 1 insertion(+)arch/arm/crypto/curve25519-glue.c +1
-1@@ -16,6 +16,7 @@#include <linux/module.h> #include <linux/init.h> #include <linux/jump_label.h> +#include <linux/scatterlist.h> #include <crypto/curve25519.h> asmlinkage void curve25519_neon(u8 mypublic[CURVE25519_KEY_SIZE], --2.17.1
Quoted 8 lines · Fabio Estevam
Building ARM allmodconfig leads to the following warnings:
arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]Include <
linux/scatterlist.h> to fix such warnings
This patch seems correct to me -- sg_copy_to_buffer, sg_nents_for_len. I wonder what header dependency chain caused us to miss this before. Either way,
Herbert Xu
maintainerQuoted 6 lines · Fabio Estevam
Building ARM allmodconfig leads to the following warnings:
arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration]arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration]
Quoted 7 lines
Include <
linux/scatterlist.h> to fix such warningsReported-by Olof's autobuilder <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/crypto/curve25519-glue.c | 1 + 1 file changed, 1 insertion(+)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt