ALSA: ca0106: fix error code handling
PATCH 1/1 ALSA: ca0106: fix error code handling
snd_ca0106_spi_write() returns 1 on error, snd_ca0106_pcm_power_dac() is returning the error code directly, and the caller is expecting an negative error code
Signed-off-by Tong Zhang <[email protected]>
--- sound/pci/ca0106/ca0106_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
sound/pci/ca0106/ca0106_main.c +2 -1
@@ -537,7 +537,8 @@ static int snd_ca0106_pcm_power_dac(struct snd_ca0106 *chip, int channel_id,else /* Power down */ chip->spi_dac_reg[reg] |= bit; -return snd_ca0106_spi_write (chip, chip->spi_dac_reg[reg]); +if (snd_ca0106_spi_write (chip, chip->spi_dac_reg[reg]) !=0 ) +return -ENXIO ; }return 0 ; }
Signature · 1 line
2.25.1
Takashi Iwai
AppliedQuoted 6 lines · Tong Zhang
snd_ca0106_spi_write()returns 1 on error,snd_ca0106_pcm_power_dac()is returning the error code directly, and the caller is expecting an negative error codeSigned-off-by Tong Zhang <[email protected]>
Thanks, applied with Cc to stable.
Takashi