perf: Stream comparison
v4 cover perf: Stream comparison
Sometimes, a small change in a hot function reducing the cycles of this function, but the overall workload doesn't get faster. It is interesting where the cycles are moved to.
What it would like is to diff before/after streams. The stream is the branch history which is aggregated by the branch records from perf samples. For example, the callchains aggregated from the branch records. By browsing the hot stream, we can understand the hot code path.
By browsing the hot streams, we can understand the hot code path. By comparing the cycles variation of same streams between old perf data and new perf data, we can understand if the cycles are moved to other codes.
The before stream is the stream in perf.data.old. The after stream is the stream in perf.data.
Diffing before/after streams compares top N hottest streams between two perf data files.
If all entries of one stream in perf.data.old are fully matched with all entries of another stream in perf.data, we think two streams are matched, otherwise the streams are not matched.
For example,
cycles: 1, hits: 26.80% cycles: 1, hits: 27.30%
-------------------------- --------------------------
main div.c:39 main div.c:39
main div.c:44 main div.c:44
The above streams are matched and we can see for the same streams the cycles (1) are equal and the callchain hit percents are slightly changed (26.80% vs. 27.30%). That's expected.
Now let's see examples.
perf record -b ... Generate perf.data.old with branch data
perf record -b ... Generate perf.data with branch data
perf diff --stream
[ Matched hot streams ]
hot chain pair 1:
cycles: 1, hits: 27.77% cycles: 1, hits: 9.24%
--------------------------- --------------------------
main div.c:39 main div.c:39
main div.c:44 main div.c:44
hot chain pair 2:
cycles: 34, hits: 20.06% cycles: 27, hits: 16.98%
--------------------------- --------------------------
__random_r random_r.c:360 __random_r random_r.c:360
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:380 __random_r random_r.c:380
__random_r random_r.c:357 __random_r random_r.c:357
__random random.c:293 __random random.c:293
__random random.c:293 __random random.c:293
__random random.c:291 __random random.c:291
__random random.c:291 __random random.c:291
__random random.c:291 __random random.c:291
__random random.c:288 __random random.c:288
rand rand.c:27 rand rand.c:27
rand rand.c:26 rand rand.c:26
rand@plt rand@plt
rand@plt rand@plt
compute_flag div.c:25 compute_flag div.c:25
compute_flag div.c:22 compute_flag div.c:22
main div.c:40 main div.c:40
main div.c:40 main div.c:40
main div.c:39 main div.c:39
hot chain pair 3:
cycles: 9, hits: 4.48% cycles: 6, hits: 4.51%
--------------------------- --------------------------
__random_r random_r.c:360 __random_r random_r.c:360
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:380 __random_r random_r.c:380[ Hot streams in old perf data only ]
hot chain 1:
cycles: 18, hits: 6.75%
--------------------------
__random_r random_r.c:360
__random_r random_r.c:388
__random_r random_r.c:388
__random_r random_r.c:380
__random_r random_r.c:357
__random random.c:293
__random random.c:293
__random random.c:291
__random random.c:291
__random random.c:291
__random random.c:288
rand rand.c:27
rand rand.c:26
rand@plt
rand@plt
compute_flag div.c:25
compute_flag div.c:22
main div.c:40hot chain 2:
cycles: 29, hits: 2.78%
--------------------------
compute_flag div.c:22
main div.c:40
main div.c:40
main div.c:39[ Hot streams in new perf data only ]
hot chain 1:
cycles: 4, hits: 4.54%
--------------------------
main div.c:42
compute_flag div.c:28hot chain 2:
cycles: 5, hits: 3.51%
--------------------------
main div.c:39
main div.c:44
main div.c:42
compute_flag div.c:28 v4:
---
The previous version is too big and very hard for review.
1. v4 removes the code which supports the source line mapping table and remove the source line based comparison. Now we only supports the basic functionality of stream comparison.
2. Refactor the code in a generic way.
v3:
---
v2 has 14 patches, it's hard to review. v3 is only 7 patches for basic stream comparison.
Jin Yao (7):
perf util: Create streams
perf util: Get the evsel_streams by evsel_idx perf util: Compare two streams
perf util: Link stream pair
perf util: Calculate the sum of total streams hits perf util: Report hot streams
perf diff: Support hot streams comparison
tools/perf/Documentation/perf-diff.txt | 4 + tools/perf/builtin-diff.c | 133 +++++++++- tools/perf/util/Build | 1 + tools/perf/util/callchain.c | 99 +++++++ tools/perf/util/callchain.h | 9 + tools/perf/util/stream.c | 343 +++++++++++++++++++++++++ tools/perf/util/stream.h | 42 +++ 7 files changed, 618 insertions(+), 13 deletions(-) create mode 100644 tools/perf/util/stream.c create mode 100644 tools/perf/util/stream.h
Signature · 1 line
2.17.1
PATCH v4 1/7 perf util: Create streams
We define the stream is the branch history which is aggregated by the branch records from perf samples. For example, the callchains aggregated from the branch records are considered as streams. By browsing the hot stream, we can understand the hot code path.
Now we only support the callchain for stream. For measuring the hot level for a stream, we use the callchain_node->hit, higher is hotter.
There may be many callchains sampled so we only focus on the top N hottest callchains. N is a user defined parameter or predefined default value (nr_streams_max).
This patch creates an evsel_streams array per event, and saves the top N hottest streams in a stream array.
So now we can get the per-event top N hottest streams.
---
v4:
- Refactor the code
- Rename patch name from 'perf util: Create streams for managing top N hottest callchains' to 'perf util: Create streams'
v2:
- Use zfree in free_evsel_streams().
tools/perf/util/Build | 1 + tools/perf/util/stream.c | 152 +++++++++++++++++++++++++++++++++++++++ tools/perf/util/stream.h | 30 ++++++++ 3 files changed, 183 insertions(+) create mode 100644 tools/perf/util/stream.c create mode 100644 tools/perf/util/stream.h
tools/perf/util/Build +1 -0
@@ -101,6 +101,7 @@ perf-y += call-path.o perf-y += rwsem.o perf-y += thread-stack.o perf-y += spark.o +perf-y += stream.o perf-$(CONFIG_AUXTRACE) += auxtrace.o perf-$(CONFIG_AUXTRACE) += intel-pt-decoder/ perf-$(CONFIG_AUXTRACE) += intel-pt.o
tools/perf/util/stream.c new file +152 -0
152 lines not on this page · raw message
tools/perf/util/stream.h new file +30 -0
@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_STREAM_H +#define __PERF_STREAM_H + +#include "callchain.h" + +enum stream_type { +STREAM_NONE =0 , +STREAM_CALLCHAIN +}; + +struct stream { +struct callchain_node *cnode; +}; + +struct evsel_streams { +struct stream *streams; +enum stream_type stream_type; +int nr_streams_max; +int nr_streams; +int evsel_idx; +}; + +struct evlist ; + +struct evsel_streams *perf_evlist__create_streams (struct evlist *evlist, +int nr_streams_max, +enum stream_type type); + +#endif /* __PERF_STREAM_H */
Signature · 1 line
2.17.1
PATCH v4 3/7 perf util: Compare two streams
In reply to Jin YaoStream is the branch history which is aggregated by the branch records from perf samples. Now we only support the callchain as stream.
If the callchain entries of one stream are fully matched with the callchain entries of another stream, we think two streams are matched.
For example,
cycles: 1, hits: 26.80% cycles: 1, hits: 27.30%
----------------------- -----------------------
main div.c:39 main div.c:39
main div.c:44 main div.c:44
Above two streams are matched (we don't consider the case that source code is changed).
The matching logic is, compare the chain string first. If it's not matched, fallback to dso address comparison.
---
v4:
- Remove original source line comparison code.
tools/perf/util/callchain.c | 54 +++++++++++++++++++++++++++++++++++++ tools/perf/util/callchain.h | 4 +++ 2 files changed, 58 insertions(+)
tools/perf/util/callchain.c +54 -0
@@ -1613,3 +1613,57 @@ void callchain_param_setup(u64 sample_type) callchain_param.record_mode =CALLCHAIN_FP ; } } + +static bool chain_match (struct callchain_list *base_chain, +struct callchain_list *pair_chain) +{ +enum match_result match; + + match =match_chain_strings (base_chain->srcline, + pair_chain->srcline); +if (match !=MATCH_ERROR ) +return match ==MATCH_EQ ; + + match =match_chain_dso_addresses (base_chain->ms.map, + base_chain->ip, + pair_chain->ms.map, + pair_chain->ip); + +return match ==MATCH_EQ ; +} + +bool callchain_cnode_matched (struct callchain_node *base_cnode, +struct callchain_node *pair_cnode) +{ +struct callchain_list *base_chain, *pair_chain; +bool match = false; + + pair_chain =list_first_entry (&pair_cnode->val, + struct callchain_list, + list); + +list_for_each_entry (base_chain, &base_cnode->val, list) { +if (&pair_chain->list == &pair_cnode->val) +return false; + +if (!base_chain->srcline || !pair_chain->srcline) { + pair_chain =list_next_entry (pair_chain, list); +continue ; + } + + match =chain_match (base_chain, pair_chain); +if (!match) +return false; + + pair_chain =list_next_entry (pair_chain, list); + } + +/* +* Say chain1 is ABC, chain2 is ABCD, we consider they are +* not fully matched. +*/ +if (pair_chain && (&pair_chain->list != &pair_cnode->val)) +return false; + +return match; +}
tools/perf/util/callchain.h +4 -0
@@ -298,4 +298,8 @@ int callchain_branch_counts(struct callchain_root *root, u64 *abort_count, u64 *cycles_count);void callchain_param_setup (u64 sample_type); + +bool callchain_cnode_matched (struct callchain_node *base_cnode, +struct callchain_node *pair_cnode); +#endif /* __PERF_CALLCHAIN_H */
Signature · 1 line
2.17.1
PATCH v4 2/7 perf util: Get the evsel_streams by evsel_idx
In reply to Jin YaoIn previous patch, we have created evsel_streams array
This patch returns the specified evsel_streams according to the evsel_idx.
---
v4:
- Rename the patch from 'perf util: Return per-event callchain streams' to 'perf util: Get the evsel_streams by evsel_idx'
tools/perf/util/stream.c | 11 +++++++++++ tools/perf/util/stream.h | 3 +++ 2 files changed, 14 insertions(+)
tools/perf/util/stream.c +11 -0
@@ -150,3 +150,14 @@ struct evsel_streams *perf_evlist__create_streams(struct evlist *evlist,return es; } + +struct evsel_streams *evsel_streams_get (struct evsel_streams *es, +int nr_evsel,int evsel_idx) +{ +for (int i =0 ; i < nr_evsel; i++) { +if (es[i].evsel_idx == evsel_idx) +return &es[i]; + } + +return NULL ; +}
tools/perf/util/stream.h +3 -0
@@ -27,4 +27,7 @@ struct evsel_streams *perf_evlist__create_streams(struct evlist *evlist,int nr_streams_max, enum stream_type type); +struct evsel_streams *evsel_streams_get (struct evsel_streams *es, +int nr_evsel,int evsel_idx); +#endif /* __PERF_STREAM_H */
Signature · 1 line
2.17.1
PATCH v4 6/7 perf util: Report hot streams
In reply to Jin YaoWe show the streams separately. They are divided into different sections.
1. "Matched hot streams"
2. "Hot streams in old perf data only"
3. "Hot streams in new perf data only".
For each stream, we report the cycles and hot percent (hits%).
For example,
cycles: 2, hits: 4.08%
--------------------------
main div.c:42
compute_flag div.c:28---
v4:
- Remove "Hot chains in old perf data but source line changed in new perf data"
tools/perf/util/callchain.c | 13 ++++ tools/perf/util/callchain.h | 2 + tools/perf/util/stream.c | 125 ++++++++++++++++++++++++++++++++++++ tools/perf/util/stream.h | 4 ++ 4 files changed, 144 insertions(+)
tools/perf/util/callchain.c +13 -0
@@ -1699,3 +1699,16 @@ u64 callchain_total_hits(struct hists *hists)return chain_hits; } + +s64 callchain_avg_cycles (struct callchain_node *cnode) +{ +struct callchain_list *chain; +s64 cycles =0 ; + +list_for_each_entry (chain, &cnode->val, list) { +if (chain->srcline && chain->branch_count) + cycles += chain->cycles_count / chain->branch_count; + } + +return cycles; +}
tools/perf/util/callchain.h +2 -0
@@ -305,4 +305,6 @@ bool callchain_cnode_matched(struct callchain_node *base_cnode,u64 callchain_total_hits (struct hists *hists); +s64 callchain_avg_cycles (struct callchain_node *cnode); +#endif /* __PERF_CALLCHAIN_H */
tools/perf/util/stream.c +125 -0
128 lines not on this page · raw message
tools/perf/util/stream.h +4 -0
@@ -35,4 +35,8 @@ struct evsel_streams *evsel_streams_get(struct evsel_streams *es,void match_evsel_streams (struct evsel_streams *es_base,struct evsel_streams *es_pair); +void evsel_streams_report (struct evsel_streams *es_base, +struct evsel_streams *es_pair, +enum stream_type type); +#endif /* __PERF_STREAM_H */
Signature · 1 line
2.17.1
PATCH v4 4/7 perf util: Link stream pair
In reply to Jin YaoIn previous patch, we have created an evsel_streams for one event, and top N hottest streams will be saved in a stream array in evsel_streams.
This patch compares total streams among two evsel_streams.
Once two streams are fully matched, they will be linked as a pair. From the pair, we can know which streams are matched.
---
v4:
- New patch in v4.
tools/perf/util/stream.c | 53 ++++++++++++++++++++++++++++++++++++++++ tools/perf/util/stream.h | 4 +++ 2 files changed, 57 insertions(+)
tools/perf/util/stream.c +53 -0
@@ -161,3 +161,56 @@ struct evsel_streams *evsel_streams_get(struct evsel_streams *es,return NULL ; } + +static struct stream *stream_callchain_match (struct stream *base_stream, +struct evsel_streams *es_pair) +{ +for (int i =0 ; i < es_pair->nr_streams; i++) { +struct stream *pair_stream = &es_pair->streams[i]; + +if (callchain_cnode_matched (base_stream->cnode, + pair_stream->cnode)) { +return pair_stream; + } + } + +return NULL ; +} + +static struct stream *stream_match (struct stream *base_stream, +struct evsel_streams *es_pair, +enum stream_type stream_type) +{ +if (stream_type ==STREAM_CALLCHAIN ) +return stream_callchain_match (base_stream, es_pair); + +return NULL ; +} + +static void stream_link (struct stream *base_stream,struct stream *pair_stream, +enum stream_type stream_type) +{ +if (stream_type ==STREAM_CALLCHAIN ) { + base_stream->pair_cnode = pair_stream->cnode; + pair_stream->pair_cnode = base_stream->cnode; + } +} + +void match_evsel_streams (struct evsel_streams *es_base, +struct evsel_streams *es_pair) +{ +if (es_base->stream_type != es_pair->stream_type) +return ; + +for (int i =0 ; i < es_base->nr_streams; i++) { +struct stream *base_stream = &es_base->streams[i]; +struct stream *pair_stream; + + pair_stream =stream_match (base_stream, es_pair, + es_base->stream_type); +if (pair_stream) { +stream_link (base_stream, pair_stream, + es_base->stream_type); + } + } +}
tools/perf/util/stream.h +4 -0
@@ -11,6 +11,7 @@ enum stream_type {struct stream {struct callchain_node *cnode; +struct callchain_node *pair_cnode; };struct evsel_streams {
@@ -30,4 +31,7 @@ struct evsel_streams *perf_evlist__create_streams(struct evlist *evlist,struct evsel_streams *evsel_streams_get (struct evsel_streams *es,int nr_evsel,int evsel_idx); +void match_evsel_streams (struct evsel_streams *es_base, +struct evsel_streams *es_pair); +#endif /* __PERF_STREAM_H */
Signature · 1 line
2.17.1
PATCH v4 5/7 perf util: Calculate the sum of total streams hits
In reply to Jin YaoWe have used callchain_node->hit to measure the hot level of one stream. This patch calculates the sum of hits of total streams.
Thus in next patch, we can use following formula to report hot percent for one stream.
hot percent = callchain_node->hit / sum of total hits
---
v4:
- No functional change.
v2:
- Combine the variable decl line with its initial assignment in total_callchain_hits().
tools/perf/util/callchain.c | 32 ++++++++++++++++++++++++++++++++ tools/perf/util/callchain.h | 3 +++ tools/perf/util/stream.c | 2 ++ tools/perf/util/stream.h | 1 + 4 files changed, 38 insertions(+)
tools/perf/util/callchain.c +32 -0
@@ -1667,3 +1667,35 @@ bool callchain_cnode_matched(struct callchain_node *base_cnode,return match; } + +static u64 count_callchain_hits (struct hist_entry *he) +{ +struct rb_root *root = &he->sorted_chain; +struct rb_node *rb_node =rb_first (root); +struct callchain_node *node; +u64 chain_hits =0 ; + +while (rb_node) { + node = rb_entry(rb_node, struct callchain_node, rb_node); + chain_hits += node->hit; + rb_node =rb_next (rb_node); + } + +return chain_hits; +} + +u64 callchain_total_hits (struct hists *hists) +{ +struct rb_node *next =rb_first_cached (&hists->entries); +u64 chain_hits =0 ; + +while (next) { + struct hist_entry *he = rb_entry(next, struct hist_entry, + rb_node); + + chain_hits +=count_callchain_hits (he); + next =rb_next (&he->rb_node); + } + +return chain_hits; +}
tools/perf/util/callchain.h +3 -0
@@ -13,6 +13,7 @@ struct ip_callchain;struct map ;struct perf_sample ;struct thread ; +struct hists ;#define HELP_PAD "\t\t\t\t"
@@ -302,4 +303,6 @@ void callchain_param_setup(u64 sample_type);bool callchain_cnode_matched (struct callchain_node *base_cnode,struct callchain_node *pair_cnode); +u64 callchain_total_hits (struct hists *hists); +#endif /* __PERF_CALLCHAIN_H */
tools/perf/util/stream.c +2 -0
@@ -106,6 +106,8 @@ static void init_hot_callchain(struct hists *hists, struct evsel_streams *es)update_hot_callchain (he, es); next =rb_next (&he->rb_node); } + + es->streams_hits =callchain_total_hits (hists); } static int evlist_init_callchain_streams(struct evlist *evlist,
tools/perf/util/stream.h +1 -0
@@ -20,6 +20,7 @@ struct evsel_streams {int nr_streams_max;int nr_streams;int evsel_idx; +u64 streams_hits; };struct evlist ;
Signature · 1 line
2.17.1
PATCH v4 7/7 perf diff: Support hot streams comparison
In reply to Jin YaoThis patch enables perf-diff with "--stream" option.
"--stream": Enable hot streams comparison
Now let's see examples.
perf record -b ... Generate perf.data.old with branch data
perf record -b ... Generate perf.data with branch data
perf diff --stream
[ Matched hot streams ]
hot chain pair 1:
cycles: 1, hits: 27.77% cycles: 1, hits: 9.24%
--------------------------- --------------------------
main div.c:39 main div.c:39
main div.c:44 main div.c:44
hot chain pair 2:
cycles: 34, hits: 20.06% cycles: 27, hits: 16.98%
--------------------------- --------------------------
__random_r random_r.c:360 __random_r random_r.c:360
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:380 __random_r random_r.c:380
__random_r random_r.c:357 __random_r random_r.c:357
__random random.c:293 __random random.c:293
__random random.c:293 __random random.c:293
__random random.c:291 __random random.c:291
__random random.c:291 __random random.c:291
__random random.c:291 __random random.c:291
__random random.c:288 __random random.c:288
rand rand.c:27 rand rand.c:27
rand rand.c:26 rand rand.c:26
rand@plt rand@plt
rand@plt rand@plt
compute_flag div.c:25 compute_flag div.c:25
compute_flag div.c:22 compute_flag div.c:22
main div.c:40 main div.c:40
main div.c:40 main div.c:40
main div.c:39 main div.c:39
hot chain pair 3:
cycles: 9, hits: 4.48% cycles: 6, hits: 4.51%
--------------------------- --------------------------
__random_r random_r.c:360 __random_r random_r.c:360
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:388 __random_r random_r.c:388
__random_r random_r.c:380 __random_r random_r.c:380[ Hot streams in old perf data only ]
hot chain 1:
cycles: 18, hits: 6.75%
--------------------------
__random_r random_r.c:360
__random_r random_r.c:388
__random_r random_r.c:388
__random_r random_r.c:380
__random_r random_r.c:357
__random random.c:293
__random random.c:293
__random random.c:291
__random random.c:291
__random random.c:291
__random random.c:288
rand rand.c:27
rand rand.c:26
rand@plt
rand@plt
compute_flag div.c:25
compute_flag div.c:22
main div.c:40hot chain 2:
cycles: 29, hits: 2.78%
--------------------------
compute_flag div.c:22
main div.c:40
main div.c:40
main div.c:39[ Hot streams in new perf data only ]
hot chain 1:
cycles: 4, hits: 4.54%
--------------------------
main div.c:42
compute_flag div.c:28hot chain 2:
cycles: 5, hits: 3.51%
--------------------------
main div.c:39
main div.c:44
main div.c:42
compute_flag div.c:28---
v4:
- Remove the "--before" and "--after" options since they are for source line based comparison. In this patchset, we will not support source line based comparison.
tools/perf/Documentation/perf-diff.txt | 4 + tools/perf/builtin-diff.c | 133 ++++++++++++++++++++++--- 2 files changed, 124 insertions(+), 13 deletions(-)
tools/perf/Documentation/perf-diff.txt +4 -0
@@ -182,6 +182,10 @@ OPTIONS --tid=:: Only diff samples for given thread ID (comma separated list). +--stream:: + Enable hot streams comparison. Stream can be a callchain which is + aggregated by the branch records from samples. + COMPARISON ---------- The comparison is governed by the baseline file. The baseline perf.data
tools/perf/builtin-diff.c +120 -13
216 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v4 1/7] perf util: Create streams
In reply to Jin YaoOn Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
SNIP
Quoted 26 lines
tools/perf/util/stream.c new file +20
-0+ int nr_streams_max, + enum stream_type type) +{ +struct evsel_streams *es; +int nr_evsel = evlist->core.nr_entries, ret =-1 ; + + es =create_evsel_streams (nr_evsel, nr_streams_max); +if (!es) +return NULL ; + +if (type ==STREAM_CALLCHAIN ) + ret =evlist_init_callchain_streams (evlist, es, nr_evsel); + +if (ret) { +free_evsel_streams (es, nr_evsel); +return NULL ; + } + +return es; +}tools/perf/util/stream.h new file +0
-0
tools/perf/util/stream.h line 9
Quoted 9 lines
tools/perf/util/stream.h new file +9
-0@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_STREAM_H +#define __PERF_STREAM_H + +#include "callchain.h" + +enum stream_type { +STREAM_NONE =0 , + STREAM_CALLCHAIN
do you plan to add more types?
jirka
Re: [PATCH v4 1/7] perf util: Create streams
Hi Jiri,
Quoted 42 lines · Jiri Olsa
On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
SNIP
Quoted 26 lines
tools/perf/util/stream.c new file +20
-0+ int nr_streams_max, + enum stream_type type) +{ +struct evsel_streams *es; +int nr_evsel = evlist->core.nr_entries, ret =-1 ; + + es =create_evsel_streams (nr_evsel, nr_streams_max); +if (!es) +return NULL ; + +if (type ==STREAM_CALLCHAIN ) + ret =evlist_init_callchain_streams (evlist, es, nr_evsel); + +if (ret) { +free_evsel_streams (es, nr_evsel); +return NULL ; + } + +return es; +}tools/perf/util/stream.h new file +0
-0tools/perf/util/stream.h line 9
Quoted 9 lines
tools/perf/util/stream.h new file +9
-0@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_STREAM_H +#define __PERF_STREAM_H + +#include "callchain.h" + +enum stream_type { +STREAM_NONE =0 , + STREAM_CALLCHAINdo you plan to add more types?
Quoted 2 lines
jirka
Thanks for looking at this patch series.
So far, no more types in plan. :)
Thanks
Jin Yao
Re: [PATCH v4 1/7] perf util: Create streams
Quoted 45 lines · Yao
Hi Jiri,
Quoted 42 lines · Jiri Olsa
On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
SNIP
Quoted 26 lines
tools/perf/util/stream.c new file +20
-0+ int nr_streams_max, + enum stream_type type) +{ +struct evsel_streams *es; +int nr_evsel = evlist->core.nr_entries, ret =-1 ; + + es =create_evsel_streams (nr_evsel, nr_streams_max); +if (!es) +return NULL ; + +if (type ==STREAM_CALLCHAIN ) + ret =evlist_init_callchain_streams (evlist, es, nr_evsel); + +if (ret) { +free_evsel_streams (es, nr_evsel); +return NULL ; + } + +return es; +}tools/perf/util/stream.h new file +0
-0tools/perf/util/stream.h line 9
Quoted 9 lines
tools/perf/util/stream.h new file +9
-0@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_STREAM_H +#define __PERF_STREAM_H + +#include "callchain.h" + +enum stream_type { +STREAM_NONE =0 , + STREAM_CALLCHAINdo you plan to add more types?
Quoted 6 lines
Quoted 2 lines
jirka
Thanks for looking at this patch series.
So far, no more types in plan. :)
I was wondering what's the enum for then, it could be hardcoded and ease up the code maybe? but it's jus a thought, I don't follow the change deeply
jirka
Re: [PATCH v4 1/7] perf util: Create streams
Hi Jiri,
Quoted 51 lines · Jiri Olsa
Quoted 50 lines · Yao
Hi Jiri,
Quoted 42 lines · Jiri Olsa
On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
SNIP
Quoted 26 lines
tools/perf/util/stream.c new file +20
-0+ int nr_streams_max, + enum stream_type type) +{ +struct evsel_streams *es; +int nr_evsel = evlist->core.nr_entries, ret =-1 ; + + es =create_evsel_streams (nr_evsel, nr_streams_max); +if (!es) +return NULL ; + +if (type ==STREAM_CALLCHAIN ) + ret =evlist_init_callchain_streams (evlist, es, nr_evsel); + +if (ret) { +free_evsel_streams (es, nr_evsel); +return NULL ; + } + +return es; +}tools/perf/util/stream.h new file +0
-0tools/perf/util/stream.h line 9
Quoted 9 lines
tools/perf/util/stream.h new file +9
-0@@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __PERF_STREAM_H +#define __PERF_STREAM_H + +#include "callchain.h" + +enum stream_type { +STREAM_NONE =0 , + STREAM_CALLCHAINdo you plan to add more types?
Quoted 2 lines
jirka
Thanks for looking at this patch series.
Quoted 8 lines
Quoted 1 line
So far, no more types in plan. :)
I was wondering what's the enum for then, it could be hardcoded and ease up the code maybe? but it's jus a thought, I don't follow the change deeply
jirka
Hmm, I've ever thought to add a new type such as stream_block in the future. But in order to let the patchset be simple and clear, I'm OK to remove this enum.
Thanks
Jin Yao