Skip to contentSkip to conversation

lttng-tools: Do not build for riscv64

PATCH In review Khem Raj 4 participants 5 messages Aug 26, 2020 – Aug 27, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 lttng-tools: Do not build for riscv64

Since lttng-modules are not buildable, there is no point of building tools either

---
 .../packagegroups/packagegroup-core-tools-profile.bb           | 1 +
 meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb                | 3 +++
 2 files changed, 4 insertions(+)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -0
index ca35af1ec3..608e406f83 100644
@@ -41,6 +41,7 @@ LTTNGUST_arc = ""
 
 LTTNGTOOLS = "lttng-tools"
 LTTNGTOOLS_arc = ""
+LTTNGTOOLS_riscv64 = ""
 
 LTTNGMODULES = "lttng-modules"
 LTTNGMODULES_arc = ""
meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb +3 -0
index e9c8e18e22..0614e86713 100644
@@ -162,3 +162,6 @@ do_install_ptest () {
         esac
     done
 }
+
+COMPATIBLE_HOST_riscv64 = "null"
+
Signature · 1 line
2.28.0
#1 lore raw

Hi,

LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules (tracer) is not present kernel tracing is disabled and only userspace tracing is available.

Was there any report that lttng-ust (userspace tracing) is not working as intended on riscv64?

Cheers

Quoted 37 lines · Khem Raj

Since lttng-modules are not buildable, there is no point of building tools either

---
 .../packagegroups/packagegroup-core-tools-profile.bb           | 1 +
 meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb                | 3 +++
 2 files changed, 4 insertions(+)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -0
index ca35af1ec3..608e406f83 100644
@@ -41,6 +41,7 @@ LTTNGUST_arc = ""
 
 LTTNGTOOLS = "lttng-tools"
 LTTNGTOOLS_arc = ""
+LTTNGTOOLS_riscv64 = ""
 
 LTTNGMODULES = "lttng-modules"
 LTTNGMODULES_arc = ""
meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb +3 -0
index e9c8e18e22..0614e86713 100644
@@ -162,3 +162,6 @@ do_install_ptest () {
         esac
     done
 }
+
+COMPATIBLE_HOST_riscv64 = "null"
+
Signature · 1 line
2.28.0
Signature · 2 lines
Jonathan Rajotte-Julien
EfficiOS
author
#2 lore raw
Quoted 8 lines · Jonathan Rajotte-Julien

Hi,

LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules (tracer) is not present kernel tracing is disabled and only userspace tracing is available.

Was there any report that lttng-ust (userspace tracing) is not working as intended on riscv64?

No, but lttng-tools have this as rdep for ptest packages which is not controlled via packageconfig or something.

Quoted 43 lines

Cheers

Quoted 37 lines · Khem Raj

Since lttng-modules are not buildable, there is no point of building tools either

---
  .../packagegroups/packagegroup-core-tools-profile.bb           | 1 +
  meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb                | 3 +++
  2 files changed, 4 insertions(+)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -0
index ca35af1ec3..608e406f83 100644
@@ -41,6 +41,7 @@ LTTNGUST_arc = ""
 
  LTTNGTOOLS = "lttng-tools"
  LTTNGTOOLS_arc = ""
+LTTNGTOOLS_riscv64 = ""
 
  LTTNGMODULES = "lttng-modules"
  LTTNGMODULES_arc = ""
meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb +3 -0
index e9c8e18e22..0614e86713 100644
@@ -162,3 +162,6 @@ do_install_ptest () {
          esac
      done
  }
+
+COMPATIBLE_HOST_riscv64 = "null"
+
Signature · 1 line
2.28.0
#3 lore raw
Quoted 9 lines · Khem Raj
Quoted 6 lines

LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules (tracer) is not present kernel tracing is disabled and only userspace tracing is available.

Was there any report that lttng-ust (userspace tracing) is not working as intended on riscv64?

No, but lttng-tools have this as rdep for ptest packages which is not controlled via packageconfig or something.

Make it a recommends instead?

Ross

#4 lore raw
Quoted 11 lines · Ross Burton
Quoted 10 lines · Khem Raj
Quoted 9 lines

LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules
(tracer) is not present kernel tracing is disabled and only userspace tracing is
available.

Was there any report that lttng-ust (userspace tracing) is not working as
intended on riscv64?

Quoted 5 lines
Quoted 3 lines

No, but lttng-tools have this as rdep for ptest packages which is not
controlled via packageconfig or something.

Make it a recommends instead?

Those are still fatal from a build providers perspective...

Sounds to me like we should move the conditional skipping in lttng- modules somewhere lttng-tools can also see it, then use that in the RDEPENDS_lttng-tools-ptest...

Cheers,

Richard