Skip to contentSkip to conversation

crypto: inside-secure - use kfree_sensitive()

PATCH In review Denis Efremov 2 participants 2 messages Aug 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: inside-secure - use kfree_sensitive()

Use kfree_sensitive() instead of open-coding it.

---
 drivers/crypto/inside-secure/safexcel_hash.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/crypto/inside-secure/safexcel_hash.c +1 -2
index 16a467969d8e..5ffdc1cd5847 100644
@@ -1082,8 +1082,7 @@ static int safexcel_hmac_init_pad(struct ahash_request *areq,
 		}
 
 		/* Avoid leaking */
-		memzero_explicit(keydup, keylen);
-		kfree(keydup);
+		kfree_sensitive(keydup);
 
 		if (ret)
 			return ret;
Signature · 1 line
2.26.2
maintainer
#1 lore raw
Quoted 6 lines · Denis Efremov

Use kfree_sensitive() instead of open-coding it.

---
 drivers/crypto/inside-secure/safexcel_hash.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Please redo this as a patch series.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt