crypto: sun8i-ss - use kfree_sensitive()
PATCH 1/1 crypto: sun8i-ss - use kfree_sensitive()
Use kfree_sensitive() instead of open-coding it.
Signed-off-by Denis Efremov <[email protected]>
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +3 -6
@@ -369,8 +369,7 @@ void sun8i_ss_cipher_exit(struct crypto_tfm *tfm)struct sun8i_cipher_tfm_ctx *op =crypto_tfm_ctx (tfm);if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); }crypto_free_skcipher (op->fallback_tfm);pm_runtime_put_sync (op->ss->dev);
@@ -394,8 +393,7 @@ int sun8i_ss_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,return -EINVAL ; }if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); } op->keylen = keylen; op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );
@@ -420,8 +418,7 @@ int sun8i_ss_des3_setkey(struct crypto_skcipher *tfm, const u8 *key, }if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); } op->keylen = keylen; op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );
Signature · 1 line
2.26.2
Corentin Labbe
maintainerQuoted 44 lines · Denis Efremov
Use
kfree_sensitive()instead of open-coding it.Signed-off-by Denis Efremov <[email protected]>--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +3
-6@@ -369,8 +369,7 @@ void sun8i_ss_cipher_exit(struct crypto_tfm *tfm)struct sun8i_cipher_tfm_ctx *op =crypto_tfm_ctx (tfm);if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); }crypto_free_skcipher (op->fallback_tfm);pm_runtime_put_sync (op->ss->dev);@@ -394,8 +393,7 @@ int sun8i_ss_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,return -EINVAL ; }if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); } op->keylen = keylen; op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );@@ -420,8 +418,7 @@ int sun8i_ss_des3_setkey(struct crypto_skcipher *tfm, const u8 *key, }if (op->key) { -memzero_explicit (op->key, op->keylen); -kfree (op->key); +kfree_sensitive (op->key); } op->keylen = keylen; op->key =kmemdup (key, keylen,GFP_KERNEL |GFP_DMA );Signature · 1 line
2.26.2
Hello
Same comment than for your crypto/amlogic patch.
Please remove the "if (op->key)"
Regards