pwm: bcm2835: Simplify with dev_err_probe()
Subsystems (9)
PATCH 1/6 pwm: bcm2835: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-bcm2835.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/pwm/pwm-bcm2835.c +3 -7
@@ -152,13 +152,9 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)return PTR_ERR (pc->base); pc->clk =devm_clk_get (&pdev->dev,NULL ); -if (IS_ERR (pc->clk)) { - ret =PTR_ERR (pc->clk); -if (ret != -EPROBE_DEFER ) -dev_err (&pdev->dev,"clock not found: %d\n" , ret); - -return ret; - } +if (IS_ERR (pc->clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pc->clk), +"clock not found\n" ); ret =clk_prepare_enable (pc->clk);if (ret)
Signature · 1 line
2.17.1
PATCH 2/6 pwm: jz4740: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-jz4740.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/pwm/pwm-jz4740.c +3 -6
@@ -60,12 +60,9 @@ static int jz4740_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)snprintf (name,sizeof (name),"timer%u" , pwm->hwpwm); clk =clk_get (chip->dev, name); -if (IS_ERR (clk)) { -if (PTR_ERR (clk) != -EPROBE_DEFER ) -dev_err (chip->dev,"Failed to get clock: %pe" , clk); - -return PTR_ERR (clk); - } +if (IS_ERR (clk)) +return dev_err_probe (chip->dev,PTR_ERR (clk), +"Failed to get clock\n" ); err =clk_prepare_enable (clk);if (err <0 ) {
Signature · 1 line
2.17.1
PATCH 3/6 pwm: rockchip: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-rockchip.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/pwm/pwm-rockchip.c +3 -7
@@ -306,13 +306,9 @@ static int rockchip_pwm_probe(struct platform_device *pdev) pc->clk =devm_clk_get (&pdev->dev,"pwm" );if (IS_ERR (pc->clk)) { pc->clk =devm_clk_get (&pdev->dev,NULL ); -if (IS_ERR (pc->clk)) { - ret =PTR_ERR (pc->clk); -if (ret != -EPROBE_DEFER ) -dev_err (&pdev->dev,"Can't get bus clk: %d\n" , - ret); -return ret; - } +if (IS_ERR (pc->clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pc->clk), +"Can't get bus clk\n" ); } count = of_count_phandle_with_args(pdev->dev.of_node,
Signature · 1 line
2.17.1
PATCH 4/6 pwm: sifive: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-sifive.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/pwm/pwm-sifive.c +3 -5
@@ -254,11 +254,9 @@ static int pwm_sifive_probe(struct platform_device *pdev)return PTR_ERR (ddata->regs); ddata->clk =devm_clk_get (dev,NULL ); -if (IS_ERR (ddata->clk)) { -if (PTR_ERR (ddata->clk) != -EPROBE_DEFER ) -dev_err (dev,"Unable to find controller clock\n" ); -return PTR_ERR (ddata->clk); - } +if (IS_ERR (ddata->clk)) +return dev_err_probe (dev,PTR_ERR (ddata->clk), +"Unable to find controller clock\n" ); ret =clk_prepare_enable (ddata->clk);if (ret) {
Signature · 1 line
2.17.1
PATCH 5/6 pwm: sprd: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-sprd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/pwm/pwm-sprd.c +2 -5
@@ -228,11 +228,8 @@ static int sprd_pwm_clk_init(struct sprd_pwm_chip *spc)if (ret == -ENOENT )break ; -if (ret != -EPROBE_DEFER ) -dev_err (spc->dev, -"failed to get channel clocks\n" ); - -return ret; +return dev_err_probe (spc->dev, ret, +"failed to get channel clocks\n" ); } clk_pwm = chn->clks[SPRD_PWM_CHN_OUTPUT_CLK ].clk;
Signature · 1 line
2.17.1
PATCH 6/6 pwm: sun4i: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/pwm/pwm-sun4i.c | 36 ++++++++++++------------------------ 1 file changed, 12 insertions(+), 24 deletions(-)
drivers/pwm/pwm-sun4i.c +12 -24
@@ -423,38 +423,26 @@ static int sun4i_pwm_probe(struct platform_device *pdev)* back to the first clock of the PWM. */ pwm->clk =devm_clk_get_optional (&pdev->dev,"mod" ); -if (IS_ERR (pwm->clk)) { -if (PTR_ERR (pwm->clk) != -EPROBE_DEFER ) -dev_err (&pdev->dev,"get mod clock failed %pe\n" , - pwm->clk); -return PTR_ERR (pwm->clk); - } +if (IS_ERR (pwm->clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pwm->clk), +"get mod clock failed\n" );if (!pwm->clk) { pwm->clk =devm_clk_get (&pdev->dev,NULL ); -if (IS_ERR (pwm->clk)) { -if (PTR_ERR (pwm->clk) != -EPROBE_DEFER ) -dev_err (&pdev->dev,"get unnamed clock failed %pe\n" , - pwm->clk); -return PTR_ERR (pwm->clk); - } +if (IS_ERR (pwm->clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pwm->clk), +"get unnamed clock failed\n" ); } pwm->bus_clk =devm_clk_get_optional (&pdev->dev,"bus" ); -if (IS_ERR (pwm->bus_clk)) { -if (PTR_ERR (pwm->bus_clk) != -EPROBE_DEFER ) -dev_err (&pdev->dev,"get bus clock failed %pe\n" , - pwm->bus_clk); -return PTR_ERR (pwm->bus_clk); - } +if (IS_ERR (pwm->bus_clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pwm->bus_clk), +"get bus clock failed\n" ); pwm->rst =devm_reset_control_get_optional_shared (&pdev->dev,NULL ); -if (IS_ERR (pwm->rst)) { -if (PTR_ERR (pwm->rst) != -EPROBE_DEFER ) -dev_err (&pdev->dev,"get reset failed %pe\n" , - pwm->rst); -return PTR_ERR (pwm->rst); - } +if (IS_ERR (pwm->rst)) +return dev_err_probe (&pdev->dev,PTR_ERR (pwm->rst), +"get reset failed\n" );/* Deassert reset */ ret =reset_control_deassert (pwm->rst);
Signature · 1 line
2.17.1
Re: [PATCH 4/6] pwm: sifive: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 17 lines · On Wed, 26 Aug 2020 07:47:45 PDT (-0700), [email protected] wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pwm/pwm-sifive.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)drivers/pwm/pwm-sifive.c +0
-1@@ -254,11 +254,9 @@ static int pwm_sifive_probe(struct platform_device *pdev)return PTR_ERR (ddata->regs); ddata->clk =devm_clk_get (dev,NULL ); -if (IS_ERR (ddata->clk)) {
drivers/pwm/pwm-sifive.c static int pwm_sifive_probe(struct platform_device *pdev) · line 262
Quoted 10 lines
drivers/pwm/pwm-sifive.c +3
-4-if (PTR_ERR (ddata->clk) != -EPROBE_DEFER ) -dev_err (dev,"Unable to find controller clock\n" ); -return PTR_ERR (ddata->clk); - } +if (IS_ERR (ddata->clk)) +return dev_err_probe (dev,PTR_ERR (ddata->clk), +"Unable to find controller clock\n" ); ret =clk_prepare_enable (ddata->clk);if (ret) {
Quoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Signature · 1 line
Florian
Re: [PATCH 5/6] pwm: sprd: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 5 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks!
Quoted 25 lines
--- drivers/pwm/pwm-sprd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/pwm/pwm-sprd.c +2
-6@@ -228,11 +228,8 @@ static int sprd_pwm_clk_init(struct sprd_pwm_chip *spc)if (ret == -ENOENT )break ; -if (ret != -EPROBE_DEFER ) -dev_err (spc->dev, -"failed to get channel clocks\n" ); - -return ret; +return dev_err_probe (spc->dev, ret, +"failed to get channel clocks\n" ); } clk_pwm = chn->clks[SPRD_PWM_CHN_OUTPUT_CLK ].clk; --2.17.1
Quoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Re: [PATCH 2/6] pwm: jz4740: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Re: [PATCH 3/6] pwm: rockchip: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Re: [PATCH 4/6] pwm: sifive: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Re: [PATCH 5/6] pwm: sprd: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiHello,
Quoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Re: [PATCH 6/6] pwm: sun4i: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiQuoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Thierry Reding
AppliedQuoted 7 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pwm/pwm-bcm2835.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
Applied, thanks.
Thierry