Skip to contentSkip to conversation

ASoC: AMD: Clean kernel log from deferred probe error messages

PATCH In review Akshu Agrawal 2 participants 2 messages Aug 26, 2020 – Aug 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: AMD: Clean kernel log from deferred probe error messages

While the driver waits for DAIs to be probed and retries probing, have the error messages at debug level instead of error.

---
v2: Add a debug level message for -EPROBE_DEFER

 sound/soc/amd/acp3x-rt5682-max9836.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
sound/soc/amd/acp3x-rt5682-max9836.c +8 -3
index 406526e79af3..1a4e8ca0f99c 100644
@@ -472,12 +472,17 @@ static int acp3x_probe(struct platform_device *pdev)
 
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
 	if (ret) {
-		dev_err(&pdev->dev,
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
 				"devm_snd_soc_register_card(%s) failed: %d\n",
 				card->name, ret);
-		return ret;
+		else
+			dev_dbg(&pdev->dev,
+				"devm_snd_soc_register_card(%s) probe deferred: %d\n",
+				card->name, ret);
 	}
-	return 0;
+
+	return ret;
 }
 
 static const struct acpi_device_id acp3x_audio_acpi_match[] = {
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 2 lines · Akshu Agrawal

While the driver waits for DAIs to be probed and retries probing, have the error messages at debug level instead of error.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: AMD: Clean kernel log from deferred probe error messages

      commit: f7660445c8e7fda91e8b944128554249d886b1d4

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark