x86: Use XORL r32,r32 in __get_user_asm
PATCH 1/1 x86: Use XORL r32,r32 in __get_user_asm
Use XORL r32,r32 for all operand sizes. x86_64 zero extends 32bit operations, so for 64bit operands, XORL r32,r32 is functionally equal to XORL r64,r64, but avoids a REX prefix byte when legacy registers are used.
32bit operation also avoids 0x66 size prefix for 16bit operands and REX prefix when %sil, %dil and %bpl 8bit registers are used.
As a bonus, 32bit XORL breaks register dependency chains, avoiding potential partial register stalls with 8 and 16bit operands.
The patch lowers the size of .fixup section by 20 bytes.
--- arch/x86/include/asm/uaccess.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/uaccess.h +1 -1
@@ -343,7 +343,7 @@ do { \"2:\n" \".section .fixup,\"ax\"\n" \"3: mov %[efault],%[errout]\n" \ -" xor" itype" %[output],%[output]\n" \ +" xorl %k[output],%k[output]\n" \" jmp 2b\n" \".previous\n" \ _ASM_EXTABLE_UA(1b ,3b ) \
Signature · 1 line
2.26.2
H. Peter Anvin
reviewerQuoted 4 lines · Uros Bizjak
Use XORL r32,r32 for all operand sizes.
x86_64zero extends 32bit operations, so for 64bit operands, XORL r32,r32 is functionally equal to XORL r64,r64, but avoids a REX prefix byte when legacy registers are used.
Please make it clear that this refers specifically to the use case of both registers being the same, for zeroing. This could otherwise be misread.
"xorl r64,r64" is nonsensical: you're referring to xorq.
The apparent visual mix here between Intel and gas syntax is also confusing.
I would explicily say, using gcc inline syntax:
xorl %0,%0 is equivalent to xorq %0,%0 as both will zero the entire register.
Quoted 5 lines
32bit operation also avoids
0x66size prefix for 16bit operands and REX prefix when %sil, %dil and %bpl 8bit registers are used.As a bonus, 32bit XORL breaks register dependency chains, avoiding potential partial register stalls with 8 and 16bit operands.
Please make it clear that zeroing the full register is OK in this use case (which it is.)
Quoted 1 line
The patch lowers the size of .fixup section by 20 bytes.
-hpa