Skip to contentSkip to conversation

scsi: megaraid_sas: Don't call disable_irq from process IRQ poll

PATCH Applied Tomas Henzl 2 participants 2 messages Aug 27, 2020 – Sep 3, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: megaraid_sas: Don't call disable_irq from process IRQ poll

disable_irq might sleep, replace it with disable_irq_nosync which is sufficient, irq_poll_scheduled protects againt running complete_cmd_fusion in parallel from megasas_irqpoll and megasas_isr_fusion.

Fixes a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ poll
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/megaraid/megaraid_sas_fusion.c +1 -1
index 319f241da..766bc2bb1 100644
@@ -3690,7 +3690,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget)
 	instance = irq_ctx->instance;
 
 	if (irq_ctx->irq_line_enable) {
-		disable_irq(irq_ctx->os_irq);
+		disable_irq_nosync(irq_ctx->os_irq);
 		irq_ctx->irq_line_enable = false;
 	}
 
Signature · 1 line
2.25.4
#1 lore raw
Quoted 3 lines · Tomas Henzl

disable_irq might sleep, replace it with disable_irq_nosync which is sufficient, irq_poll_scheduled protects againt running complete_cmd_fusion in parallel from megasas_irqpoll and megasas_isr_fusion.

Applied to 5.9/scsi-fixes, thanks!

[1/1] scsi: megaraid_sas: Don't call disable_irq from process IRQ poll

      https://git.kernel.org/mkp/scsi/c/d2af39141eea
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering