Skip to contentSkip to conversation

MAINTAINERS: Remove bouncing email of Beniamin Bia

PATCH In review Krzysztof Kozlowski 5 participants 9 messages Aug 27, 2020 – Sep 2, 2020 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Remove bouncing email of Beniamin Bia

Emails to Beniamin Bia bounce with no such address so remove him from maintainers.

Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc linux-iio <[email protected]>
---
 MAINTAINERS | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
MAINTAINERS +1 -6
index 8107b3d5d6df..523ac1602b62 100644
@@ -967,9 +967,8 @@ F:	Documentation/devicetree/bindings/iio/dac/ad5758.txt
 F:	drivers/iio/dac/ad5758.c
 
 ANALOG DEVICES INC AD7091R5 DRIVER
-M:	Beniamin Bia <[email protected]>
 L:	[email protected]
-S:	Supported
+S:	Orphan
 W:	http://ez.analog.com/community/linux-device-drivers
 F:	Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
 F:	drivers/iio/adc/ad7091r5.c
@@ -1000,7 +999,6 @@ F:	drivers/iio/adc/ad7292.c
 
 ANALOG DEVICES INC AD7606 DRIVER
 M:	Michael Hennerich <[email protected]>
-M:	Beniamin Bia <[email protected]>
 L:	[email protected]
 S:	Supported
 W:	http://ez.analog.com/community/linux-device-drivers
@@ -1068,7 +1066,6 @@ F:	drivers/iio/imu/adis16475.c
 F:	Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
 
 ANALOG DEVICES INC ADM1177 DRIVER
-M:	Beniamin Bia <[email protected]>
 M:	Michael Hennerich <[email protected]>
 L:	[email protected]
 S:	Supported
@@ -1136,7 +1133,6 @@ W:	http://ez.analog.com/community/linux-device-drivers
 F:	drivers/dma/dma-axi-dmac.c
 
 ANALOG DEVICES INC HMC425A DRIVER
-M:	Beniamin Bia <[email protected]>
 M:	Michael Hennerich <[email protected]>
 L:	[email protected]
 S:	Supported
@@ -16537,7 +16533,6 @@ F:	drivers/staging/rtl8712/
 
 STAGING - SEPS525 LCD CONTROLLER DRIVERS
 M:	Michael Hennerich <[email protected]>
-M:	Beniamin Bia <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Krzysztof Kozlowski

Emails to Beniamin Bia bounce with no such address so remove him from maintainers.

I guess Reported-by suits better... But okay.

Quoted 58 lines
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc linux-iio <[email protected]>
---
 MAINTAINERS | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
MAINTAINERS +1 -7
index 8107b3d5d6df..523ac1602b62 100644
@@ -967,9 +967,8 @@ F:  Documentation/devicetree/bindings/iio/dac/ad5758.txt
 F:     drivers/iio/dac/ad5758.c
 
 ANALOG DEVICES INC AD7091R5 DRIVER
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
-S:     Supported
+S:     Orphan
 W:     http://ez.analog.com/community/linux-device-drivers
 F:     Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
 F:     drivers/iio/adc/ad7091r5.c
@@ -1000,7 +999,6 @@ F: drivers/iio/adc/ad7292.c
 
 ANALOG DEVICES INC AD7606 DRIVER
 M:     Michael Hennerich <[email protected]>
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
 S:     Supported
 W:     http://ez.analog.com/community/linux-device-drivers
@@ -1068,7 +1066,6 @@ F:        drivers/iio/imu/adis16475.c
 F:     Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
 
 ANALOG DEVICES INC ADM1177 DRIVER
-M:     Beniamin Bia <[email protected]>
 M:     Michael Hennerich <[email protected]>
 L:     [email protected]
 S:     Supported
@@ -1136,7 +1133,6 @@ W:        http://ez.analog.com/community/linux-device-drivers
 F:     drivers/dma/dma-axi-dmac.c
 
 ANALOG DEVICES INC HMC425A DRIVER
-M:     Beniamin Bia <[email protected]>
 M:     Michael Hennerich <[email protected]>
 L:     [email protected]
 S:     Supported
@@ -16537,7 +16533,6 @@ F:      drivers/staging/rtl8712/
 
 STAGING - SEPS525 LCD CONTROLLER DRIVERS
 M:     Michael Hennerich <[email protected]>
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
 S:     Supported
 F:     Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
--

2.17.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 8 lines · On Fri, 28 Aug 2020 11:19:21 +0300 Andy Shevchenko <[email protected]>…
Quoted 5 lines · Krzysztof Kozlowski

Emails to Beniamin Bia bounce with no such address so remove him from maintainers.

I guess Reported-by suits better... But okay.

As mentioned below, I'm not keen on marking a driver as orphan when it is covered by a catch all.

drivers/iio/*/ad*

Let's find out what the Analog team want to do about these.

Jonathan

Quoted 16 lines
Quoted 16 lines
Cc Michael Hennerich <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc linux-iio <[email protected]>
---
 MAINTAINERS | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
MAINTAINERS +0 -0
index 8107b3d5d6df..523ac1602b62 100644
@@ -967,9 +967,8 @@ F:  Documentation/devicetree/bindings/iio/dac/ad5758.txt
 F:     drivers/iio/dac/ad5758.c
 
Quoted 5 lines

MAINTAINERS F: Documentation/devicetree/bindings/iio/dac/ad5758.txt · line 971

Quoted 5 lines
MAINTAINERS +1 -2
 ANALOG DEVICES INC AD7091R5 DRIVER
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
-S:     Supported
+S:     Orphan

Given it should be covered by the catch all for Analog devices IIO drivers, either we should confirm if it should move to someone else at Analog, or if we should just drop specifically listing this one.
Listing it as Orphan when they are good at supporting their drivers may give the wrong impression.

+CC Alex to make sure people at Analog notice :)

Jonathan

Quoted 40 lines
Quoted 38 lines
MAINTAINERS +0 -5
 W:     http://ez.analog.com/community/linux-device-drivers
 F:     Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
 F:     drivers/iio/adc/ad7091r5.c
@@ -1000,7 +999,6 @@ F: drivers/iio/adc/ad7292.c
 
 ANALOG DEVICES INC AD7606 DRIVER
 M:     Michael Hennerich <[email protected]>
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
 S:     Supported
 W:     http://ez.analog.com/community/linux-device-drivers
@@ -1068,7 +1066,6 @@ F:        drivers/iio/imu/adis16475.c
 F:     Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
 
 ANALOG DEVICES INC ADM1177 DRIVER
-M:     Beniamin Bia <[email protected]>
 M:     Michael Hennerich <[email protected]>
 L:     [email protected]
 S:     Supported
@@ -1136,7 +1133,6 @@ W:        http://ez.analog.com/community/linux-device-drivers
 F:     drivers/dma/dma-axi-dmac.c
 
 ANALOG DEVICES INC HMC425A DRIVER
-M:     Beniamin Bia <[email protected]>
 M:     Michael Hennerich <[email protected]>
 L:     [email protected]
 S:     Supported
@@ -16537,7 +16533,6 @@ F:      drivers/staging/rtl8712/
 
 STAGING - SEPS525 LCD CONTROLLER DRIVERS
 M:     Michael Hennerich <[email protected]>
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
 S:     Supported
 F:     Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
--

2.17.1

#3 lore raw

On Sat, 29 Aug 2020 at 16:54, Jonathan Cameron <[email protected]> wrote:

(...)

Quoted 12 lines
Quoted 5 lines

MAINTAINERS F: Documentation/devicetree/bindings/iio/dac/ad5758.txt · line 971

Quoted 5 lines

ANALOG DEVICES INC AD7091R5 DRIVER

MAINTAINERS +1 -2
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
-S:     Supported
+S:     Orphan

Given it should be covered by the catch all for Analog devices IIO drivers, either we should confirm if it should move to someone else at Analog, or if we should just drop specifically listing this one.
Listing it as Orphan when they are good at supporting their drivers may give the wrong impression.

Quoted 1 line

+CC Alex to make sure people at Analog notice :)

Sure, good point. I wanted to start the discussion so the interested people might appear.

Best regards,
Krzysztof

#4 lore raw

[yes, I know, bad-email format, but I wanted this to come from my work email]

Apologies also for the delay here. Things pile-up on my side and I defer things a bit.

Talked to Michael Hennerich about this [since he's the more senior contact at Analog].
We can replace the email from Beniamin Bia with Michael's.
Or, we can remove the "Orphan" blocks and just have the catch-all "drivers/iio/*/ad*" cover this driver and others that were upstreamed by Beniamin.

Either option is fine from us.

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Saturday, August 29, 2020 5:58 PM
To: Jonathan Cameron <[email protected]>
Cc: Andy Shevchenko <[email protected]>; Linux Kernel Mailing List <[email protected]>; Hennerich, Michael <[email protected]>; linux-iio <[email protected]>; Ardelean, Alexandru <[email protected]>
Subject: Re: [PATCH] MAINTAINERS: Remove bouncing email of Beniamin Bia

On Sat, 29 Aug 2020 at 16:54, Jonathan Cameron <[email protected]> wrote:

(...)

Quoted 12 lines
Quoted 5 lines

MAINTAINERS F: Documentation/devicetree/bindings/iio/dac/ad5758.txt · line 971

Quoted 5 lines

ANALOG DEVICES INC AD7091R5 DRIVER

MAINTAINERS +1 -2
-M:     Beniamin Bia <[email protected]>
 L:     [email protected]
-S:     Supported
+S:     Orphan

Given it should be covered by the catch all for Analog devices IIO drivers, either we should confirm if it should move to someone else at Analog, or if we should just drop specifically listing this one. Listing it as Orphan when they are good at supporting their drivers may give the wrong impression.

Quoted 1 line

+CC Alex to make sure people at Analog notice :)

Sure, good point. I wanted to start the discussion so the interested people might appear.

Best regards,
Krzysztof

#5 lore raw
Quoted 10 lines · Alexandru

[yes, I know, bad-email format, but I wanted this to come from my work email]

Apologies also for the delay here. Things pile-up on my side and I defer things a bit.

Talked to Michael Hennerich about this [since he's the more senior contact at Analog].
We can replace the email from Beniamin Bia with Michael's.
Or, we can remove the "Orphan" blocks and just have the catch-all "drivers/iio/*/ad*" cover this driver and others that were upstreamed by Beniamin.

Either option is fine from us.

As a participant of activity to put MAINTAINERS in some order, I prefer to have similar blocks be squashed.
If there will be a dedicated maintainer for a certain driver in the future, we can always split into separate sections.

So, something like
ANALOG DEVICES ADC (I guess it makes sense to have some grouping still)
...
F: .../ad1234
F: .../ad2345

In one section (no need to have wildcards right now).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw
Quoted 18 lines · On Wed, 2 Sep 2020 10:49:04 +0300 Andy Shevchenko <[email protected]>…
Quoted 10 lines · Alexandru

[yes, I know, bad-email format, but I wanted this to come from my work email]

Apologies also for the delay here. Things pile-up on my side and I defer things a bit.

Talked to Michael Hennerich about this [since he's the more senior contact at Analog].
We can replace the email from Beniamin Bia with Michael's.
Or, we can remove the "Orphan" blocks and just have the catch-all "drivers/iio/*/ad*" cover this driver and others that were upstreamed by Beniamin.

Either option is fine from us.

As a participant of activity to put MAINTAINERS in some order, I prefer to have similar blocks be squashed.
If there will be a dedicated maintainer for a certain driver in the future, we can always split into separate sections.

Quoted 8 lines

So, something like
ANALOG DEVICES ADC (I guess it makes sense to have some grouping still)
...
F: .../ad1234
F: .../ad2345

In one section (no need to have wildcards right now).

ANALOG DEVICES INC IIO DRIVERS
M: Lars-Peter Clausen <[email protected]>
M: Michael Hennerich <[email protected]>
S: Supported
W: http://wiki.analog.com/
W: http://ez.analog.com/community/linux-device-drivers
F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
F: drivers/iio/*/ad*
F: drivers/iio/adc/ltc249*
F: drivers/staging/iio/*/ad*
X: drivers/iio/*/adjd*

Already exists. We could potentially clean that up.

For the block that started this thread, we can just drop it.

Jonathan

#7 lore raw
Quoted 44 lines · Jonathan Cameron
Quoted 18 lines · On Wed, 2 Sep 2020 10:49:04 +0300 Andy Shevchenko <[email protected]>…
Quoted 10 lines · Alexandru

[yes, I know, bad-email format, but I wanted this to come from my work email]

Apologies also for the delay here. Things pile-up on my side and I defer things a bit.

Talked to Michael Hennerich about this [since he's the more senior contact at Analog].
We can replace the email from Beniamin Bia with Michael's.
Or, we can remove the "Orphan" blocks and just have the catch-all "drivers/iio/*/ad*" cover this driver and others that were upstreamed by Beniamin.

Either option is fine from us.

As a participant of activity to put MAINTAINERS in some order, I prefer to have similar blocks be squashed.
If there will be a dedicated maintainer for a certain driver in the future, we can always split into separate sections.

Quoted 8 lines

So, something like
ANALOG DEVICES ADC (I guess it makes sense to have some grouping still)
...
F: .../ad1234
F: .../ad2345

In one section (no need to have wildcards right now).

ANALOG DEVICES INC IIO DRIVERS

M:      Lars-Peter Clausen <[email protected]>
M:      Michael Hennerich <[email protected]>
S:      Supported
W:      http://wiki.analog.com/
W:      http://ez.analog.com/community/linux-device-drivers
F:      Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
F:      Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
F:      drivers/iio/*/ad*
F:      drivers/iio/adc/ltc249*
F:      drivers/staging/iio/*/ad*
X:      drivers/iio/*/adjd*
Quoted 3 lines

Already exists. We could potentially clean that up.

For the block that started this thread, we can just drop it.

I can send a follow up to merge/remove the entries.

Best regards,
Krzysztof

#8 lore raw
Quoted 46 lines · On Wed, 2 Sep 2020 15:35:45 +0200 Krzysztof Kozlowski <[email protected]> wrote:
Quoted 44 lines · Jonathan Cameron
Quoted 18 lines · On Wed, 2 Sep 2020 10:49:04 +0300 Andy Shevchenko <[email protected]>…
Quoted 10 lines · Alexandru

[yes, I know, bad-email format, but I wanted this to come from my work email]

Apologies also for the delay here. Things pile-up on my side and I defer things a bit.

Talked to Michael Hennerich about this [since he's the more senior contact at Analog].
We can replace the email from Beniamin Bia with Michael's.
Or, we can remove the "Orphan" blocks and just have the catch-all "drivers/iio/*/ad*" cover this driver and others that were upstreamed by Beniamin.

Either option is fine from us.

As a participant of activity to put MAINTAINERS in some order, I prefer to have similar blocks be squashed.
If there will be a dedicated maintainer for a certain driver in the future, we can always split into separate sections.

Quoted 8 lines

So, something like
ANALOG DEVICES ADC (I guess it makes sense to have some grouping still)
...
F: .../ad1234
F: .../ad2345

In one section (no need to have wildcards right now).

ANALOG DEVICES INC IIO DRIVERS

M:      Lars-Peter Clausen <[email protected]>
M:      Michael Hennerich <[email protected]>
S:      Supported
W:      http://wiki.analog.com/
W:      http://ez.analog.com/community/linux-device-drivers
F:      Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
F:      Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
F:      drivers/iio/*/ad*
F:      drivers/iio/adc/ltc249*
F:      drivers/staging/iio/*/ad*
X:      drivers/iio/*/adjd*
Quoted 8 lines
Quoted 3 lines

Already exists. We could potentially clean that up.

For the block that started this thread, we can just drop it.

I can send a follow up to merge/remove the entries.

Best regards,
Krzysztof

Great thanks

Jonathan