Skip to contentSkip to conversation

arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

PATCH Applied Krzysztof Kozlowski 3 participants 3 messages Aug 28, 2020 – Aug 31, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

The PMIC node can be a clock provider (for its 32 kHz clock) and authors of imx8mq-librem5-devkit.dts apparently wanted this because they added input clock and clock-output-names.

Add necessary clock-cells to the PMIC node.

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -0
index 377591a0e6e9..40b43625f20f 100644
@@ -285,6 +285,7 @@
 		pinctrl-0 = <&pinctrl_pmic>;
 		clocks = <&pmic_osc>;
 		clock-names = "osc";
+		#clock-cells = <0>;
 		clock-output-names = "pmic_clk";
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 17 lines · Krzysztof Kozlowski

The PMIC node can be a clock provider (for its 32 kHz clock) and authors of imx8mq-librem5-devkit.dts apparently wanted this because they added input clock and clock-output-names.

Add necessary clock-cells to the PMIC node.

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +0 -0
index 377591a0e6e9..40b43625f20f 100644

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts line 291

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +1 -0
@@ -285,6 +285,7 @@
 		pinctrl-0 = <&pinctrl_pmic>;
 		clocks = <&pmic_osc>;
 		clock-names = "osc";
+		#clock-cells = <0>;
 		clock-output-names = "pmic_clk";
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 GPIO_ACTIVE_LOW>;

Hi Krzysztof,

thanks for reviewing,

martin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel