f2fs: correct statistic of APP_DIRECT_IO
PATCH 1/1 f2fs: correct statistic of APP_DIRECT_IO
Miss to update APP_DIRECT_IO when receiving async DIO. For example:
fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1
-name=fill -size=10m -numjobs=1 -iodepth=32 -rw=write
--- fs/f2fs/data.c | 6 ++++++ 1 file changed, 6 insertions(+)
fs/f2fs/data.c +6 -0
@@ -3671,12 +3671,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) err);if (!do_opu)set_inode_flag (inode,FI_UPDATE_WRITE ); + }else if (err == -EIOCBQUEUED ) { +f2fs_update_iostat (F2FS_I_SB (inode),APP_DIRECT_IO , + count -iov_iter_count (iter)); }else if (err <0 ) {f2fs_write_failed (mapping, offset + count); } }else {if (err >0 )f2fs_update_iostat (sbi,APP_DIRECT_READ_IO , err); +else if (err == -EIOCBQUEUED ) +f2fs_update_iostat (F2FS_I_SB (inode),APP_DIRECT_IO , + count -iov_iter_count (iter)); } out:
--
2.17.1
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu
maintainerQuoted 18 lines · Jack Qiu
Miss to update
APP_DIRECT_IOwhen receiving async DIO. For example:
fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1-name=fill -size=10m -numjobs=1 -iodepth=32 -rw=writeSigned-off-by Jack Qiu <[email protected]>--- fs/f2fs/data.c | 6 ++++++ 1 file changed, 6 insertions(+)fs/f2fs/data.c +1
-0@@ -3671,12 +3671,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) err);if (!do_opu)set_inode_flag (inode,FI_UPDATE_WRITE ); + }else if (err == -EIOCBQUEUED ) {
fs/f2fs/data.c static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) · line 3684
Quoted 10 lines
fs/f2fs/data.c +4
-0+f2fs_update_iostat (F2FS_I_SB (inode),APP_DIRECT_IO , + count -iov_iter_count (iter)); }else if (err <0 ) {f2fs_write_failed (mapping, offset + count); } }else {if (err >0 )f2fs_update_iostat (sbi,APP_DIRECT_READ_IO , err); +else if (err == -EIOCBQUEUED ) + f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
APP_DIRECT_READ_IO
Thanks,
Quoted 9 lines
fs/f2fs/data.c +1
-1+ count - iov_iter_count(iter)); } out: --2.17.1
Quoted 5 lines
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel