dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03
Subsystems (5)
Krzysztof Kozlowski
maintainerPATCH 1/4 dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03
The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. This fixes dtbs_check warning:
arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required property
--- .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml +11 -1
@@ -12,6 +12,17 @@ maintainers: allOf: - $ref: panel-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - samsung,s6e3ha2 + - samsung,s6e3hf2 + then: + required: + - enable-gpios + properties: compatible: enum:
@@ -39,7 +50,6 @@ required: - vdd3-supply - vci-supply - reset-gpios - - enable-gpios additionalProperties: false
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 2/4 ARM: dts: exynos: Move fixed clocks under root node in Exynos3250
The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a fake "reg" was added. This is not correct with dtschema as fixed-clock binding does not have a "reg" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
--- arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------ 1 file changed, 17 insertions(+), 25 deletions(-)
arch/arm/boot/dts/exynos3250.dtsi +17 -25
@@ -97,33 +97,25 @@ }; }; - fixed-rate-clocks { - #address-cells = <1>; - #size-cells = <0>; - - xusbxti: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - clock-frequency = <0>; - #clock-cells = <0>; - clock-output-names = "xusbxti"; - }; + xusbxti: clock-0 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xusbxti"; + }; - xxti: clock@1 { - compatible = "fixed-clock"; - reg = <1>; - clock-frequency = <0>; - #clock-cells = <0>; - clock-output-names = "xxti"; - }; + xxti: clock-1 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xxti"; + }; - xtcxo: clock@2 { - compatible = "fixed-clock"; - reg = <2>; - clock-frequency = <0>; - #clock-cells = <0>; - clock-output-names = "xtcxo"; - }; + xtcxo: clock-2 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xtcxo"; }; pmu {
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 3/4 ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
In reply to Krzysztof KozlowskiCommit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers.
This is not the place for it as CMU does not have a required "clocks" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
---
Not tested and I wonder whether actually correct. For example, what will happen if devfreq (exynos-bus) is not built in?
Could someone verify it?
--- arch/arm/boot/dts/exynos3250.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/exynos3250.dtsi +4 -4
@@ -214,10 +214,6 @@ compatible = "samsung,exynos3250-cmu"; reg = <0x10030000 0x20000>; #clock-cells = <1>; - assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, - <&cmu CLK_MOUT_ACLK_266_SUB>; - assigned-clock-parents = <&cmu CLK_FIN_PLL>, - <&cmu CLK_FIN_PLL>; }; cmu_dmc: clock-controller@105c0000 {
@@ -835,6 +831,8 @@ compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_ACLK_400_MCUISP>; clock-names = "bus"; + assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>; + assigned-clock-parents = <&cmu CLK_FIN_PLL>; operating-points-v2 = <&bus_mcuisp_opp_table>; status = "disabled"; };
@@ -843,6 +841,8 @@ compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_ACLK_266>; clock-names = "bus"; + assigned-clocks = <&cmu CLK_MOUT_ACLK_266_SUB>; + assigned-clock-parents = <&cmu CLK_FIN_PLL>; operating-points-v2 = <&bus_isp_opp_table>; status = "disabled"; };
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 4/4 ARM: dts: exynos: Remove snps,dwc2 compatible in Exynos3250
In reply to Krzysztof KozlowskiThe binding for DesignWare HS OTG USB 2.0 in Samsung SoCs take only one compatible. This fixes dtbs_check warnings like:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: hsotg@12480000:
compatible: ['samsung,s3c6400-hsotg', 'snps,dwc2'] is not valid under any of the given schemas (Possible causes of the failure):
--- arch/arm/boot/dts/exynos3250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos3250.dtsi +1 -1
@@ -350,7 +350,7 @@ }; hsotg: hsotg@12480000 { - compatible = "samsung,s3c6400-hsotg", "snps,dwc2"; + compatible = "samsung,s3c6400-hsotg"; reg = <0x12480000 0x20000>; interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cmu CLK_USBOTG>;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Krzysztof Kozlowski
The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. This fixes
dtbs_checkwarning:
arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>
I expect this patch is picked up with the dts fixes.
Sam
Quoted 36 lines
--- .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml +11
-1@@ -12,6 +12,17 @@ maintainers: allOf: - $ref: panel-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - samsung,s6e3ha2 + - samsung,s6e3hf2 + then: + required: + - enable-gpios + properties: compatible: enum:@@ -39,7 +50,6 @@ required: - vdd3-supply - vci-supply - reset-gpios - - enable-gpios additionalProperties: falseSignature · 1 line
2.17.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 9 lines · Krzysztof Kozlowski
Commit
52005dece527("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers.This is not the place for it as CMU does not have a required "clocks" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Not tested and I wonder whether actually correct. For example, what will happen if devfreq (exynos-bus) is not built in?
Could someone verify it?
Sorry, but this patch is not correct. Those clocks has noting with bus-freq. The assigned clocks property should stay where it is. Maybe one need to fix the schemas for dts verification. Those clocks has to be set (and so generic clock framework does) according to the assigned clocks properties once the clock controller is instantiated.
The only alternative would be to add exynos-subcmu variant to properly link CMU with the ISP power domain, but assuming that there is no Exynos 3250 ISP driver in mainline (and probably never will be), it is safe to keep those clocks sourced from 24MHz crystal.
Quoted 29 lines
--- arch/arm/boot/dts/exynos3250.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/exynos3250.dtsi +2
-4@@ -214,10 +214,6 @@ compatible = "samsung,exynos3250-cmu"; reg = <0x10030000 0x20000>; #clock-cells = <1>; - assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, - <&cmu CLK_MOUT_ACLK_266_SUB>; - assigned-clock-parents = <&cmu CLK_FIN_PLL>, - <&cmu CLK_FIN_PLL>; }; cmu_dmc: clock-controller@105c0000 {@@ -835,6 +831,8 @@ compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_ACLK_400_MCUISP>; clock-names = "bus"; + assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>; + assigned-clock-parents = <&cmu CLK_FIN_PLL>; operating-points-v2 = <&bus_mcuisp_opp_table>; status = "disabled"; };
arch/arm/boot/dts/exynos3250.dtsi line 848
Quoted 8 lines
arch/arm/boot/dts/exynos3250.dtsi +2
-0@@ -843,6 +841,8 @@ compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_ACLK_266>; clock-names = "bus"; + assigned-clocks = <&cmu CLK_MOUT_ACLK_266_SUB>; + assigned-clock-parents = <&cmu CLK_FIN_PLL>; operating-points-v2 = <&bus_isp_opp_table>; status = "disabled"; };
Best regards
Signature · 7 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
Quoted 27 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 9 lines · Krzysztof Kozlowski
Commit
52005dece527("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers.This is not the place for it as CMU does not have a required "clocks" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Not tested and I wonder whether actually correct. For example, what will happen if devfreq (exynos-bus) is not built in?
Could someone verify it?
Sorry, but this patch is not correct. Those clocks has noting with bus-freq. The assigned clocks property should stay where it is. Maybe one need to fix the schemas for dts verification. Those clocks has to be set (and so generic clock framework does) according to the assigned clocks properties once the clock controller is instantiated.
Quoted 4 lines
The only alternative would be to add exynos-subcmu variant to properly link CMU with the ISP power domain, but assuming that there is no Exynos 3250 ISP driver in mainline (and probably never will be), it is safe to keep those clocks sourced from 24MHz crystal.
Thanks for the clarification. Another solution to silence the warning could be to add a "clocks" property for FIN_PLL, although the driver actually does not take it.
This is the only remaining dtschema check warning on Exynos3250 so it would be nice to at least silence it. My goal is to have all them schema-correct, or as close as possible (for Exynos4 the camera node is a trouble).
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
Hi Krzysztof,
Quoted 25 lines · Krzysztof Kozlowski
Quoted 24 lines · Marek Szyprowski
Quoted 9 lines · Krzysztof Kozlowski
Commit
52005dece527("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers.This is not the place for it as CMU does not have a required "clocks" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Not tested and I wonder whether actually correct. For example, what will happen if devfreq (exynos-bus) is not built in?
Could someone verify it?
Sorry, but this patch is not correct. Those clocks has noting with bus-freq. The assigned clocks property should stay where it is. Maybe one need to fix the schemas for dts verification. Those clocks has to be set (and so generic clock framework does) according to the assigned clocks properties once the clock controller is instantiated.
Quoted 7 lines
Quoted 4 lines
The only alternative would be to add exynos-subcmu variant to properly link CMU with the ISP power domain, but assuming that there is no Exynos 3250 ISP driver in mainline (and probably never will be), it is safe to keep those clocks sourced from 24MHz crystal.
Thanks for the clarification. Another solution to silence the warning could be to add a "clocks" property for
FIN_PLL, although the driver actually does not take it.
Okay, that would be fine. It would make dts match better the hardware and this would even help generic clock framework to always instantiate CMU after the oscilator fixed-clock (there have been some hacks there at some point for that...)
Best regards
Signature · 7 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250
In reply to Krzysztof KozlowskiQuoted 33 lines · Krzysztof Kozlowski
Quoted 27 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 9 lines · Krzysztof Kozlowski
Commit
52005dece527("ARM: dts: Add assigned clock parents to CMU node for exynos3250") added assigned clocks under Clock Management Unit to fix hangs when accessing ISP registers.This is not the place for it as CMU does not have a required "clocks" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Not tested and I wonder whether actually correct. For example, what will happen if devfreq (exynos-bus) is not built in?
Could someone verify it?
Sorry, but this patch is not correct. Those clocks has noting with bus-freq. The assigned clocks property should stay where it is. Maybe one need to fix the schemas for dts verification. Those clocks has to be set (and so generic clock framework does) according to the assigned clocks properties once the clock controller is instantiated.
Quoted 4 lines
The only alternative would be to add exynos-subcmu variant to properly link CMU with the ISP power domain, but assuming that there is no Exynos 3250 ISP driver in mainline (and probably never will be), it is safe to keep those clocks sourced from 24MHz crystal.
Quoted 8 lines
Thanks for the clarification. Another solution to silence the warning could be to add a "clocks" property for
FIN_PLL, although the driver actually does not take it.This is the only remaining dtschema check warning on Exynos3250 so it would be nice to at least silence it. My goal is to have all them schema-correct, or as close as possible (for Exynos4 the camera node is a trouble).
BTW, if you have some time, it would be awesome if you could test all the series (on Exynos3250 obviously with this patch reverted):
https://github.com/krzk/linux/tree/for-next/dts-exynos-schema-cleanups
The Exynos5 cleanup is ongoing, so there will be more patches. But Exynos3 and Exynos4 I finished.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250
In reply to Krzysztof KozlowskiQuoted 7 lines · Krzysztof Kozlowski
The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a fake "reg" was added. This is not correct with dtschema as fixed-clock binding does not have a "reg" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 49 lines
--- arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------ 1 file changed, 17 insertions(+), 25 deletions(-)arch/arm/boot/dts/exynos3250.dtsi +12
-23@@ -97,33 +97,25 @@ }; }; - fixed-rate-clocks { - #address-cells = <1>; - #size-cells = <0>; - - xusbxti: clock@0 { - compatible = "fixed-clock"; - reg = <0>; - clock-frequency = <0>; - #clock-cells = <0>; - clock-output-names = "xusbxti"; - }; + xusbxti: clock-0 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xusbxti"; + }; - xxti: clock@1 { - compatible = "fixed-clock"; - reg = <1>; - clock-frequency = <0>; - #clock-cells = <0>; - clock-output-names = "xxti"; - }; + xxti: clock-1 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xxti"; + }; - xtcxo: clock@2 { - compatible = "fixed-clock"; - reg = <2>; - clock-frequency = <0>; - #clock-cells = <0>;
arch/arm/boot/dts/exynos3250.dtsi line 121
Quoted 10 lines
arch/arm/boot/dts/exynos3250.dtsi +5
-2- clock-output-names = "xtcxo"; - }; + xtcxo: clock-2 { + compatible = "fixed-clock"; + clock-frequency = <0>; + #clock-cells = <0>; + clock-output-names = "xtcxo"; }; pmu {
Best regards
Signature · 7 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a fake "reg" was added. This is not correct with dtschema as fixed-clock binding does not have a "reg" property:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------ 1 file changed, 17 insertions(+), 25 deletions(-)
Applied.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/4] ARM: dts: exynos: Remove snps,dwc2 compatible in Exynos3250
In reply to Krzysztof KozlowskiQuoted 9 lines · Krzysztof Kozlowski
The binding for DesignWare HS OTG USB 2.0 in Samsung SoCs take only one compatible. This fixes
dtbs_checkwarnings like:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: hsotg@12480000:
compatible: ['samsung,s3c6400-hsotg', 'snps,dwc2'] is not valid under any of the given schemas (Possible causes of the failure):Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos3250.dtsi | 2 +-
Applied.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerRe: [PATCH 1/4] dt-bindings: display: samsung, amoled-mipi-dsi: Do not require enable-gpios on samsung, s6e63j0x03
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
The samsung,s6e63j0x03 does not have enable GPIO, so do not require it. This fixes
dtbs_checkwarning:
arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>--- .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
Applied, thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel