iomap: Fix WARN_ON_ONCE() from unprivileged users
Subsystems (2)
PATCH v3 1/1 iomap: Fix WARN_ON_ONCE() from unprivileged users
It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by unprivileged users which would taint the kernel, or worse - panic if panic_on_warn or panic_on_taint is set. Hence, just convert it to pr_warn_ratelimited() to let users know their workloads are racing. Thank Dave Chinner for the initial analysis of the racing reproducers.
---
v3: Keep the default case and update the message.
v2: Record the path, pid and command as well.
fs/iomap/direct-io.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
fs/iomap/direct-io.c +16 -0
@@ -374,6 +374,7 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, void *data, struct iomap *iomap, struct iomap *srcmap) { struct iomap_dio *dio = data; +char pathname[128 ], *path;switch (iomap->type) {case IOMAP_HOLE :
@@ -388,6 +389,21 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,return iomap_dio_bio_actor (inode, pos, length, dio, iomap);case IOMAP_INLINE :return iomap_dio_inline_actor (inode, pos, length, dio, iomap); +case IOMAP_DELALLOC : +/* +* DIO is not serialised against mmap() access at all, and so +* if the page_mkwrite occurs between the writeback and the +* iomap_apply() call in the DIO path, then it will see the +* DELALLOC block that the page-mkwrite allocated. +*/ + path =file_path (dio->iocb->ki_filp, pathname, +sizeof (pathname)); +if (IS_ERR (path)) + path ="(unknown)" ; + +pr_warn_ratelimited ("Direct I/O collision with buffered writes! File: %s Comm: %.20s\n" , + path, current->comm); +return -EIO ;default :WARN_ON_ONCE (1 );return -EIO ;
Signature · 1 line
2.18.4
Quoted 7 lines · Qian Cai
It is trivial to trigger a
WARN_ON_ONCE(1)iniomap_dio_actor()by unprivileged users which would taint the kernel, or worse - panic ifpanic_on_warnorpanic_on_taintis set. Hence, just convert it topr_warn_ratelimited()to let users know their workloads are racing. Thank Dave Chinner for the initial analysis of the racing reproducers.Signed-off-by Qian Cai <[email protected]>
Looks good,
Quoted 4 lines · Qian Cai
fs/iomap/direct-io.c +4
-0+case IOMAP_DELALLOC : +/* +* DIO is not serialised against mmap() access at all, and so +* if the page_mkwrite occurs between the writeback and the
fs/iomap/direct-io.c iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, · line 405
Quoted 10 lines
fs/iomap/direct-io.c +10
-0+* iomap_apply() call in the DIO path, then it will see the +* DELALLOC block that the page-mkwrite allocated. +*/ + path =file_path (dio->iocb->ki_filp, pathname, +sizeof (pathname)); +if (IS_ERR (path)) + path ="(unknown)" ; + +pr_warn_ratelimited ("Direct I/O collision with buffered writes! File: %s Comm: %.20s\n" , + path, current->comm);
"File: %pD4"?
Quoted 17 lines · Matthew Wilcox
Quoted 4 lines · Qian Cai
fs/iomap/direct-io.c +4
-0+case IOMAP_DELALLOC : +/* +* DIO is not serialised against mmap() access at all, and so +* if the page_mkwrite occurs between the writeback and the fs/iomap/direct-io.c iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, · line 405
Quoted 10 lines
fs/iomap/direct-io.c +10
-0+* iomap_apply() call in the DIO path, then it will see the +* DELALLOC block that the page-mkwrite allocated. +*/ + path =file_path (dio->iocb->ki_filp, pathname, +sizeof (pathname)); +if (IS_ERR (path)) + path ="(unknown)" ; + +pr_warn_ratelimited ("Direct I/O collision with buffered writes! File: %s Comm: %.20s\n" , + path, current->comm);"File: %pD4"?
Sounds like a good idea. I could use that.