tests/i915/gem_basic: Added test description for test case

PATCH In review [email protected] 3 participants 4 messages Sep 1, 2020 – Nov 12, 2020

lore

Share & tools

lore

[email protected]

author

2020-09-01 03:56 UTC #0 lore raw

PATCH 1/1 tests/i915/gem_basic: Added test description for test case

From: sai gowtham <[email protected]>

Added test description for test and to all the available subtests.

Cc Melkaveri, Arjun <[email protected]>

Signed-off-by sai gowtham <[email protected]>

---
 tests/i915/gem_basic.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

tests/i915/gem_basic.c +4 -5

index 9f7412f2..2f76ee26 100644
@@ -37,14 +37,13 @@
 #include <sys/ioctl.h>
 #include "drm.h"
 
+IGT_TEST_DESCRIPTION("Tests basic gem_create and gem_close IOCTLs");
 static void
 test_bad_close(int fd)
 {
 	struct drm_gem_close close_bo;
 	int ret;
 
-	igt_info("Testing error return on bad close ioctl.\n");
-
 	close_bo.handle = 0x10101010;
 	ret = ioctl(fd, DRM_IOCTL_GEM_CLOSE, &close_bo);

@@ -56,8 +55,6 @@ test_create_close(int fd)
 {
 	uint32_t handle;
 
-	igt_info("Testing creating and closing an object.\n");
-
 	handle = gem_create(fd, 16*1024);
 
 	gem_close(fd, handle);

@@ -66,7 +63,6 @@ test_create_close(int fd)
 static void
 test_create_fd_close(int fd)
 {
-	igt_info("Testing closing with an object allocated.\n");
 
 	gem_create(fd, 16*1024);
 	/* leak it */

@@ -81,10 +77,13 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
+	igt_describe("Testing error return on bad close ioctl.\n");
 	igt_subtest("bad-close")
 		test_bad_close(fd);
+	igt_describe("Testing creating and closing an object.\n");
 	igt_subtest("create-close")
 		test_create_close(fd);
+	igt_describe("Testing closing with an object allocated.\n");
 	igt_subtest("create-fd-close")
 		test_create_fd_close(fd);
 }

Signature · 6 lines

2.25.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-09-01 04:27 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_basic: Added test description for test case

== Series Details ==

Series: tests/i915/gem_basic: Added test description for test case
URL : https://patchwork.freedesktop.org/series/81205/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8948 -> IGTPW_4932
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/index.html

Known issues
------------

Here are the changes found in IGTPW_4932 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-byt-j1900/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-bsw-kefka/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-bsw-kefka/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-icl-y: [PASS][5] -> [INCOMPLETE][6] ([i915#2276])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-icl-y/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-icl-y/igt@i915_selftest@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@c-dp2:
- fi-skl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#2203]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-skl-guc/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-skl-guc/igt@kms_flip@[email protected]

#### Possible fixes ####

* igt@gem_exec_store@basic:
- fi-apl-guc: [TIMEOUT][9] ([i915#1635]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-apl-guc/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-apl-guc/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- {fi-kbl-7560u}: [WARN][11] ([i915#2249]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-kbl-7560u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-kbl-7560u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-byt-j1900/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-byt-j1900/igt@[email protected]
- {fi-kbl-7560u}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/fi-kbl-7560u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/fi-kbl-7560u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2249]: https://gitlab.freedesktop.org/drm/intel/issues/2249
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276

Participating hosts (38 -> 33)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5774 -> IGTPW_4932

CI-20190529: 20190529
CI_DRM_8948: 4a551ee5aa0f402a647f797437b69af12ce78642 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4932: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/index.html
IGT_5774: 2a5db9f60241383272aeec176e1b97b3f487209f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-09-01 11:52 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_basic: Added test description for test case

In reply to [email protected]

== Series Details ==

Series: tests/i915/gem_basic: Added test description for test case
URL : https://patchwork.freedesktop.org/series/81205/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8948_full -> IGTPW_4932_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/index.html

Known issues
------------

Here are the changes found in IGTPW_4932_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_reloc@basic-concurrent0:
- shard-tglb: [PASS][1] -> [TIMEOUT][2] ([i915#1958]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-tglb3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-tglb1/igt@[email protected]
- shard-glk: [PASS][3] -> [TIMEOUT][4] ([i915#1958]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk1/igt@[email protected]
- shard-apl: [PASS][5] -> [TIMEOUT][6] ([i915#1635] / [i915#1958]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-apl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-apl2/igt@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-kbl: [PASS][7] -> [TIMEOUT][8] ([i915#1958])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl4/igt@[email protected]
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#1635] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-apl3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-apl4/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-snb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-snb4/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-hsw1/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-hsw6/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#49])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk7/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_setmode@basic:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#31])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl4/igt@[email protected]

* igt@kms_vblank@pipe-a-query-forked-busy:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-tglb3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-tglb1/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +9 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl1/igt@[email protected]

* igt@kms_vblank@pipe-b-wait-idle-hang:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#1635] / [i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-apl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-apl6/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_gttfill@basic:
- shard-glk: [DMESG-WARN][31] ([i915#118] / [i915#95]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk6/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl7/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-kbl: [TIMEOUT][35] ([i915#1958]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl4/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-priority:
- shard-tglb: [TIMEOUT][37] ([i915#1958]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-tglb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-tglb2/igt@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-glk: [TIMEOUT][39] ([i915#1958]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk4/igt@[email protected]

* igt@gem_mmap_gtt@zero-extend:
- shard-hsw: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-hsw6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-hsw1/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [INCOMPLETE][43] ([i915#155] / [i915#794]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
- shard-kbl: [FAIL][45] ([i915#54]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][47] ([i915#1635] / [i915#54]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-apl8/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-apl3/igt@[email protected]
- shard-glk: [FAIL][49] ([i915#54]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
- shard-apl: [DMESG-WARN][51] ([i915#1635] / [i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-apl7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-apl8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-kbl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl1/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [INCOMPLETE][55] ([i915#155]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-kbl4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-kbl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-glk: [FAIL][57] ([i915#1036]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk2/igt@[email protected]

* igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
- shard-iclb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-iclb3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-iclb4/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-iclb3/igt@kms_psr@psr2_basic.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-iclb2/igt@kms_psr@psr2_basic.html

* igt@kms_setmode@basic:
- shard-glk: [FAIL][63] ([i915#31]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-glk6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-glk1/igt@[email protected]

* igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- shard-tglb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8948/shard-tglb7/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/shard-tglb1/igt@[email protected]

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5774 -> IGTPW_4932
* Piglit: piglit_4509 -> None

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4932/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Katarzyna Dec

2020-11-12 13:59 UTC #3 lore raw

In reply to [email protected]

Quoted 15 lines · On Tue, Sep 01, 2020 at 09:26:14AM +0530, [email protected] wrote:

From: sai gowtham <[email protected]>
Added test description for test and to all the available subtests.
Cc Melkaveri, Arjun <[email protected]>
Signed-off-by sai gowtham <[email protected]>
---
 tests/i915/gem_basic.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
tests/i915/gem_basic.c +0 -0
index 9f7412f2..2f76ee26 100644

tests/i915/gem_basic.c line 40

Quoted 4 lines

tests/i915/gem_basic.c +1 -0

@@ -37,14 +37,13 @@
 #include <sys/ioctl.h>
 #include "drm.h"
 
+IGT_TEST_DESCRIPTION("Tests basic gem_create and gem_close IOCTLs");

Let's have one empty line before function - decription is for whole test binary.

tests/i915/gem_basic.c line 46

Quoted 7 lines

tests/i915/gem_basic.c +0 -1

 static void
 test_bad_close(int fd)
 {
 	struct drm_gem_close close_bo;
 	int ret;
 
-	igt_info("Testing error return on bad close ioctl.\n");

I would leave igt_info here - it is giving info during running test.

Quoted 22 lines

tests/i915/gem_basic.c +0 -4

-
 	close_bo.handle = 0x10101010;
 	ret = ioctl(fd, DRM_IOCTL_GEM_CLOSE, &close_bo);

@@ -56,8 +55,6 @@ test_create_close(int fd)
 {
 	uint32_t handle;
 
-	igt_info("Testing creating and closing an object.\n");
-
 	handle = gem_create(fd, 16*1024);
 
 	gem_close(fd, handle);

@@ -66,7 +63,6 @@ test_create_close(int fd)
 static void
 test_create_fd_close(int fd)
 {
-	igt_info("Testing closing with an object allocated.\n");
 
 	gem_create(fd, 16*1024);
 	/* leak it */

tests/i915/gem_basic.c igt_main · line 80

Quoted 4 lines

tests/i915/gem_basic.c +1 -0

@@ -81,10 +77,13 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
+	igt_describe("Testing error return on bad close ioctl.\n");

In my opinon coping igt_info as igt_description is not helping here. THis subtest is more about:
igt_describe("Check error on DRM_IOCTL_GEM_CLOSE, category=Gem, category=SW_only");

tests/i915/gem_basic.c igt_main · line 82

Quoted 2 lines

tests/i915/gem_basic.c +0 -0

 	igt_subtest("bad-close")
 		test_bad_close(fd);

Let's divide subtests with empty line for better readability.

tests/i915/gem_basic.c igt_main · line 83

Quoted 1 line

tests/i915/gem_basic.c +1 -0

+	igt_describe("Testing creating and closing an object.\n");

Change descriptions in 2 other functions similarly.

Kasia :)

Quoted 13 lines

tests/i915/gem_basic.c +1 -0

 	igt_subtest("create-close")
 		test_create_close(fd);
+	igt_describe("Testing closing with an object allocated.\n");
 	igt_subtest("create-fd-close")
 		test_create_fd_close(fd);
 }

Signature · 6 lines

2.25.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev