Skip to contentSkip to conversation

xen/balloon: fixes for memory hotplug

PATCH Applied Roger Pau Monne 5 participants 15 messages Sep 1, 2020 – Sep 24, 2020

Subsystems (8)
lore
Share & tools
lore
#0 lore raw

v5 cover xen/balloon: fixes for memory hotplug

Hello,

The following series contain some fixes in order to split Xen unpopulated memory handling from the ballooning driver using the ZONE_DEVICE functionality, so that physical memory regions used to map foreign pages are not tied to memory hotplug.

Note this is currently only available for x86 due to Arm using an identity map for dom0 p2m and thus needing special handling.

Thanks, Roger.

Roger Pau Monne (3):
xen/balloon: add header guard
memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC
xen: add helpers to allocate unpopulated memory

 drivers/dax/device.c                    |   2 +-
 drivers/gpu/drm/xen/xen_drm_front_gem.c |   9 +-
 drivers/xen/Kconfig                     |  11 ++
 drivers/xen/Makefile                    |   1 +
 drivers/xen/balloon.c                   |   4 +-
 drivers/xen/grant-table.c               |   4 +-
 drivers/xen/privcmd.c                   |   4 +-
 drivers/xen/unpopulated-alloc.c         | 185 ++++++++++++++++++++++++
 drivers/xen/xenbus/xenbus_client.c      |   6 +-
 drivers/xen/xlate_mmu.c                 |   4 +-
 include/linux/memremap.h                |   9 +-
 include/xen/balloon.h                   |   4 +
 include/xen/xen.h                       |   9 ++
 mm/memremap.c                           |   2 +-
 14 files changed, 232 insertions(+), 22 deletions(-)
 create mode 100644 drivers/xen/unpopulated-alloc.c
Signature · 1 line
2.28.0
#1 lore raw

PATCH v5 1/3 xen/balloon: add header guard

In order to protect against the header being included multiple times on the same compilation unit.

---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: [email protected]
---
This is required as a pre-patch to use ZONE_DEVICE, or else the fallback of including the balloon header might not work properly.

---
 include/xen/balloon.h | 4 ++++
 1 file changed, 4 insertions(+)
include/xen/balloon.h +4 -0
index 6fb95aa19405..6dbdb0b3fd03 100644
@@ -2,6 +2,8 @@
 /******************************************************************************
  * Xen balloon functionality
  */
+#ifndef _XEN_BALLOON_H
+#define _XEN_BALLOON_H
 
 #define RETRY_UNLIMITED	0
 
@@ -34,3 +36,5 @@ static inline void xen_balloon_init(void)
 {
 }
 #endif
+
+#endif	/* _XEN_BALLOON_H */
Signature · 1 line
2.28.0
#2 lore raw

PATCH v5 2/3 memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

In reply to Roger Pau Monne

This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices.

No functional change intended.

---
Cc: Dan Williams <[email protected]>
Cc: Vishal Verma <[email protected]>
Cc: Dave Jiang <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: Ira Weiny <[email protected]>
Cc: "Aneesh Kumar K.V" <[email protected]>
Cc: Johannes Thumshirn <[email protected]>
Cc: Logan Gunthorpe <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 drivers/dax/device.c     | 2 +-
 include/linux/memremap.h | 9 ++++-----
 mm/memremap.c            | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)
drivers/dax/device.c +1 -1
index 4c0af2eb7e19..1e89513f3c59 100644
@@ -429,7 +429,7 @@ int dev_dax_probe(struct device *dev)
 		return -EBUSY;
 	}
 
-	dev_dax->pgmap.type = MEMORY_DEVICE_DEVDAX;
+	dev_dax->pgmap.type = MEMORY_DEVICE_GENERIC;
 	addr = devm_memremap_pages(dev, &dev_dax->pgmap);
 	if (IS_ERR(addr))
 		return PTR_ERR(addr);
include/linux/memremap.h +4 -5
index 5f5b2df06e61..e5862746751b 100644
@@ -46,11 +46,10 @@ struct vmem_altmap {
  * wakeup is used to coordinate physical address space management (ex:
  * fs truncate/hole punch) vs pinned pages (ex: device dma).
  *
- * MEMORY_DEVICE_DEVDAX:
+ * MEMORY_DEVICE_GENERIC:
  * Host memory that has similar access semantics as System RAM i.e. DMA
- * coherent and supports page pinning. In contrast to
- * MEMORY_DEVICE_FS_DAX, this memory is access via a device-dax
- * character device.
+ * coherent and supports page pinning. This is for example used by DAX devices
+ * that expose memory using a character device.
  *
  * MEMORY_DEVICE_PCI_P2PDMA:
  * Device memory residing in a PCI BAR intended for use with Peer-to-Peer
@@ -60,7 +59,7 @@ enum memory_type {
 	/* 0 is reserved to catch uninitialized type fields */
 	MEMORY_DEVICE_PRIVATE = 1,
 	MEMORY_DEVICE_FS_DAX,
-	MEMORY_DEVICE_DEVDAX,
+	MEMORY_DEVICE_GENERIC,
 	MEMORY_DEVICE_PCI_P2PDMA,
 };
 
mm/memremap.c +1 -1
index 03e38b7a38f1..006dace60b1a 100644
@@ -216,7 +216,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
 			return ERR_PTR(-EINVAL);
 		}
 		break;
-	case MEMORY_DEVICE_DEVDAX:
+	case MEMORY_DEVICE_GENERIC:
 		need_devmap_managed = false;
 		break;
 	case MEMORY_DEVICE_PCI_P2PDMA:
Signature · 1 line
2.28.0
Reviewed-by on v5 2/3
#3 lore raw

Re: [PATCH v5 2/3] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

Quoted 74 lines

This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices.

No functional change intended.

---
Cc: Dan Williams <[email protected]>
Cc: Vishal Verma <[email protected]>
Cc: Dave Jiang <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: Ira Weiny <[email protected]>
Cc: "Aneesh Kumar K.V" <[email protected]>
Cc: Johannes Thumshirn <[email protected]>
Cc: Logan Gunthorpe <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 drivers/dax/device.c     | 2 +-
 include/linux/memremap.h | 9 ++++-----
 mm/memremap.c            | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)
drivers/dax/device.c +1 -1
index 4c0af2eb7e19..1e89513f3c59 100644
@@ -429,7 +429,7 @@ int dev_dax_probe(struct device *dev)
                return -EBUSY;
        }
 
-       dev_dax->pgmap.type = MEMORY_DEVICE_DEVDAX;
+       dev_dax->pgmap.type = MEMORY_DEVICE_GENERIC;
        addr = devm_memremap_pages(dev, &dev_dax->pgmap);
        if (IS_ERR(addr))
                return PTR_ERR(addr);
include/linux/memremap.h +4 -5
index 5f5b2df06e61..e5862746751b 100644
@@ -46,11 +46,10 @@ struct vmem_altmap {
  * wakeup is used to coordinate physical address space management (ex:
  * fs truncate/hole punch) vs pinned pages (ex: device dma).
  *
- * MEMORY_DEVICE_DEVDAX:
+ * MEMORY_DEVICE_GENERIC:
  * Host memory that has similar access semantics as System RAM i.e. DMA
- * coherent and supports page pinning. In contrast to
- * MEMORY_DEVICE_FS_DAX, this memory is access via a device-dax
- * character device.
+ * coherent and supports page pinning. This is for example used by DAX devices
+ * that expose memory using a character device.
  *
  * MEMORY_DEVICE_PCI_P2PDMA:
  * Device memory residing in a PCI BAR intended for use with Peer-to-Peer
@@ -60,7 +59,7 @@ enum memory_type {
        /* 0 is reserved to catch uninitialized type fields */
        MEMORY_DEVICE_PRIVATE = 1,
        MEMORY_DEVICE_FS_DAX,
-       MEMORY_DEVICE_DEVDAX,
+       MEMORY_DEVICE_GENERIC,
        MEMORY_DEVICE_PCI_P2PDMA,
 };
 
mm/memremap.c +0 -0
index 03e38b7a38f1..006dace60b1a 100644

mm/memremap.c void *memremap_pages(struct dev_pagemap *pgmap, int nid) · line 222

Quoted 8 lines
mm/memremap.c +1 -1
@@ -216,7 +216,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
                        return ERR_PTR(-EINVAL);
                }
                break;
-       case MEMORY_DEVICE_DEVDAX:
+       case MEMORY_DEVICE_GENERIC:
                need_devmap_managed = false;
                break;
        case MEMORY_DEVICE_PCI_P2PDMA:
#4 lore raw

Re: [PATCH v5 2/3] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

In reply to Roger Pau Monne
Quoted 4 lines · Roger Pau Monne

This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices.

FWIW I would not call this MEMORY_DEVICE_GENERIC. This is really MEMORY_DEVICE_SIMPLE and the kernel-doc can clarify in contrast to the other MEMORY_DEVICE types this type implies no need for driver or filesystem notification when a page goes idle.

#5 lore raw

PATCH v5 3/3 xen: add helpers to allocate unpopulated memory

In reply to Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

---
Cc: Oleksandr Andrushchenko <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Dan Carpenter <[email protected]>
Cc: Roger Pau Monne <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Yan Yankovskyi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: David Hildenbrand <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Dan Williams <[email protected]>
---
Changes since v4:
- Introduce a description for the option.
- Force selection of ZONE_DEVICE on X86 and select XEN_UNPOPULATED_ALLOC if running on dom0 mode or having any backends.

Changes since v3:
- Introduce a Kconfig option that gates the addition of the unpopulated alloc driver. This allows to easily disable it on Arm platforms.
- Dropped Juergen RB due to the addition of the Kconfig option.
- Switched from MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC.

Changes since v2:
- Drop BUILD_BUG_ON regarding PVMMU page sizes.
- Use a SPDX license identifier.
- Call fill with only the minimum required number of pages.
- Include xen.h header in xen_drm_front_gem.c.
- Use less generic function names.
- Exit early from the init function if not a PV guest.
- Don't use all caps for region name.

---
 drivers/gpu/drm/xen/xen_drm_front_gem.c |   9 +-
 drivers/xen/Kconfig                     |  11 ++
 drivers/xen/Makefile                    |   1 +
 drivers/xen/balloon.c                   |   4 +-
 drivers/xen/grant-table.c               |   4 +-
 drivers/xen/privcmd.c                   |   4 +-
 drivers/xen/unpopulated-alloc.c         | 185 ++++++++++++++++++++++++
 drivers/xen/xenbus/xenbus_client.c      |   6 +-
 drivers/xen/xlate_mmu.c                 |   4 +-
 include/xen/xen.h                       |   9 ++
 10 files changed, 222 insertions(+), 15 deletions(-)
 create mode 100644 drivers/xen/unpopulated-alloc.c
drivers/gpu/drm/xen/xen_drm_front_gem.c +5 -4
index 39ff95b75357..534daf37c97e 100644
@@ -18,6 +18,7 @@
 #include <drm/drm_probe_helper.h>
 
 #include <xen/balloon.h>
+#include <xen/xen.h>
 
 #include "xen_drm_front.h"
 #include "xen_drm_front_gem.h"
@@ -99,8 +100,8 @@ static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size)
 		 * allocate ballooned pages which will be used to map
 		 * grant references provided by the backend
 		 */
-		ret = alloc_xenballooned_pages(xen_obj->num_pages,
-					       xen_obj->pages);
+		ret = xen_alloc_unpopulated_pages(xen_obj->num_pages,
+					          xen_obj->pages);
 		if (ret < 0) {
 			DRM_ERROR("Cannot allocate %zu ballooned pages: %d\n",
 				  xen_obj->num_pages, ret);
@@ -152,8 +153,8 @@ void xen_drm_front_gem_free_object_unlocked(struct drm_gem_object *gem_obj)
 	} else {
 		if (xen_obj->pages) {
 			if (xen_obj->be_alloc) {
-				free_xenballooned_pages(xen_obj->num_pages,
-							xen_obj->pages);
+				xen_free_unpopulated_pages(xen_obj->num_pages,
+							   xen_obj->pages);
 				gem_free_pages_array(xen_obj);
 			} else {
 				drm_gem_put_pages(&xen_obj->base,
drivers/xen/Kconfig +11 -0
index ea6c1e7e3e42..e38c33558d0d 100644
@@ -325,4 +325,15 @@ config XEN_HAVE_VPMU
 config XEN_FRONT_PGDIR_SHBUF
 	tristate
 
+config XEN_UNPOPULATED_ALLOC
+	bool "Use unpopulated memory ranges for guest mappings"
+	depends on X86
+	select ZONE_DEVICE
+	default XEN_BACKEND || XEN_GNTDEV || XEN_DOM0
+	help
+	  Use unpopulated memory ranges in order to create mappings for guest
+	  memory regions, including grant maps and foreign pages. This avoids
+	  having to balloon out RAM regions in order to obtain physical memory
+	  space to create such mappings.
+
 endmenu
drivers/xen/Makefile +1 -0
index c25c9a699b48..babdca808861 100644
@@ -41,3 +41,4 @@ xen-gntdev-$(CONFIG_XEN_GNTDEV_DMABUF)	+= gntdev-dmabuf.o
 xen-gntalloc-y				:= gntalloc.o
 xen-privcmd-y				:= privcmd.o privcmd-buf.o
 obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)	+= xen-front-pgdir-shbuf.o
+obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)	+= unpopulated-alloc.o
drivers/xen/balloon.c +2 -2
index 37ffccda8bb8..51427c752b37 100644
@@ -653,7 +653,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
 }
 EXPORT_SYMBOL(free_xenballooned_pages);
 
-#ifdef CONFIG_XEN_PV
+#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
 static void __init balloon_add_region(unsigned long start_pfn,
 				      unsigned long pages)
 {
@@ -707,7 +707,7 @@ static int __init balloon_init(void)
 	register_sysctl_table(xen_root);
 #endif
 
-#ifdef CONFIG_XEN_PV
+#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
 	{
 		int i;
 
drivers/xen/grant-table.c +2 -2
index 8d06bf1cc347..523dcdf39cc9 100644
@@ -801,7 +801,7 @@ int gnttab_alloc_pages(int nr_pages, struct page **pages)
 {
 	int ret;
 
-	ret = alloc_xenballooned_pages(nr_pages, pages);
+	ret = xen_alloc_unpopulated_pages(nr_pages, pages);
 	if (ret < 0)
 		return ret;
 
@@ -836,7 +836,7 @@ EXPORT_SYMBOL_GPL(gnttab_pages_clear_private);
 void gnttab_free_pages(int nr_pages, struct page **pages)
 {
 	gnttab_pages_clear_private(nr_pages, pages);
-	free_xenballooned_pages(nr_pages, pages);
+	xen_free_unpopulated_pages(nr_pages, pages);
 }
 EXPORT_SYMBOL_GPL(gnttab_free_pages);
 
drivers/xen/privcmd.c +2 -2
index 63abe6c3642b..b0c73c58f987 100644
@@ -424,7 +424,7 @@ static int alloc_empty_pages(struct vm_area_struct *vma, int numpgs)
 	if (pages == NULL)
 		return -ENOMEM;
 
-	rc = alloc_xenballooned_pages(numpgs, pages);
+	rc = xen_alloc_unpopulated_pages(numpgs, pages);
 	if (rc != 0) {
 		pr_warn("%s Could not alloc %d pfns rc:%d\n", __func__,
 			numpgs, rc);
@@ -895,7 +895,7 @@ static void privcmd_close(struct vm_area_struct *vma)
 
 	rc = xen_unmap_domain_gfn_range(vma, numgfns, pages);
 	if (rc == 0)
-		free_xenballooned_pages(numpgs, pages);
+		xen_free_unpopulated_pages(numpgs, pages);
 	else
 		pr_crit("unable to unmap MFN range: leaking %d pages. rc=%d\n",
 			numpgs, rc);
drivers/xen/unpopulated-alloc.c new file +185 -0

185 lines not on this page · raw message

drivers/xen/xenbus/xenbus_client.c +3 -3
index 907bcbb93afb..2690318ad50f 100644
@@ -621,7 +621,7 @@ static int xenbus_map_ring_hvm(struct xenbus_device *dev,
 	bool leaked = false;
 	unsigned int nr_pages = XENBUS_PAGES(nr_grefs);
 
-	err = alloc_xenballooned_pages(nr_pages, node->hvm.pages);
+	err = xen_alloc_unpopulated_pages(nr_pages, node->hvm.pages);
 	if (err)
 		goto out_err;
 
@@ -662,7 +662,7 @@ static int xenbus_map_ring_hvm(struct xenbus_device *dev,
 			 addr, nr_pages);
  out_free_ballooned_pages:
 	if (!leaked)
-		free_xenballooned_pages(nr_pages, node->hvm.pages);
+		xen_free_unpopulated_pages(nr_pages, node->hvm.pages);
  out_err:
 	return err;
 }
@@ -858,7 +858,7 @@ static int xenbus_unmap_ring_hvm(struct xenbus_device *dev, void *vaddr)
 			       info.addrs);
 	if (!rv) {
 		vunmap(vaddr);
-		free_xenballooned_pages(nr_pages, node->hvm.pages);
+		xen_free_unpopulated_pages(nr_pages, node->hvm.pages);
 	}
 	else
 		WARN(1, "Leaking %p, size %u page(s)\n", vaddr, nr_pages);
drivers/xen/xlate_mmu.c +2 -2
index 7b1077f0abcb..34742c6e189e 100644
@@ -232,7 +232,7 @@ int __init xen_xlate_map_ballooned_pages(xen_pfn_t **gfns, void **virt,
 		kfree(pages);
 		return -ENOMEM;
 	}
-	rc = alloc_xenballooned_pages(nr_pages, pages);
+	rc = xen_alloc_unpopulated_pages(nr_pages, pages);
 	if (rc) {
 		pr_warn("%s Couldn't balloon alloc %ld pages rc:%d\n", __func__,
 			nr_pages, rc);
@@ -249,7 +249,7 @@ int __init xen_xlate_map_ballooned_pages(xen_pfn_t **gfns, void **virt,
 	if (!vaddr) {
 		pr_warn("%s Couldn't map %ld pages rc:%d\n", __func__,
 			nr_pages, rc);
-		free_xenballooned_pages(nr_pages, pages);
+		xen_free_unpopulated_pages(nr_pages, pages);
 		kfree(pages);
 		kfree(pfns);
 		return -ENOMEM;
include/xen/xen.h +9 -0
index 19a72f591e2b..43efba045acc 100644
@@ -52,4 +52,13 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
 extern u64 xen_saved_max_mem_size;
 #endif
 
+#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
+int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
+void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
+#else
+#define xen_alloc_unpopulated_pages alloc_xenballooned_pages
+#define xen_free_unpopulated_pages free_xenballooned_pages
+#include <xen/balloon.h>
+#endif
+
 #endif	/* _XEN_XEN_H */
Signature · 1 line
2.28.0
#6 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Thank you for the patch! Yet something to improve:

Hi Roger,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on linux/master hnaz-linux-mm/master linus/master v5.9-rc3] [cannot apply to next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Roger-Pau-Monne/xen-balloon-fixes-for-memory-hotplug/20200901-163414
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: x86_64-randconfig-a011-20200901 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c10e63677f5d20f18010f8f68c631ddc97546f7d)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> drivers/xen/unpopulated-alloc.c:42:8: error: implicit declaration of function 'memory_add_physaddr_to_nid' [-Werror,-Wimplicit-function-declaration]
           nid = memory_add_physaddr_to_nid(pgmap->res.start);
                 ^

1 error generated.

# https://github.com/0day-ci/linux/commit/b66f7f6a65710bd99d21d22f52fa5bc46636d425
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Roger-Pau-Monne/xen-balloon-fixes-for-memory-hotplug/20200901-163414 git checkout b66f7f6a65710bd99d21d22f52fa5bc46636d425
vim +/memory_add_physaddr_to_nid +42 drivers/xen/unpopulated-alloc.c

    17	
    18	static int fill_list(unsigned int nr_pages)
    19	{
    20		struct dev_pagemap *pgmap;
    21		void *vaddr;
    22		unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
    23		int nid, ret;
    24	
    25		pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
    26		if (!pgmap)
    27			return -ENOMEM;
    28	
    29		pgmap->type = MEMORY_DEVICE_GENERIC;
    30		pgmap->res.name = "Xen scratch";
    31		pgmap->res.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
    32	
    33		ret = allocate_resource(&iomem_resource, &pgmap->res,
    34					alloc_pages * PAGE_SIZE, 0, -1,
    35					PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
    36		if (ret < 0) {
    37			pr_err("Cannot allocate new IOMEM resource\n");
    38			kfree(pgmap);
    39			return ret;
    40		}
    41	
  > 42		nid = memory_add_physaddr_to_nid(pgmap->res.start);
    43	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#7 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

In reply to Roger Pau Monne
Quoted 15 lines · Roger Pau Monne
(quoted diff) +15 -0
+static int fill_list(unsigned int nr_pages)
+{
+	struct dev_pagemap *pgmap;
+	void *vaddr;
+	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
+	int nid, ret;
+
+	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
+	if (!pgmap)
+		return -ENOMEM;
+
+	pgmap->type = MEMORY_DEVICE_GENERIC;
+	pgmap->res.name = "Xen scratch";
+	pgmap->res.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
+

Review

Quoted 10 lines
(quoted diff) +10 -0
+	ret = allocate_resource(&iomem_resource, &pgmap->res,
+				alloc_pages * PAGE_SIZE, 0, -1,
+				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
+	if (ret < 0) {
+		pr_err("Cannot allocate new IOMEM resource\n");
+		kfree(pgmap);
+		return ret;
+	}
+
+	nid = memory_add_physaddr_to_nid(pgmap->res.start);

I think this is not needed ...

Quoted 16 lines
(quoted diff) +16 -0
+
+#ifdef CONFIG_XEN_HAVE_PVMMU
+        /*
+         * memremap will build page tables for the new memory so
+         * the p2m must contain invalid entries so the correct
+         * non-present PTEs will be written.
+         *
+         * If a failure occurs, the original (identity) p2m entries
+         * are not restored since this region is now known not to
+         * conflict with any devices.
+         */
+	if (!xen_feature(XENFEAT_auto_translated_physmap)) {
+		xen_pfn_t pfn = PFN_DOWN(pgmap->res.start);
+
+		for (i = 0; i < alloc_pages; i++) {
+			if (!set_phys_to_machine(pfn + i, INVALID_P2M_ENTRY)) {

Review

Quoted 10 lines
(quoted diff) +10 -0
+				pr_warn("set_phys_to_machine() failed, no memory added\n");
+				release_resource(&pgmap->res);
+				kfree(pgmap);
+				return -ENOMEM;
+			}
+                }
+	}
+#endif
+
+	vaddr = memremap_pages(pgmap, nid);

... and NUMA_NO_NODE should be used here instead, as this memory is just fictitious space to map foreign memory, and shouldn't be related to any NUMA node.

The following chunk should be folded in, or I can resend.

Thanks, Roger.
---8<---

drivers/xen/unpopulated-alloc.c +2 -4
index 1b5d157c6977..3b98dc921426 100644
@@ -20,7 +20,7 @@ static int fill_list(unsigned int nr_pages)
 	struct dev_pagemap *pgmap;
 	void *vaddr;
 	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
-	int nid, ret;
+	int ret;
 
 	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
 	if (!pgmap)
@@ -39,8 +39,6 @@ static int fill_list(unsigned int nr_pages)
 		return ret;
 	}
 
-	nid = memory_add_physaddr_to_nid(pgmap->res.start);
-
 #ifdef CONFIG_XEN_HAVE_PVMMU
         /*
          * memremap will build page tables for the new memory so
@@ -65,7 +63,7 @@ static int fill_list(unsigned int nr_pages)
 	}
 #endif
 
-	vaddr = memremap_pages(pgmap, nid);
+	vaddr = memremap_pages(pgmap, NUMA_NO_NODE);
 	if (IS_ERR(vaddr)) {
 		pr_err("Cannot remap memory range\n");
 		release_resource(&pgmap->res);
maintainer
#8 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Quoted 60 lines · Roger Pau Monné
Quoted 15 lines · Roger Pau Monne
(quoted diff) +15 -0
+static int fill_list(unsigned int nr_pages)
+{
+	struct dev_pagemap *pgmap;
+	void *vaddr;
+	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
+	int nid, ret;
+
+	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
+	if (!pgmap)
+		return -ENOMEM;
+
+	pgmap->type = MEMORY_DEVICE_GENERIC;
+	pgmap->res.name = "Xen scratch";
+	pgmap->res.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
+

Review

Quoted 10 lines
(quoted diff) +10 -0
+	ret = allocate_resource(&iomem_resource, &pgmap->res,
+				alloc_pages * PAGE_SIZE, 0, -1,
+				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
+	if (ret < 0) {
+		pr_err("Cannot allocate new IOMEM resource\n");
+		kfree(pgmap);
+		return ret;
+	}
+
+	nid = memory_add_physaddr_to_nid(pgmap->res.start);

I think this is not needed ...

Quoted 16 lines
(quoted diff) +16 -0
+
+#ifdef CONFIG_XEN_HAVE_PVMMU
+        /*
+         * memremap will build page tables for the new memory so
+         * the p2m must contain invalid entries so the correct
+         * non-present PTEs will be written.
+         *
+         * If a failure occurs, the original (identity) p2m entries
+         * are not restored since this region is now known not to
+         * conflict with any devices.
+         */
+	if (!xen_feature(XENFEAT_auto_translated_physmap)) {
+		xen_pfn_t pfn = PFN_DOWN(pgmap->res.start);
+
+		for (i = 0; i < alloc_pages; i++) {
+			if (!set_phys_to_machine(pfn + i, INVALID_P2M_ENTRY)) {

Review

Quoted 10 lines
(quoted diff) +10 -0
+				pr_warn("set_phys_to_machine() failed, no memory added\n");
+				release_resource(&pgmap->res);
+				kfree(pgmap);
+				return -ENOMEM;
+			}
+                }
+	}
+#endif
+
+	vaddr = memremap_pages(pgmap, nid);

... and NUMA_NO_NODE should be used here instead, as this memory is just fictitious space to map foreign memory, and shouldn't be related to any NUMA node.

Quoted 1 line

The following chunk should be folded in, or I can resend.

I can fold it in.

Juergen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#9 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

In reply to Roger Pau Monne
Quoted 21 lines · Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Quoted 4 lines

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

Sorry, I just got a build error for x86 32-bit build:

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] &&
SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n]
Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y]

  GEN     Makefile
  CC      kernel/bounds.s
  CALL    /home/gross/korg/src/scripts/atomic/check-atomics.sh
  UPD     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0,
                 from /home/gross/korg/src/include/linux/gfp.h:6,
                 from /home/gross/korg/src/include/linux/slab.h:15,
                 from /home/gross/korg/src/include/linux/crypto.h:19,
                 from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9:

/home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags"
#error "Not enough bits in page flags"
^~~~~
make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1 make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2
make[1]: Leaving directory '/home/gross/korg/x8632'
make: *** [Makefile:185: __sub-make] Error 2

Juergen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Quoted 44 lines · Jürgen Groß
Quoted 21 lines · Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Quoted 4 lines

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

Sorry, I just got a build error for x86 32-bit build:

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] &&
SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n]
Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y]

  GEN     Makefile
  CC      kernel/bounds.s
  CALL    /home/gross/korg/src/scripts/atomic/check-atomics.sh
  UPD     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0,
                 from /home/gross/korg/src/include/linux/gfp.h:6,
                 from /home/gross/korg/src/include/linux/slab.h:15,
                 from /home/gross/korg/src/include/linux/crypto.h:19,
                 from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9:
Quoted 9 lines

/home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags"
#error "Not enough bits in page flags"
^~~~~
make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114:
arch/x86/kernel/asm-offsets.s] Error 1
make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 make[1]: Leaving directory '/home/gross/korg/x8632'
make: *** [Makefile:185: __sub-make] Error 2

Sorry for this. I've tested a 32bit build but I think it was before the last Kconfig changes. I'm a little unsure how to solve this, as ZONE_DEVICE doesn't select the required options for it to run, but rather depends on them to be available.

You can trigger something similar on x86-64 by doing:

$ make ARCH=x86_64 xen.config
Using .config as base
Merging ./kernel/configs/xen.config
Merging ./arch/x86/configs/xen.config
#
# merged configuration written to .config (needs make)
#
scripts/kconfig/conf  --olddefconfig Kconfig

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=y] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=y] && ARCH_HAS_PTE_DEVMAP [=y] Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86_64 [=y]
#

# configuration written to .config
#

I think the only solution is to have XEN_UNPOPULATED_ALLOC depend on ZONE_DEVICE rather than select it?

Thanks, Roger.

maintainer
#11 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Quoted 76 lines · Roger Pau Monné
Quoted 44 lines · Jürgen Groß
Quoted 21 lines · Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Quoted 4 lines

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

Sorry, I just got a build error for x86 32-bit build:

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] &&
SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n]
Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y]

   GEN     Makefile
   CC      kernel/bounds.s
   CALL    /home/gross/korg/src/scripts/atomic/check-atomics.sh
   UPD     include/generated/bounds.h
   CC      arch/x86/kernel/asm-offsets.s
In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0,
                  from /home/gross/korg/src/include/linux/gfp.h:6,
                  from /home/gross/korg/src/include/linux/slab.h:15,
                  from /home/gross/korg/src/include/linux/crypto.h:19,
                  from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9:
Quoted 9 lines

/home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags"
#error "Not enough bits in page flags"
^~~~~
make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114:
arch/x86/kernel/asm-offsets.s] Error 1
make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 make[1]: Leaving directory '/home/gross/korg/x8632'
make: *** [Makefile:185: __sub-make] Error 2

Sorry for this. I've tested a 32bit build but I think it was before the last Kconfig changes. I'm a little unsure how to solve this, as ZONE_DEVICE doesn't select the required options for it to run, but rather depends on them to be available.

You can trigger something similar on x86-64 by doing:

$ make ARCH=x86_64 xen.config
Using .config as base
Merging ./kernel/configs/xen.config
Merging ./arch/x86/configs/xen.config
#
# merged configuration written to .config (needs make)
#
scripts/kconfig/conf  --olddefconfig Kconfig

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=y] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=y] && ARCH_HAS_PTE_DEVMAP [=y] Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86_64 [=y]
#

Quoted 5 lines
# configuration written to .config
#

I think the only solution is to have XEN_UNPOPULATED_ALLOC depend on ZONE_DEVICE rather than select it?

Yes, I think so.

I've folded that in and now build is fine.

Juergen

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#12 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Quoted 80 lines · Jürgen Groß
Quoted 79 lines · Roger Pau Monné
Quoted 44 lines · Jürgen Groß
Quoted 21 lines · Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Quoted 4 lines

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

Sorry, I just got a build error for x86 32-bit build:

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] &&
SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n]
Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y]

   GEN     Makefile
   CC      kernel/bounds.s
   CALL    /home/gross/korg/src/scripts/atomic/check-atomics.sh
   UPD     include/generated/bounds.h
   CC      arch/x86/kernel/asm-offsets.s
In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0,
                  from /home/gross/korg/src/include/linux/gfp.h:6,
                  from /home/gross/korg/src/include/linux/slab.h:15,
                  from /home/gross/korg/src/include/linux/crypto.h:19,
                  from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9:
Quoted 9 lines

/home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags"
#error "Not enough bits in page flags"
^~~~~
make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114:
arch/x86/kernel/asm-offsets.s] Error 1
make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 make[1]: Leaving directory '/home/gross/korg/x8632'
make: *** [Makefile:185: __sub-make] Error 2

Sorry for this. I've tested a 32bit build but I think it was before the last Kconfig changes. I'm a little unsure how to solve this, as ZONE_DEVICE doesn't select the required options for it to run, but rather depends on them to be available.

You can trigger something similar on x86-64 by doing:

$ make ARCH=x86_64 xen.config
Using .config as base
Merging ./kernel/configs/xen.config
Merging ./arch/x86/configs/xen.config
#
# merged configuration written to .config (needs make)
#
scripts/kconfig/conf  --olddefconfig Kconfig

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=y] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=y] && ARCH_HAS_PTE_DEVMAP [=y] Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86_64 [=y]
#

# configuration written to .config
#
Quoted 6 lines
Quoted 2 lines

I think the only solution is to have XEN_UNPOPULATED_ALLOC depend on ZONE_DEVICE rather than select it?

Yes, I think so.

I've folded that in and now build is fine.

Thanks, I assume no further action is needed on my side.

Roger.

maintainer
#13 lore raw

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

Quoted 81 lines · Roger Pau Monné
Quoted 80 lines · Jürgen Groß
Quoted 79 lines · Roger Pau Monné
Quoted 48 lines · Jürgen Groß
Quoted 21 lines · Roger Pau Monne

To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallback to use ballooned pages in order to create foreign mappings.

The newly added helpers use the same parameters as the existing {alloc/free}_xenballooned_pages functions, which allows for in-place replacement of the callers. Once a memory region has been added to be used as scratch mapping space it will no longer be released, and pages returned are kept in a linked list. This allows to have a buffer of pages and prevents resorting to frequent additions and removals of regions.

If enabled (because ZONE_DEVICE is supported) the usage of the new functionality untangles Xen balloon and RAM hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug.

Quoted 4 lines

Note the driver is currently not enabled on Arm platforms because it would interfere with the identity mapping required on some platforms.

Sorry, I just got a build error for x86 32-bit build:

WARNING: unmet direct dependencies detected for ZONE_DEVICE

    Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] &&

SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n]
Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y]
GEN Makefile
CC kernel/bounds.s
CALL /home/gross/korg/src/scripts/atomic/check-atomics.sh
UPD include/generated/bounds.h
CC arch/x86/kernel/asm-offsets.s
In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0,

                   from /home/gross/korg/src/include/linux/gfp.h:6,
                   from /home/gross/korg/src/include/linux/slab.h:15,
                   from /home/gross/korg/src/include/linux/crypto.h:19,
                   from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9:
/home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error
"Not enough bits in page flags"
   #error "Not enough bits in page flags"
    ^~~~~
Quoted 5 lines

make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114:
arch/x86/kernel/asm-offsets.s] Error 1
make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 make[1]: Leaving directory '/home/gross/korg/x8632'
make: *** [Makefile:185: __sub-make] Error 2

Sorry for this. I've tested a 32bit build but I think it was before the last Kconfig changes. I'm a little unsure how to solve this, as ZONE_DEVICE doesn't select the required options for it to run, but rather depends on them to be available.

You can trigger something similar on x86-64 by doing:

$ make ARCH=x86_64 xen.config
Using .config as base
Merging ./kernel/configs/xen.config
Merging ./arch/x86/configs/xen.config
#
# merged configuration written to .config (needs make)
#
scripts/kconfig/conf  --olddefconfig Kconfig

WARNING: unmet direct dependencies detected for ZONE_DEVICE
Depends on [n]: MEMORY_HOTPLUG [=y] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=y] && ARCH_HAS_PTE_DEVMAP [=y] Selected by [y]:
- XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86_64 [=y]
#

# configuration written to .config
#
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I think the only solution is to have XEN_UNPOPULATED_ALLOC depend on ZONE_DEVICE rather than select it?

Yes, I think so.

I've folded that in and now build is fine.

Thanks, I assume no further action is needed on my side.

Right.

Juergen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer Applied
#14 lore raw
In reply to Roger Pau Monne
Quoted 32 lines · Roger Pau Monne

Hello,

The following series contain some fixes in order to split Xen unpopulated memory handling from the ballooning driver using the ZONE_DEVICE functionality, so that physical memory regions used to map foreign pages are not tied to memory hotplug.

Note this is currently only available for x86 due to Arm using an identity map for dom0 p2m and thus needing special handling.

Thanks, Roger.

Roger Pau Monne (3):
xen/balloon: add header guard
memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC
xen: add helpers to allocate unpopulated memory

  drivers/dax/device.c                    |   2 +-
  drivers/gpu/drm/xen/xen_drm_front_gem.c |   9 +-
  drivers/xen/Kconfig                     |  11 ++
  drivers/xen/Makefile                    |   1 +
  drivers/xen/balloon.c                   |   4 +-
  drivers/xen/grant-table.c               |   4 +-
  drivers/xen/privcmd.c                   |   4 +-
  drivers/xen/unpopulated-alloc.c         | 185 ++++++++++++++++++++++++
  drivers/xen/xenbus/xenbus_client.c      |   6 +-
  drivers/xen/xlate_mmu.c                 |   4 +-
  include/linux/memremap.h                |   9 +-
  include/xen/balloon.h                   |   4 +
  include/xen/xen.h                       |   9 ++
  mm/memremap.c                           |   2 +-
  14 files changed, 232 insertions(+), 22 deletions(-)
Quoted 2 lines

create mode 100644 drivers/xen/unpopulated-alloc.c

Applied the series to xen/tip.git for-linus-5.9

Juergen