ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev
Subsystems (3)
PATCH v4 1/1 ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev
From: Camel Guo <[email protected]>
In adcx140_i2c_probe, adcx140->dev is accessed before its initialization. This commit fixes this bug.
---
v4:
- Add Acked-By from Dan
v3:
- Add Fixes tag
v2:
- Fix typo
sound/soc/codecs/tlv320adcx140.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/codecs/tlv320adcx140.c +3 -1
@@ -980,6 +980,8 @@ static int adcx140_i2c_probe(struct i2c_client *i2c,if (!adcx140)return -ENOMEM ; + adcx140->dev = &i2c->dev; + adcx140->gpio_reset =devm_gpiod_get_optional (adcx140->dev,"reset" ,GPIOD_OUT_LOW );if (IS_ERR (adcx140->gpio_reset))
@@ -1007,7 +1009,7 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, ret);return ret; } - adcx140->dev = &i2c->dev; +i2c_set_clientdata (i2c, adcx140); return devm_snd_soc_register_component(&i2c->dev,
Signature · 1 line
2.20.1
Mark Brown
maintainerQuoted 2 lines · Camel Guo
In
adcx140_i2c_probe,adcx140->devis accessed before its initialization. This commit fixes this bug.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev
commit: 2569231d71dff82cfd6e82ab3871776f72ec53b6
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark