Skip to contentSkip to conversation

IIO: rockchip: add missing dependencies for saradc

PATCH In review Vicente Bergas 2 participants 2 messages Sep 1, 2020 – Sep 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IIO: rockchip: add missing dependencies for saradc

This driver uses the triggered buffer functionality but was not requiring it.

---
 drivers/iio/adc/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/adc/Kconfig +3 -0
index 66d9cc073157..cd90f60cdfd9 100644
@@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.
Signature · 1 line
2.28.0
maintainer
#1 lore raw
Quoted 4 lines · On Tue, 1 Sep 2020 22:40:54 +0200 Vicente Bergas <[email protected]> wrote:

This driver uses the triggered buffer functionality but was not requiring it.

Fix should now be in tree. I don't think the IIO_TRIGGER select is necessary (and isn't in current fixed version) but if I'm wrong on that please shout! Logically it shouldn't be required as the driver doesn't provide a trigger, but we may have something missing a stub somewhere.

Jonathan

Quoted 9 lines
---
 drivers/iio/adc/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/adc/Kconfig +0 -0
index 66d9cc073157..cd90f60cdfd9 100644

drivers/iio/adc/Kconfig config ROCKCHIP_SARADC · line 873

Quoted 9 lines
drivers/iio/adc/Kconfig +3 -0
@@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
 	tristate "Rockchip SARADC driver"
 	depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
 	depends on RESET_CONTROLLER
+	select IIO_BUFFER
+	select IIO_TRIGGER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the SARADC found in SoCs from
 	  Rockchip.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip