Skip to contentSkip to conversation

arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings

PATCH Superseded Nishanth Menon 4 participants 38 messages Sep 1, 2020 – Sep 7, 2020

Subsystems (2)
lore
Share & tools
lore
author maintainer
#13 lore raw

PATCH 6/7 arm64: dts: ti: k3-*: Use generic adc for node names

In reply to Nishanth Menon

Use adc@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 51ca4b4d4c21..6dfec68ac865 100644
@@ -80,7 +80,7 @@
 		#size-cells = <0>;
 	};
 
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {
 		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
 		reg = <0x0 0x40200000 0x0 0x1000>;
 		interrupts = <GIC_SPI 580 IRQ_TYPE_LEVEL_HIGH>;
@@ -98,7 +98,7 @@
 		};
 	};
 
-	tscadc1: tscadc@40210000 {
+	tscadc1: adc@40210000 {
 		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
 		reg = <0x0 0x40210000 0x0 0x1000>;
 		interrupts = <GIC_SPI 581 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +2 -2
index 9ad0266598ad..81801f519a61 100644
@@ -211,7 +211,7 @@
 		};
 	};
 
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {
 		compatible = "ti,am3359-tscadc";
 		reg = <0x0 0x40200000 0x0 0x1000>;
 		interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
@@ -230,7 +230,7 @@
 		};
 	};
 
-	tscadc1: tscadc@40210000 {
+	tscadc1: adc@40210000 {
 		compatible = "ti,am3359-tscadc";
 		reg = <0x0 0x40210000 0x0 0x1000>;
 		interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.17.1
author maintainer
#6 lore raw

PATCH 3/7 arm64: dts: ti: k3-*: Use generic pinctrl for node names

In reply to Nishanth Menon

Use pinctrl@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi      | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 03e28fc256de..9c96e3f58c86 100644
@@ -134,7 +134,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c000 0x0 0x2e4>;
 		#pinctrl-cells = <1>;
@@ -142,7 +142,7 @@
 		pinctrl-single,function-mask = <0xffffffff>;
 	};
 
-	main_pmx1: pinmux@11c2e8 {
+	main_pmx1: pinctrl@11c2e8 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c2e8 0x0 0x24>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index 0765700a8ba8..bb498be2f0a4 100644
@@ -39,7 +39,7 @@
 		reg = <0x43000014 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		reg = <0x4301c000 0x118>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -1
index 00a36a14efe7..1d2a7c05b6f3 100644
@@ -327,7 +327,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x0 0x11c000 0x0 0x2b4>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index c4a48e8d420a..9ad0266598ad 100644
@@ -53,7 +53,7 @@
 		reg = <0x0 0x43000014 0x0 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x00 0x4301c000 0x00 0x178>;
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 1/7 arm64: dts: ti: k3-am65*: Use generic gpio for node names

In reply to Nishanth Menon

Use gpio@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi   | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 76e0edc4ad5c..336d09d6fec7 100644
@@ -661,7 +661,7 @@
 		};
 	};
 
-	main_gpio0:  main_gpio0@600000 {
+	main_gpio0: gpio@600000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x600000 0x0 0x100>;
 		gpio-controller;
@@ -676,7 +676,7 @@
 		clock-names = "gpio";
 	};
 
-	main_gpio1:  main_gpio1@601000 {
+	main_gpio1: gpio@601000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x601000 0x0 0x100>;
 		gpio-controller;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index a1ffe88d9664..0765700a8ba8 100644
@@ -80,7 +80,7 @@
 		ti,interrupt-ranges = <0 712 16>;
 	};
 
-	wkup_gpio0: wkup_gpio0@42110000 {
+	wkup_gpio0: gpio@42110000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x42110000 0x100>;
 		gpio-controller;
Signature · 1 line
2.17.1
author maintainer
#8 lore raw

PATCH 4/7 arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640

In reply to Nishanth Menon

Use camera@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +1 -1
index b8a8a0fcb8af..86c9074cb070 100644
@@ -257,7 +257,7 @@
 	pinctrl-0 = <&main_i2c1_pins_default>;
 	clock-frequency = <400000>;
 
-	ov5640@3c {
+	ov5640: camera@3c {
 		compatible = "ovti,ov5640";
 		reg = <0x3c>;
 
Signature · 1 line
2.17.1

Nishanth Menon

author maintainer
#0 lore raw

cover arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings

Hi,

This is one part of cleanups meant for make W=2 dtbs for 5.10 on TI dtbs. Hopefully we dont see node_name_chars_strict warnings anymore.

As part of this cleanup, I ran a cross check of nodes that are part of K3 as of right now, Vs what is "generic" definition as per 0.3 dt specification:
https://pastebin.ubuntu.com/p/kp3g4ktBYp/

I dont think the remaining have a good reference, at least in my subjective view.

In possibly some cases, bootloaders may need to sync before doing DT fixup etc.

Nishanth Menon (7):
arm64: dts: ti: k3-am65*: Use generic gpio for node names
arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name
arm64: dts: ti: k3-*: Use generic pinctrl for node names
arm64: dts: ti: k3-am65-base-board Use generic camera for node name
instead of ov5640
arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for
node name
arm64: dts: ti: k3-*: Use generic adc for node names
arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi        |  8 ++++----
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi     |  6 +++---
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 18 +++++++++---------
 .../dts/ti/k3-am654-industrial-thermal.dtsi    | 12 ++++++------
 .../boot/dts/ti/k3-j721e-common-proc-board.dts | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi      |  8 ++++----
 .../arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi |  8 ++++----
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi    |  2 +-
 9 files changed, 49 insertions(+), 49 deletions(-)
Signature · 1 line
2.17.1
author maintainer
#10 lore raw

PATCH 5/7 arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

Use temperature-sensor@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index bb498be2f0a4..ed42f13e7663 100644
@@ -95,7 +95,7 @@
 		clock-names = "gpio";
 	};
 
-	wkup_vtm0: thermal@42050000 {
+	wkup_vtm0: temperature-sensor@42050000 {
 		compatible = "ti,am654-vtm";
 		reg = <0x42050000 0x25c>;
 		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
Signature · 1 line
2.17.1
author maintainer
#18 lore raw

PATCH 7/7 arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

In reply to Nishanth Menon

Building with W=2 throws up a bunch of easy to fixup errors.. node_name_chars_strict is one of them.. Knock those out.

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       |  6 +++---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi        |  4 ++--
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++--------
 .../dts/ti/k3-am654-industrial-thermal.dtsi    | 12 ++++++------
 .../boot/dts/ti/k3-j721e-common-proc-board.dts | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi      |  6 +++---
 .../arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi |  2 +-
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi    |  2 +-
 8 files changed, 33 insertions(+), 33 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -3
index 9c96e3f58c86..ff3e38408dbc 100644
@@ -305,7 +305,7 @@
 		no-1-8-v;
 	};
 
-	scm_conf: scm_conf@100000 {
+	scm_conf: scm-conf@100000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
@@ -344,7 +344,7 @@
 					<0x4090 0x3>; /* SERDES1 lane select */
 		};
 
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
+		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41E0 {
 			compatible = "syscon";
 			reg = <0x0000041E0 0x14>;
 		};
@@ -445,7 +445,7 @@
 		ti,interrupt-ranges = <0 392 32>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 6dfec68ac865..435e51019287 100644
@@ -6,7 +6,7 @@
  */
 
 &cbass_mcu {
-	mcu_conf: scm_conf@40f00000 {
+	mcu_conf: scm-conf@40f00000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0x0 0x40f00000 0x0 0x20000>;
 		#address-cells = <1>;
@@ -116,7 +116,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +8 -8
index 86c9074cb070..d12dd89f3405 100644
@@ -29,7 +29,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
-		secure_ddr: secure_ddr@9e800000 {
+		secure_ddr: secure-ddr@9e800000 {
 			reg = <0 0x9e800000 0 0x01800000>; /* for OP-TEE */
 			alignment = <0x1000>;
 			no-map;
@@ -70,14 +70,14 @@
 		>;
 	};
 
-	push_button_pins_default: push_button__pins_default {
+	push_button_pins_default: push-button-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0030, PIN_INPUT, 7) /* (R5) WKUP_GPIO0_24 */
 			AM65X_WKUP_IOPAD(0x003c, PIN_INPUT, 7) /* (P2) WKUP_GPIO0_27 */
 		>;
 	};
 
-	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins_default {
+	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* (V1) MCU_OSPI0_CLK */
 			AM65X_WKUP_IOPAD(0x0008, PIN_INPUT, 0)	 /* (U2) MCU_OSPI0_DQS */
@@ -93,13 +93,13 @@
 		>;
 	};
 
-	wkup_pca554_default: wkup_pca554_default {
+	wkup_pca554_default: wkup-pca554-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0034, PIN_INPUT, 7) /* (T1) MCU_OSPI1_CLK.WKUP_GPIO0_25 */
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* (N4) MCU_RGMII1_TX_CTL */
 			AM65X_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* (N5) MCU_RGMII1_RX_CTL */
@@ -116,7 +116,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
 			AM65X_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02d4, PIN_INPUT_PULLDOWN, 0) /* (C27) MMC1_CLK */
 			AM65X_IOPAD(0x02d8, PIN_INPUT_PULLUP, 0) /* (C28) MMC1_CMD */
@@ -180,7 +180,7 @@
 		>;
 	};
 
-	usb1_pins_default: usb1_pins_default {
+	usb1_pins_default: usb1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02c0, PIN_OUTPUT, 0) /* (AC8) USB1_DRVVBUS */
 		>;
arch/arm64/boot/dts/ti/k3-am654-industrial-thermal.dtsi +6 -6
index cdc3d40c3f60..9021c738056b 100644
@@ -2,13 +2,13 @@
 
 #include <dt-bindings/thermal/thermal.h>
 
-mpu0_thermal: mpu0_thermal {
+mpu0_thermal: mpu0-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 0>;
 
 	trips {
-		mpu0_crit: mpu0_crit {
+		mpu0_crit: mpu0-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -16,13 +16,13 @@ mpu0_thermal: mpu0_thermal {
 	};
 };
 
-mpu1_thermal: mpu1_thermal {
+mpu1_thermal: mpu1-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 1>;
 
 	trips {
-		mpu1_crit: mpu1_crit {
+		mpu1_crit: mpu1-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -30,13 +30,13 @@ mpu1_thermal: mpu1_thermal {
 	};
 };
 
-mcu_thermal: mcu_thermal {
+mcu_thermal: mcu-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 2>;
 
 	trips {
-		mcu_crit: mcu_crit {
+		mcu_crit: mcu-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +9 -9
index c355692796a9..648267284582 100644
@@ -86,13 +86,13 @@
 };
 
 &main_pmx0 {
-	sw10_button_pins_default: sw10_button_pins_default {
+	sw10_button_pins_default: sw10-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x0, PIN_INPUT, 7) /* (AC18) EXTINTn.GPIO0_0 */
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x254, PIN_INPUT, 0) /* (R29) MMC1_CMD */
 			J721E_IOPAD(0x250, PIN_INPUT, 0) /* (P25) MMC1_CLK */
@@ -106,14 +106,14 @@
 		>;
 	};
 
-	main_usbss0_pins_default: main_usbss0_pins_default {
+	main_usbss0_pins_default: main-usbss0-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
 			J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
 		>;
 	};
 
-	main_usbss1_pins_default: main_usbss1_pins_default {
+	main_usbss1_pins_default: main-usbss1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */
 		>;
@@ -153,7 +153,7 @@
 		>;
 	};
 
-	mcasp10_pins_default: mcasp10_pins_default {
+	mcasp10_pins_default: mcasp10-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x158, PIN_OUTPUT_PULLDOWN, 12) /* (U23) RGMII5_TX_CTL.MCASP10_ACLKX */
 			J721E_IOPAD(0x15c, PIN_OUTPUT_PULLDOWN, 12) /* (U26) RGMII5_RX_CTL.MCASP10_AFSX */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	audi_ext_refclk2_pins_default: audi_ext_refclk2_pins_default {
+	audi_ext_refclk2_pins_default: audi-ext-refclk2-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x1a4, PIN_OUTPUT, 3) /* (W26) RGMII6_RXC.AUDIO_EXT_REFCLK2 */
 		>;
@@ -175,7 +175,7 @@
 };
 
 &wkup_pmx0 {
-	sw11_button_pins_default: sw11_button_pins_default {
+	sw11_button_pins_default: sw11-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xcc, PIN_INPUT, 7) /* (G28) WKUP_GPIO0_7 */
 		>;
@@ -194,7 +194,7 @@
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
 			J721E_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
@@ -211,7 +211,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* MCU_MDIO0_MDC */
 			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_MDIO0_MDIO */
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +3 -3
index 1d2a7c05b6f3..ea57d07777ba 100644
@@ -86,7 +86,7 @@
 		ti,interrupt-ranges = <8 392 56>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -888,7 +888,7 @@
 		no-1-8-v;
 	};
 
-	usbss0: cdns_usb@4104000 {
+	usbss0: cdns-usb@4104000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4104000 0x00 0x100>;
 		dma-coherent;
@@ -918,7 +918,7 @@
 		};
 	};
 
-	usbss1: cdns_usb@4114000 {
+	usbss1: cdns-usb@4114000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4114000 0x00 0x100>;
 		dma-coherent;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index 81801f519a61..03fa69c0a038 100644
@@ -249,7 +249,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi +1 -1
index d69d90c8b5e3..5dc3ba739131 100644
@@ -71,7 +71,7 @@
 };
 
 &wkup_pmx0 {
-	wkup_i2c0_pins_default: wkup_i2c0_pins_default {
+	wkup_i2c0_pins_default: wkup-i2c0-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xf8, PIN_INPUT_PULLUP, 0) /* (J25) WKUP_I2C0_SCL */
 			J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
Signature · 1 line
2.17.1
author maintainer
#3 lore raw

PATCH 2/7 arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name

In reply to Nishanth Menon

Use clock@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 336d09d6fec7..03e28fc256de 100644
@@ -327,12 +327,12 @@
 			reg = <0x00000210 0x4>;
 		};
 
-		serdes0_clk: serdes_clk@4080 {
+		serdes0_clk: clock@4080 {
 			compatible = "syscon";
 			reg = <0x00004080 0x4>;
 		};
 
-		serdes1_clk: serdes_clk@4090 {
+		serdes1_clk: clock@4090 {
 			compatible = "syscon";
 			reg = <0x00004090 0x4>;
 		};
Signature · 1 line
2.17.1
Reviewed-by on the v1 series
#21 lore raw
In reply to Nishanth Menon
Quoted 16 lines · Nishanth Menon

Hi,

This is one part of cleanups meant for make W=2 dtbs for 5.10 on TI dtbs. Hopefully we dont see node_name_chars_strict warnings anymore.

As part of this cleanup, I ran a cross check of nodes that are part of K3 as of right now, Vs what is "generic" definition as per 0.3 dt specification:
https://pastebin.ubuntu.com/p/kp3g4ktBYp/

I dont think the remaining have a good reference, at least in my subjective view.

In possibly some cases, bootloaders may need to sync before doing DT fixup etc.

Quoted 10 lines

Nishanth Menon (7):
arm64: dts: ti: k3-am65*: Use generic gpio for node names
arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name
arm64: dts: ti: k3-*: Use generic pinctrl for node names
arm64: dts: ti: k3-am65-base-board Use generic camera for node name
instead of ov5640
arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for
node name
arm64: dts: ti: k3-*: Use generic adc for node names
arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

Series looks good to me,

Thanks and regards,
Lokesh

Acked-by on v1 1/7
#2 lore raw

Re: [PATCH 1/7] arm64: dts: ti: k3-am65*: Use generic gpio for node names

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

Use gpio@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 41 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi   | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 76e0edc4ad5c..336d09d6fec7 100644
@@ -661,7 +661,7 @@
 		};
 	};
 
-	main_gpio0:  main_gpio0@600000 {
+	main_gpio0: gpio@600000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x600000 0x0 0x100>;
 		gpio-controller;
@@ -676,7 +676,7 @@
 		clock-names = "gpio";
 	};
 
-	main_gpio1:  main_gpio1@601000 {
+	main_gpio1: gpio@601000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x601000 0x0 0x100>;
 		gpio-controller;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index a1ffe88d9664..0765700a8ba8 100644
@@ -80,7 +80,7 @@
 		ti,interrupt-ranges = <0 712 16>;
 	};
 
-	wkup_gpio0: wkup_gpio0@42110000 {
+	wkup_gpio0: gpio@42110000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x42110000 0x100>;
 		gpio-controller;
Acked-by on v1 3/7
#7 lore raw

Re: [PATCH 3/7] arm64: dts: ti: k3-*: Use generic pinctrl for node names

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

Use pinctrl@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 69 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi      | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 03e28fc256de..9c96e3f58c86 100644
@@ -134,7 +134,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c000 0x0 0x2e4>;
 		#pinctrl-cells = <1>;
@@ -142,7 +142,7 @@
 		pinctrl-single,function-mask = <0xffffffff>;
 	};
 
-	main_pmx1: pinmux@11c2e8 {
+	main_pmx1: pinctrl@11c2e8 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c2e8 0x0 0x24>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index 0765700a8ba8..bb498be2f0a4 100644
@@ -39,7 +39,7 @@
 		reg = <0x43000014 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		reg = <0x4301c000 0x118>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -1
index 00a36a14efe7..1d2a7c05b6f3 100644
@@ -327,7 +327,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x0 0x11c000 0x0 0x2b4>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index c4a48e8d420a..9ad0266598ad 100644
@@ -53,7 +53,7 @@
 		reg = <0x0 0x43000014 0x0 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x00 0x4301c000 0x00 0x178>;
Acked-by on v1 4/7
#9 lore raw

Re: [PATCH 4/7] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

Use camera@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 18 lines
---
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +1 -1
index b8a8a0fcb8af..86c9074cb070 100644
@@ -257,7 +257,7 @@
 	pinctrl-0 = <&main_i2c1_pins_default>;
 	clock-frequency = <400000>;
 
-	ov5640@3c {
+	ov5640: camera@3c {
 		compatible = "ovti,ov5640";
 		reg = <0x3c>;
 
#14 lore raw

Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

In reply to Nishanth Menon
Quoted 17 lines · Nishanth Menon

Use adc@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +0 -0
index 51ca4b4d4c21..6dfec68ac865 100644

arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi line 83

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +1 -1
@@ -80,7 +80,7 @@
 		#size-cells = <0>;
 	};
 
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {

OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm.

regards
Suman

Quoted 35 lines
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +1 -1
 		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
 		reg = <0x0 0x40200000 0x0 0x1000>;
 		interrupts = <GIC_SPI 580 IRQ_TYPE_LEVEL_HIGH>;
@@ -98,7 +98,7 @@
 		};
 	};
 
-	tscadc1: tscadc@40210000 {
+	tscadc1: adc@40210000 {
 		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
 		reg = <0x0 0x40210000 0x0 0x1000>;
 		interrupts = <GIC_SPI 581 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +2 -2
index 9ad0266598ad..81801f519a61 100644
@@ -211,7 +211,7 @@
 		};
 	};
 
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {
 		compatible = "ti,am3359-tscadc";
 		reg = <0x0 0x40200000 0x0 0x1000>;
 		interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
@@ -230,7 +230,7 @@
 		};
 	};
 
-	tscadc1: tscadc@40210000 {
+	tscadc1: adc@40210000 {
 		compatible = "ti,am3359-tscadc";
 		reg = <0x0 0x40210000 0x0 0x1000>;
 		interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
Reviewed-by on v1 7/7
#19 lore raw

Re: [PATCH 7/7] arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

In reply to Nishanth Menon
Quoted 29 lines · Nishanth Menon

Building with W=2 throws up a bunch of easy to fixup errors.. node_name_chars_strict is one of them.. Knock those out.

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       |  6 +++---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi        |  4 ++--
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++--------
 .../dts/ti/k3-am654-industrial-thermal.dtsi    | 12 ++++++------
 .../boot/dts/ti/k3-j721e-common-proc-board.dts | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi      |  6 +++---
 .../arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi |  2 +-
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi    |  2 +-
 8 files changed, 33 insertions(+), 33 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 9c96e3f58c86..ff3e38408dbc 100644
@@ -305,7 +305,7 @@
 		no-1-8-v;
 	};
 
-	scm_conf: scm_conf@100000 {
+	scm_conf: scm-conf@100000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 349

Quoted 7 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
@@ -344,7 +344,7 @@
 					<0x4090 0x3>; /* SERDES1 lane select */
 		};
 
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
+		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41E0 {
 			compatible = "syscon";
 			reg = <0x0000041E0 0x14>;

We should %s/41E0/41e0/, but that change is not directly associated with the patch subject line. Perhaps, an additional patch? Remember seeing similar warning on some downstream crypto nodes, but strangely I am not seeing on these upstream nodes.

Otherwise,

regards
Suman

Quoted 297 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
 		};
@@ -445,7 +445,7 @@
 		ti,interrupt-ranges = <0 392 32>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 6dfec68ac865..435e51019287 100644
@@ -6,7 +6,7 @@
  */
 
 &cbass_mcu {
-	mcu_conf: scm_conf@40f00000 {
+	mcu_conf: scm-conf@40f00000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0x0 0x40f00000 0x0 0x20000>;
 		#address-cells = <1>;
@@ -116,7 +116,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +8 -8
index 86c9074cb070..d12dd89f3405 100644
@@ -29,7 +29,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
-		secure_ddr: secure_ddr@9e800000 {
+		secure_ddr: secure-ddr@9e800000 {
 			reg = <0 0x9e800000 0 0x01800000>; /* for OP-TEE */
 			alignment = <0x1000>;
 			no-map;
@@ -70,14 +70,14 @@
 		>;
 	};
 
-	push_button_pins_default: push_button__pins_default {
+	push_button_pins_default: push-button-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0030, PIN_INPUT, 7) /* (R5) WKUP_GPIO0_24 */
 			AM65X_WKUP_IOPAD(0x003c, PIN_INPUT, 7) /* (P2) WKUP_GPIO0_27 */
 		>;
 	};
 
-	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins_default {
+	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* (V1) MCU_OSPI0_CLK */
 			AM65X_WKUP_IOPAD(0x0008, PIN_INPUT, 0)	 /* (U2) MCU_OSPI0_DQS */
@@ -93,13 +93,13 @@
 		>;
 	};
 
-	wkup_pca554_default: wkup_pca554_default {
+	wkup_pca554_default: wkup-pca554-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0034, PIN_INPUT, 7) /* (T1) MCU_OSPI1_CLK.WKUP_GPIO0_25 */
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* (N4) MCU_RGMII1_TX_CTL */
 			AM65X_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* (N5) MCU_RGMII1_RX_CTL */
@@ -116,7 +116,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
 			AM65X_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02d4, PIN_INPUT_PULLDOWN, 0) /* (C27) MMC1_CLK */
 			AM65X_IOPAD(0x02d8, PIN_INPUT_PULLUP, 0) /* (C28) MMC1_CMD */
@@ -180,7 +180,7 @@
 		>;
 	};
 
-	usb1_pins_default: usb1_pins_default {
+	usb1_pins_default: usb1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02c0, PIN_OUTPUT, 0) /* (AC8) USB1_DRVVBUS */
 		>;
arch/arm64/boot/dts/ti/k3-am654-industrial-thermal.dtsi +6 -6
index cdc3d40c3f60..9021c738056b 100644
@@ -2,13 +2,13 @@
 
 #include <dt-bindings/thermal/thermal.h>
 
-mpu0_thermal: mpu0_thermal {
+mpu0_thermal: mpu0-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 0>;
 
 	trips {
-		mpu0_crit: mpu0_crit {
+		mpu0_crit: mpu0-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -16,13 +16,13 @@ mpu0_thermal: mpu0_thermal {
 	};
 };
 
-mpu1_thermal: mpu1_thermal {
+mpu1_thermal: mpu1-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 1>;
 
 	trips {
-		mpu1_crit: mpu1_crit {
+		mpu1_crit: mpu1-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -30,13 +30,13 @@ mpu1_thermal: mpu1_thermal {
 	};
 };
 
-mcu_thermal: mcu_thermal {
+mcu_thermal: mcu-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 2>;
 
 	trips {
-		mcu_crit: mcu_crit {
+		mcu_crit: mcu-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +9 -9
index c355692796a9..648267284582 100644
@@ -86,13 +86,13 @@
 };
 
 &main_pmx0 {
-	sw10_button_pins_default: sw10_button_pins_default {
+	sw10_button_pins_default: sw10-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x0, PIN_INPUT, 7) /* (AC18) EXTINTn.GPIO0_0 */
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x254, PIN_INPUT, 0) /* (R29) MMC1_CMD */
 			J721E_IOPAD(0x250, PIN_INPUT, 0) /* (P25) MMC1_CLK */
@@ -106,14 +106,14 @@
 		>;
 	};
 
-	main_usbss0_pins_default: main_usbss0_pins_default {
+	main_usbss0_pins_default: main-usbss0-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
 			J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
 		>;
 	};
 
-	main_usbss1_pins_default: main_usbss1_pins_default {
+	main_usbss1_pins_default: main-usbss1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */
 		>;
@@ -153,7 +153,7 @@
 		>;
 	};
 
-	mcasp10_pins_default: mcasp10_pins_default {
+	mcasp10_pins_default: mcasp10-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x158, PIN_OUTPUT_PULLDOWN, 12) /* (U23) RGMII5_TX_CTL.MCASP10_ACLKX */
 			J721E_IOPAD(0x15c, PIN_OUTPUT_PULLDOWN, 12) /* (U26) RGMII5_RX_CTL.MCASP10_AFSX */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	audi_ext_refclk2_pins_default: audi_ext_refclk2_pins_default {
+	audi_ext_refclk2_pins_default: audi-ext-refclk2-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x1a4, PIN_OUTPUT, 3) /* (W26) RGMII6_RXC.AUDIO_EXT_REFCLK2 */
 		>;
@@ -175,7 +175,7 @@
 };
 
 &wkup_pmx0 {
-	sw11_button_pins_default: sw11_button_pins_default {
+	sw11_button_pins_default: sw11-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xcc, PIN_INPUT, 7) /* (G28) WKUP_GPIO0_7 */
 		>;
@@ -194,7 +194,7 @@
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
 			J721E_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
@@ -211,7 +211,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* MCU_MDIO0_MDC */
 			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_MDIO0_MDIO */
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +3 -3
index 1d2a7c05b6f3..ea57d07777ba 100644
@@ -86,7 +86,7 @@
 		ti,interrupt-ranges = <8 392 56>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -888,7 +888,7 @@
 		no-1-8-v;
 	};
 
-	usbss0: cdns_usb@4104000 {
+	usbss0: cdns-usb@4104000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4104000 0x00 0x100>;
 		dma-coherent;
@@ -918,7 +918,7 @@
 		};
 	};
 
-	usbss1: cdns_usb@4114000 {
+	usbss1: cdns-usb@4114000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4114000 0x00 0x100>;
 		dma-coherent;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index 81801f519a61..03fa69c0a038 100644
@@ -249,7 +249,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi +1 -1
index d69d90c8b5e3..5dc3ba739131 100644
@@ -71,7 +71,7 @@
 };
 
 &wkup_pmx0 {
-	wkup_i2c0_pins_default: wkup_i2c0_pins_default {
+	wkup_i2c0_pins_default: wkup-i2c0-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xf8, PIN_INPUT_PULLUP, 0) /* (J25) WKUP_I2C0_SCL */
 			J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
Reviewed-by on v1 5/7
#11 lore raw

Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

In reply to Nishanth Menon
Quoted 17 lines · Nishanth Menon

Use temperature-sensor@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
index bb498be2f0a4..ed42f13e7663 100644

arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi line 98

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
@@ -95,7 +95,7 @@
 		clock-names = "gpio";
 	};
 
-	wkup_vtm0: thermal@42050000 {
+	wkup_vtm0: temperature-sensor@42050000 {

There has been a suggestion to use something like thermal-sensor during the bindings review, but it is better to use this standard node name.

regards
Suman

Quoted 4 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
 		compatible = "ti,am654-vtm";
 		reg = <0x42050000 0x25c>;
 		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
Acked-by on v1 2/7
#4 lore raw

Re: [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

Use clock@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 14 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -1
index 336d09d6fec7..03e28fc256de 100644
@@ -327,12 +327,12 @@
 			reg = <0x00000210 0x4>;
 		};
 
-		serdes0_clk: serdes_clk@4080 {

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 338

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -1
+		serdes0_clk: clock@4080 {
 			compatible = "syscon";
 			reg = <0x00004080 0x4>;
 		};
 
-		serdes1_clk: serdes_clk@4090 {
+		serdes1_clk: clock@4090 {
 			compatible = "syscon";
 			reg = <0x00004090 0x4>;
 		};

Btw, there is also ehrpwm_tbclk alongside these nodes which is currently defined as a syscon, but is actually a clock.

regards
Suman

author maintainer
#12 lore raw

Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

In reply to Suman Anna
Quoted 21 lines · Suman Anna
Quoted 20 lines · Nishanth Menon

Use temperature-sensor@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
index bb498be2f0a4..ed42f13e7663 100644
@@ -95,7 +95,7 @@
 		clock-names = "gpio";
 	};
 
Quoted 5 lines

arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi line 98

Quoted 2 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
-	wkup_vtm0: thermal@42050000 {
+	wkup_vtm0: temperature-sensor@42050000 {

There has been a suggestion to use something like thermal-sensor during the bindings review, but it is better to use this standard node name.

Yes - I did notice it as well, and then picked up the recommendation straight from 0.3 spec itself.

Quoted 11 lines

regards
Suman

Quoted 4 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
 		compatible = "ti,am654-vtm";
 		reg = <0x42050000 0x25c>;
 		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author maintainer
#20 lore raw

Re: [PATCH 7/7] arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

In reply to Suman Anna
Quoted 33 lines · Suman Anna
Quoted 32 lines · Nishanth Menon

Building with W=2 throws up a bunch of easy to fixup errors.. node_name_chars_strict is one of them.. Knock those out.

---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       |  6 +++---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi        |  4 ++--
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++--------
 .../dts/ti/k3-am654-industrial-thermal.dtsi    | 12 ++++++------
 .../boot/dts/ti/k3-j721e-common-proc-board.dts | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi      |  6 +++---
 .../arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi |  2 +-
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi    |  2 +-
 8 files changed, 33 insertions(+), 33 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 9c96e3f58c86..ff3e38408dbc 100644
@@ -305,7 +305,7 @@
 		no-1-8-v;
 	};
 
-	scm_conf: scm_conf@100000 {
+	scm_conf: scm-conf@100000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
@@ -344,7 +344,7 @@
 					<0x4090 0x3>; /* SERDES1 lane select */
 		};
 
Quoted 9 lines

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 349

Quoted 4 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
+		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41E0 {
 			compatible = "syscon";
 			reg = <0x0000041E0 0x14>;

We should %s/41E0/41e0/, but that change is not directly associated with the patch subject line. Perhaps, an additional patch? Remember seeing similar warning on some downstream crypto nodes, but strangely I am not seeing on these upstream nodes.

yeah - probably a separate patch, but thanks, i can fix it as well(will check if there are similar ones around as well).

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author maintainer
#15 lore raw

Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

In reply to Suman Anna
Quoted 21 lines · Suman Anna
Quoted 20 lines · Nishanth Menon

Use adc@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +0 -0
index 51ca4b4d4c21..6dfec68ac865 100644
@@ -80,7 +80,7 @@
 		#size-cells = <0>;
 	};
 
Quoted 8 lines

arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi line 83

Quoted 2 lines
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +1 -1
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {

OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm.

Vignesh: are you ok with this, care to comment?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author maintainer
#5 lore raw

Re: [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name

In reply to Suman Anna
Quoted 29 lines · Suman Anna
Quoted 7 lines · Nishanth Menon

Use clock@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 18 lines
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 336d09d6fec7..03e28fc256de 100644
@@ -327,12 +327,12 @@
 			reg = <0x00000210 0x4>;
 		};
 
-		serdes0_clk: serdes_clk@4080 {
+		serdes0_clk: clock@4080 {
 			compatible = "syscon";
 			reg = <0x00004080 0x4>;
 		};
 
Quoted 9 lines

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 338

Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
-		serdes1_clk: serdes_clk@4090 {
+		serdes1_clk: clock@4090 {
 			compatible = "syscon";
 			reg = <0x00004090 0x4>;
 		};

Btw, there is also ehrpwm_tbclk alongside these nodes which is currently defined as a syscon, but is actually a clock.

aah, good catch.. I can fix that in the follow on V2.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#16 lore raw

Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

In reply to Nishanth Menon

Hi Nishanth,

Quoted 32 lines · Nishanth Menon
Quoted 21 lines · Suman Anna
Quoted 20 lines · Nishanth Menon

Use adc@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +0 -0
index 51ca4b4d4c21..6dfec68ac865 100644
@@ -80,7 +80,7 @@
 		#size-cells = <0>;
 	};
 
Quoted 8 lines

arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi line 83

Quoted 2 lines
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +1 -1
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {

OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm.

Quoted 2 lines

Vignesh: are you ok with this, care to comment?

On K3 SoCs, ADC IP is reuse from AM335x but just lacks resistive touchscreen interfaces. So, existing AM335x ADC driver is being reused for K3 devices as well. Unfortunately, ADC driver cannot be used as standalone and is dependent on MFD parent to be present... Above node represents the MFD parent and ADC itself is the child node (see arch/arm64/boot/dts/ti/k3-am654-base-board.dts). So, I recommend that we keep this node's name as tscadc in order to avoid having same name for parent and child node which will be quite confusing.

Regards
Vignesh

author maintainer
#17 lore raw

Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

Quoted 38 lines · Vignesh Raghavendra

Hi Nishanth,

Quoted 32 lines · Nishanth Menon
Quoted 21 lines · Suman Anna
Quoted 20 lines · Nishanth Menon

Use adc@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +0 -0
index 51ca4b4d4c21..6dfec68ac865 100644
@@ -80,7 +80,7 @@
 		#size-cells = <0>;
 	};
 
Quoted 8 lines

arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi line 83

Quoted 2 lines
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +1 -1
-	tscadc0: tscadc@40200000 {
+	tscadc0: adc@40200000 {

OK with these changes, since these seem to be only have the adc child nodes. This node is essentially a parent node for touchscreen and adc child nodes. The driver is currently looking for "tsc" on touchscreen child nodes, but none of the K3 SoCs have them atm.

Quoted 2 lines

Vignesh: are you ok with this, care to comment?

Quoted 8 lines

On K3 SoCs, ADC IP is reuse from AM335x but just lacks resistive touchscreen interfaces. So, existing AM335x ADC driver is being reused for K3 devices as well. Unfortunately, ADC driver cannot be used as standalone and is dependent on MFD parent to be present... Above node represents the MFD parent and ADC itself is the child node (see arch/arm64/boot/dts/ti/k3-am654-base-board.dts). So, I recommend that we keep this node's name as tscadc in order to avoid having same name for parent and child node which will be quite confusing.

Thanks for your feedback. I will drop this patch.

Signature · 8 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#31 lore raw

PATCH v2 4/8 arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names

In reply to Nishanth Menon

serdes and ehrpwm_tbclk nodes should be using clock@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Change:
v2: added ehrpwm_tbclk based on review comments.
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -3
index a2fc508e59a6..63a1299cb0b2 100644
@@ -327,12 +327,12 @@
 			reg = <0x00000210 0x4>;
 		};
 
-		serdes0_clk: serdes_clk@4080 {
+		serdes0_clk: clock@4080 {
 			compatible = "syscon";
 			reg = <0x00004080 0x4>;
 		};
 
-		serdes1_clk: serdes_clk@4090 {
+		serdes1_clk: clock@4090 {
 			compatible = "syscon";
 			reg = <0x00004090 0x4>;
 		};
@@ -349,7 +349,7 @@
 			reg = <0x0000041e0 0x14>;
 		};
 
-		ehrpwm_tbclk: syscon@4140 {
+		ehrpwm_tbclk: clock@4140 {
 			compatible = "ti,am654-ehrpwm-tbclk", "syscon";
 			reg = <0x4140 0x18>;
 			#clock-cells = <1>;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#25 lore raw

PATCH v2 2/8 arm64: dts: ti: k3-am65-main: Use lower case hexadecimal

In reply to Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

---
Change:
v2: - new

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 76e0edc4ad5c..d53d1ead4bb6 100644
@@ -344,9 +344,9 @@
 					<0x4090 0x3>; /* SERDES1 lane select */
 		};
 
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
+		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41e0 {
 			compatible = "syscon";
-			reg = <0x0000041E0 0x14>;
+			reg = <0x0000041e0 0x14>;
 		};
 
 		ehrpwm_tbclk: syscon@4140 {
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#28 lore raw

v2 cover arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings + hex usage

In reply to Nishanth Menon

Hi,

This is a respin of v2 of the series posted as [1].

As part of this cleanup, I ran a cross check of nodes that are part of K3 as of right now, Vs what is "generic" definition as per 0.3 dt specification [2].

Changes in v2:
- Based off 20200903
- Picked up Acks and reviewed-by from previous versions (please comment if you disagree).
- Dropped tsadc rename [3] based on review
- Added 2 patches to fixup hexadecimal usage caught as part of review
- few additional fixups.

Nishanth Menon (8):
arm64: dts: ti: k3-j721e: Use lower case hexadecimal
arm64: dts: ti: k3-am65-main: Use lower case hexadecimal
arm64: dts: ti: k3-am65*: Use generic gpio for node names
arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names
arm64: dts: ti: k3-*: Use generic pinctrl for node names
arm64: dts: ti: k3-am65-base-board Use generic camera for node name
instead of ov5640
arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for
node name
arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 22 +++++++++----------
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi       |  4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi    |  6 ++---
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 18 +++++++--------
 .../dts/ti/k3-am654-industrial-thermal.dtsi   | 12 +++++-----
 .../dts/ti/k3-j721e-common-proc-board.dts     | 18 +++++++--------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     |  8 +++----
 .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      |  4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi   |  2 +-
 arch/arm64/boot/dts/ti/k3-j721e.dtsi          |  2 +-
 10 files changed, 48 insertions(+), 48 deletions(-)

[1] v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://pastebin.ubuntu.com/p/Z5zGQydH3G/
[3] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#30 lore raw

PATCH v2 3/8 arm64: dts: ti: k3-am65*: Use generic gpio for node names

In reply to Nishanth Menon

Use gpio@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Change:
v2: No functional change, picked reviews and acks
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi   | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index d53d1ead4bb6..a2fc508e59a6 100644
@@ -661,7 +661,7 @@
 		};
 	};
 
-	main_gpio0:  main_gpio0@600000 {
+	main_gpio0: gpio@600000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x600000 0x0 0x100>;
 		gpio-controller;
@@ -676,7 +676,7 @@
 		clock-names = "gpio";
 	};
 
-	main_gpio1:  main_gpio1@601000 {
+	main_gpio1: gpio@601000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x0 0x601000 0x0 0x100>;
 		gpio-controller;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index a1ffe88d9664..0765700a8ba8 100644
@@ -80,7 +80,7 @@
 		ti,interrupt-ranges = <0 712 16>;
 	};
 
-	wkup_gpio0: wkup_gpio0@42110000 {
+	wkup_gpio0: gpio@42110000 {
 		compatible = "ti,am654-gpio", "ti,keystone-gpio";
 		reg = <0x42110000 0x100>;
 		gpio-controller;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#34 lore raw

PATCH v2 6/8 arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640

In reply to Nishanth Menon

Use camera@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Changes:
v2: None (picked acks/reviews)
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +1 -1
index b8a8a0fcb8af..86c9074cb070 100644
@@ -257,7 +257,7 @@
 	pinctrl-0 = <&main_i2c1_pins_default>;
 	clock-frequency = <400000>;
 
-	ov5640@3c {
+	ov5640: camera@3c {
 		compatible = "ovti,ov5640";
 		reg = <0x3c>;
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#35 lore raw

PATCH v2 7/8 arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

In reply to Nishanth Menon

Use temperature-sensor@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Changes:
v2: None (picked acks/reviews)
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index bb498be2f0a4..ed42f13e7663 100644
@@ -95,7 +95,7 @@
 		clock-names = "gpio";
 	};
 
-	wkup_vtm0: thermal@42050000 {
+	wkup_vtm0: temperature-sensor@42050000 {
 		compatible = "ti,am654-vtm";
 		reg = <0x42050000 0x25c>;
 		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#22 lore raw

PATCH v2 1/8 arm64: dts: ti: k3-j721e: Use lower case hexadecimal

In reply to Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

---
Change:
v2: - new

 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721e.dtsi +1 -1
index f787aa73aaae..1bb8235d9ffb 100644
@@ -127,7 +127,7 @@
 		ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
 			 <0x00 0x00600000 0x00 0x00600000 0x00 0x00031100>, /* GPIO */
 			 <0x00 0x00900000 0x00 0x00900000 0x00 0x00012000>, /* serdes */
-			 <0x00 0x00A40000 0x00 0x00A40000 0x00 0x00000800>, /* timesync router */
+			 <0x00 0x00a40000 0x00 0x00a40000 0x00 0x00000800>, /* timesync router */
 			 <0x00 0x06000000 0x00 0x06000000 0x00 0x00400000>, /* USBSS0 */
 			 <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */
 			 <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#37 lore raw

PATCH v2 8/8 arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings

In reply to Nishanth Menon

Building with W=2 throws up a bunch of easy to fixup warnings.. node_name_chars_strict is one of them.. Knock those out.

---
Changes:
v2: None (rebase) (picked acks/reviews) - comment on hex usage split as
seperate patch
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       |  6 +++---
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi        |  4 ++--
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++--------
 .../dts/ti/k3-am654-industrial-thermal.dtsi    | 12 ++++++------
 .../boot/dts/ti/k3-j721e-common-proc-board.dts | 18 +++++++++---------
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi      |  6 +++---
 .../arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi |  2 +-
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi    |  2 +-
 8 files changed, 33 insertions(+), 33 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +3 -3
index 1dd488cb15c6..533525229a8d 100644
@@ -305,7 +305,7 @@
 		no-1-8-v;
 	};
 
-	scm_conf: scm_conf@100000 {
+	scm_conf: scm-conf@100000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
@@ -344,7 +344,7 @@
 					<0x4090 0x3>; /* SERDES1 lane select */
 		};
 
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41e0 {
+		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
 			compatible = "syscon";
 			reg = <0x0000041e0 0x14>;
 		};
@@ -445,7 +445,7 @@
 		ti,interrupt-ranges = <0 392 32>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 51ca4b4d4c21..29aaf8dca6f6 100644
@@ -6,7 +6,7 @@
  */
 
 &cbass_mcu {
-	mcu_conf: scm_conf@40f00000 {
+	mcu_conf: scm-conf@40f00000 {
 		compatible = "syscon", "simple-mfd";
 		reg = <0x0 0x40f00000 0x0 0x20000>;
 		#address-cells = <1>;
@@ -116,7 +116,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +8 -8
index 86c9074cb070..d12dd89f3405 100644
@@ -29,7 +29,7 @@
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
-		secure_ddr: secure_ddr@9e800000 {
+		secure_ddr: secure-ddr@9e800000 {
 			reg = <0 0x9e800000 0 0x01800000>; /* for OP-TEE */
 			alignment = <0x1000>;
 			no-map;
@@ -70,14 +70,14 @@
 		>;
 	};
 
-	push_button_pins_default: push_button__pins_default {
+	push_button_pins_default: push-button-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0030, PIN_INPUT, 7) /* (R5) WKUP_GPIO0_24 */
 			AM65X_WKUP_IOPAD(0x003c, PIN_INPUT, 7) /* (P2) WKUP_GPIO0_27 */
 		>;
 	};
 
-	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins_default {
+	mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* (V1) MCU_OSPI0_CLK */
 			AM65X_WKUP_IOPAD(0x0008, PIN_INPUT, 0)	 /* (U2) MCU_OSPI0_DQS */
@@ -93,13 +93,13 @@
 		>;
 	};
 
-	wkup_pca554_default: wkup_pca554_default {
+	wkup_pca554_default: wkup-pca554-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0034, PIN_INPUT, 7) /* (T1) MCU_OSPI1_CLK.WKUP_GPIO0_25 */
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* (N4) MCU_RGMII1_TX_CTL */
 			AM65X_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* (N5) MCU_RGMII1_RX_CTL */
@@ -116,7 +116,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
 			AM65X_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02d4, PIN_INPUT_PULLDOWN, 0) /* (C27) MMC1_CLK */
 			AM65X_IOPAD(0x02d8, PIN_INPUT_PULLUP, 0) /* (C28) MMC1_CMD */
@@ -180,7 +180,7 @@
 		>;
 	};
 
-	usb1_pins_default: usb1_pins_default {
+	usb1_pins_default: usb1-pins-default {
 		pinctrl-single,pins = <
 			AM65X_IOPAD(0x02c0, PIN_OUTPUT, 0) /* (AC8) USB1_DRVVBUS */
 		>;
arch/arm64/boot/dts/ti/k3-am654-industrial-thermal.dtsi +6 -6
index cdc3d40c3f60..9021c738056b 100644
@@ -2,13 +2,13 @@
 
 #include <dt-bindings/thermal/thermal.h>
 
-mpu0_thermal: mpu0_thermal {
+mpu0_thermal: mpu0-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 0>;
 
 	trips {
-		mpu0_crit: mpu0_crit {
+		mpu0_crit: mpu0-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -16,13 +16,13 @@ mpu0_thermal: mpu0_thermal {
 	};
 };
 
-mpu1_thermal: mpu1_thermal {
+mpu1_thermal: mpu1-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 1>;
 
 	trips {
-		mpu1_crit: mpu1_crit {
+		mpu1_crit: mpu1-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
@@ -30,13 +30,13 @@ mpu1_thermal: mpu1_thermal {
 	};
 };
 
-mcu_thermal: mcu_thermal {
+mcu_thermal: mcu-thermal {
 	polling-delay-passive = <250>; /* milliseconds */
 	polling-delay = <500>; /* milliseconds */
 	thermal-sensors = <&wkup_vtm0 2>;
 
 	trips {
-		mcu_crit: mcu_crit {
+		mcu_crit: mcu-crit {
 			temperature = <125000>; /* milliCelsius */
 			hysteresis = <2000>; /* milliCelsius */
 			type = "critical";
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +9 -9
index c355692796a9..648267284582 100644
@@ -86,13 +86,13 @@
 };
 
 &main_pmx0 {
-	sw10_button_pins_default: sw10_button_pins_default {
+	sw10_button_pins_default: sw10-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x0, PIN_INPUT, 7) /* (AC18) EXTINTn.GPIO0_0 */
 		>;
 	};
 
-	main_mmc1_pins_default: main_mmc1_pins_default {
+	main_mmc1_pins_default: main-mmc1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x254, PIN_INPUT, 0) /* (R29) MMC1_CMD */
 			J721E_IOPAD(0x250, PIN_INPUT, 0) /* (P25) MMC1_CLK */
@@ -106,14 +106,14 @@
 		>;
 	};
 
-	main_usbss0_pins_default: main_usbss0_pins_default {
+	main_usbss0_pins_default: main-usbss0-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
 			J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
 		>;
 	};
 
-	main_usbss1_pins_default: main_usbss1_pins_default {
+	main_usbss1_pins_default: main-usbss1-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */
 		>;
@@ -153,7 +153,7 @@
 		>;
 	};
 
-	mcasp10_pins_default: mcasp10_pins_default {
+	mcasp10_pins_default: mcasp10-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x158, PIN_OUTPUT_PULLDOWN, 12) /* (U23) RGMII5_TX_CTL.MCASP10_ACLKX */
 			J721E_IOPAD(0x15c, PIN_OUTPUT_PULLDOWN, 12) /* (U26) RGMII5_RX_CTL.MCASP10_AFSX */
@@ -167,7 +167,7 @@
 		>;
 	};
 
-	audi_ext_refclk2_pins_default: audi_ext_refclk2_pins_default {
+	audi_ext_refclk2_pins_default: audi-ext-refclk2-pins-default {
 		pinctrl-single,pins = <
 			J721E_IOPAD(0x1a4, PIN_OUTPUT, 3) /* (W26) RGMII6_RXC.AUDIO_EXT_REFCLK2 */
 		>;
@@ -175,7 +175,7 @@
 };
 
 &wkup_pmx0 {
-	sw11_button_pins_default: sw11_button_pins_default {
+	sw11_button_pins_default: sw11-button-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xcc, PIN_INPUT, 7) /* (G28) WKUP_GPIO0_7 */
 		>;
@@ -194,7 +194,7 @@
 		>;
 	};
 
-	mcu_cpsw_pins_default: mcu_cpsw_pins_default {
+	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x0058, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
 			J721E_WKUP_IOPAD(0x005c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
@@ -211,7 +211,7 @@
 		>;
 	};
 
-	mcu_mdio_pins_default: mcu_mdio1_pins_default {
+	mcu_mdio_pins_default: mcu-mdio1-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0x008c, PIN_OUTPUT, 0) /* MCU_MDIO0_MDC */
 			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_MDIO0_MDIO */
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +3 -3
index 1d2a7c05b6f3..ea57d07777ba 100644
@@ -86,7 +86,7 @@
 		ti,interrupt-ranges = <8 392 56>;
 	};
 
-	main_navss {
+	main-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
@@ -888,7 +888,7 @@
 		no-1-8-v;
 	};
 
-	usbss0: cdns_usb@4104000 {
+	usbss0: cdns-usb@4104000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4104000 0x00 0x100>;
 		dma-coherent;
@@ -918,7 +918,7 @@
 		};
 	};
 
-	usbss1: cdns_usb@4114000 {
+	usbss1: cdns-usb@4114000 {
 		compatible = "ti,j721e-usb";
 		reg = <0x00 0x4114000 0x00 0x100>;
 		dma-coherent;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index 9ad0266598ad..e581cb1d87ee 100644
@@ -249,7 +249,7 @@
 		};
 	};
 
-	mcu_navss {
+	mcu-navss {
 		compatible = "simple-mfd";
 		#address-cells = <2>;
 		#size-cells = <2>;
arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi +1 -1
index d69d90c8b5e3..5dc3ba739131 100644
@@ -71,7 +71,7 @@
 };
 
 &wkup_pmx0 {
-	wkup_i2c0_pins_default: wkup_i2c0_pins_default {
+	wkup_i2c0_pins_default: wkup-i2c0-pins-default {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xf8, PIN_INPUT_PULLUP, 0) /* (J25) WKUP_I2C0_SCL */
 			J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#33 lore raw

PATCH v2 5/8 arm64: dts: ti: k3-*: Use generic pinctrl for node names

In reply to Nishanth Menon

Use pinctrl@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Changes:
v2: None (picked acks/reviews)
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 4 ++--
 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi      | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index 63a1299cb0b2..1dd488cb15c6 100644
@@ -134,7 +134,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c000 0x0 0x2e4>;
 		#pinctrl-cells = <1>;
@@ -142,7 +142,7 @@
 		pinctrl-single,function-mask = <0xffffffff>;
 	};
 
-	main_pmx1: pinmux@11c2e8 {
+	main_pmx1: pinctrl@11c2e8 {
 		compatible = "pinctrl-single";
 		reg = <0x0 0x11c2e8 0x0 0x24>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index 0765700a8ba8..bb498be2f0a4 100644
@@ -39,7 +39,7 @@
 		reg = <0x43000014 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		reg = <0x4301c000 0x118>;
 		#pinctrl-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -1
index 00a36a14efe7..1d2a7c05b6f3 100644
@@ -327,7 +327,7 @@
 		};
 	};
 
-	main_pmx0: pinmux@11c000 {
+	main_pmx0: pinctrl@11c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x0 0x11c000 0x0 0x2b4>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index c4a48e8d420a..9ad0266598ad 100644
@@ -53,7 +53,7 @@
 		reg = <0x0 0x43000014 0x0 0x4>;
 	};
 
-	wkup_pmx0: pinmux@4301c000 {
+	wkup_pmx0: pinctrl@4301c000 {
 		compatible = "pinctrl-single";
 		/* Proxy 0 addressing */
 		reg = <0x00 0x4301c000 0x00 0x178>;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by on v2 7/8
#36 lore raw

Re: [PATCH V2 7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

In reply to Nishanth Menon
Quoted 10 lines · Nishanth Menon

Use temperature-sensor@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

Quoted 14 lines

---
Changes:
v2: None (picked acks/reviews)
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
index bb498be2f0a4..ed42f13e7663 100644

arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi line 101

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
@@ -95,7 +95,7 @@
 		clock-names = "gpio";
 	};
 
-	wkup_vtm0: thermal@42050000 {
+	wkup_vtm0: temperature-sensor@42050000 {
 		compatible = "ti,am654-vtm";
 		reg = <0x42050000 0x25c>;
 		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Acked-by on v2 4/8
#32 lore raw

Re: [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names

In reply to Nishanth Menon
Quoted 39 lines · Nishanth Menon

serdes and ehrpwm_tbclk nodes should be using clock@ naming for nodes following standard conventions of device tree (section 2.2.2 Generic Names recommendation in [1]).

[1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3

---
Change:
v2: added ehrpwm_tbclk based on review comments.
v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
index a2fc508e59a6..63a1299cb0b2 100644
@@ -327,12 +327,12 @@
 			reg = <0x00000210 0x4>;
 		};
 
-		serdes0_clk: serdes_clk@4080 {
+		serdes0_clk: clock@4080 {
 			compatible = "syscon";
 			reg = <0x00004080 0x4>;
 		};
 
-		serdes1_clk: serdes_clk@4090 {
+		serdes1_clk: clock@4090 {
 			compatible = "syscon";
 			reg = <0x00004090 0x4>;
 		};

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 355

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
@@ -349,7 +349,7 @@
 			reg = <0x0000041e0 0x14>;
 		};
 
-		ehrpwm_tbclk: syscon@4140 {
+		ehrpwm_tbclk: clock@4140 {
 			compatible = "ti,am654-ehrpwm-tbclk", "syscon";
 			reg = <0x4140 0x18>;
 			#clock-cells = <1>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#23 lore raw

Re: [PATCH V2 1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal

In reply to Nishanth Menon
Quoted 4 lines · Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

Quoted 13 lines

---
Change:
v2: - new

 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721e.dtsi +0 -0
index f787aa73aaae..1bb8235d9ffb 100644

arch/arm64/boot/dts/ti/k3-j721e.dtsi line 133

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +1 -1
@@ -127,7 +127,7 @@
 		ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
 			 <0x00 0x00600000 0x00 0x00600000 0x00 0x00031100>, /* GPIO */
 			 <0x00 0x00900000 0x00 0x00900000 0x00 0x00012000>, /* serdes */
-			 <0x00 0x00A40000 0x00 0x00A40000 0x00 0x00000800>, /* timesync router */
+			 <0x00 0x00a40000 0x00 0x00a40000 0x00 0x00000800>, /* timesync router */
 			 <0x00 0x06000000 0x00 0x06000000 0x00 0x00400000>, /* USBSS0 */
 			 <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */
 			 <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Acked-by on v2 2/8
#26 lore raw

Re: [PATCH V2 2/8] arm64: dts: ti: k3-am65-main: Use lower case hexadecimal

In reply to Nishanth Menon
Quoted 4 lines · Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

Quoted 14 lines

---
Change:
v2: - new

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -0
index 76e0edc4ad5c..d53d1ead4bb6 100644
@@ -344,9 +344,9 @@
 					<0x4090 0x3>; /* SERDES1 lane select */

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 352

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +2 -2
 		};
 
-		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
+		dss_oldi_io_ctrl: dss_oldi_io_ctrl@41e0 {
 			compatible = "syscon";
-			reg = <0x0000041E0 0x14>;
+			reg = <0x0000041e0 0x14>;
 		};
 
 		ehrpwm_tbclk: syscon@4140 {

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 1/8
#24 lore raw

Re: [PATCH V2 1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal

In reply to Nishanth Menon
Quoted 4 lines · Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

Thanks and regards,
Lokesh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 2/8
#27 lore raw

Re: [PATCH V2 2/8] arm64: dts: ti: k3-am65-main: Use lower case hexadecimal

In reply to Nishanth Menon
Quoted 4 lines · Nishanth Menon

Device tree convention uses lower case a-f for hexadecimals. Fix the same.

Thanks and regards,
Lokesh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer Applied
#29 lore raw

Re: [PATCH V2 0/8] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings + hex usage

In reply to Nishanth Menon
Quoted 8 lines · Nishanth Menon

Hi,

This is a respin of v2 of the series posted as [1].

As part of this cleanup, I ran a cross check of nodes that are part of K3 as of right now, Vs what is "generic" definition as per 0.3 dt specification [2].

Quoted 7 lines

Changes in v2:
- Based off 20200903
- Picked up Acks and reviewed-by from previous versions (please comment if you disagree).
- Dropped tsadc rename [3] based on review
- Added 2 patches to fixup hexadecimal usage caught as part of review
- few additional fixups.

I have applied the following to branch ti-k3-next on [1].

[1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal

      commit: 1aedefe13ba263d0d7d1cfbb38aadebbd5bab34e
[2/8] arm64: dts: ti: k3-am65-main: Use lower case hexadecimal
      commit: 05e393c596c4495d79f0cbeacb0f0a0e0b6f89d5
[3/8] arm64: dts: ti: k3-am65*: Use generic gpio for node names
      commit: 91e5f404e42bc189bb0e447d30041de737ad24bf
[4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names
      commit: 86e67b591e6d993d98567143451883a5618c196e
[5/8] arm64: dts: ti: k3-*: Use generic pinctrl for node names
      commit: dcccf77067e4274953e8944d9730bb7ae2964c28
[6/8] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640
      commit: 4c19fb9ce266561ab122880a02e873ee8c3668e4
[7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name
      commit: 9a8ecd414322ceb377cecb4795e3f3d7d7020952
[8/8] arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings
      commit: e5c956c4f36cdd59e775f2285af9a1683374c5a5

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git

Signature · 8 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel