Skip to contentSkip to conversation

scsi: sym53c8xx_2: Delete useless if-else in sym_xerr_cam_status

PATCH Applied Ye Bin 2 participants 3 messages Sep 2, 2020 – Sep 22, 2020

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 scsi: sym53c8xx_2: Delete useless if-else in sym_xerr_cam_status

Only (x_status & XE_PARITY_ERR) is true we set cam_status = DID_PARITY, other condition we set cam_status = DID_ERROR. So delete useless if-else.

---
 drivers/scsi/sym53c8xx_2/sym_glue.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/scsi/sym53c8xx_2/sym_glue.c +1 -5
index 28edb6e53ea2..d9a045f9858c 100644
@@ -156,12 +156,8 @@ void sym_xpt_async_bus_reset(struct sym_hcb *np)
 static int sym_xerr_cam_status(int cam_status, int x_status)
 {
 	if (x_status) {
-		if	(x_status & XE_PARITY_ERR)
+		if (x_status & XE_PARITY_ERR)
 			cam_status = DID_PARITY;
-		else if	(x_status &(XE_EXTRA_DATA|XE_SODL_UNRUN|XE_SWIDE_OVRUN))
-			cam_status = DID_ERROR;
-		else if	(x_status & XE_BAD_PHASE)
-			cam_status = DID_ERROR;
 		else
 			cam_status = DID_ERROR;
 	}
Signature · 1 line
2.25.4
#1 lore raw

Ye,

Quoted 2 lines

Only (x_status & XE_PARITY_ERR) is true we set cam_status = DID_PARITY, other condition we set cam_status = DID_ERROR. So delete useless if-else.

Applied to 5.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Ye Bin
Quoted 2 lines · Ye Bin

Only (x_status & XE_PARITY_ERR) is true we set cam_status = DID_PARITY, other condition we set cam_status = DID_ERROR. So delete useless if-else.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: sym53c8xx_2: Delete unnecessary else-if in sym_xerr_cam_status()

      https://git.kernel.org/mkp/scsi/c/bb1932dbb83a
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering