Skip to contentSkip to conversation

xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files

PATCH Superseded Darrick J. Wong 1 participant 2 messages Sep 2, 2020 XFS filesystem

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files

From: Darrick J. Wong <[email protected]>

The realtime flag only applies to the data fork, so don't use the realtime block number checks on the attr fork of a realtime file.

Fixes 30b0984d9117 ("xfs: refactor bmap record validation")
---
 fs/xfs/libxfs/xfs_bmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/libxfs/xfs_bmap.c +1 -1
index ce2e702b6b43..d35250c9bb07 100644
@@ -6310,7 +6310,7 @@ xfs_bmap_validate_extent_raw(
 	xfs_fsblock_t		endfsb;
 
 	endfsb = irec->br_startblock + irec->br_blockcount - 1;
-	if (isrt) {
+	if (isrt && whichfork == XFS_DATA_FORK) {
 		if (!xfs_verify_rtbno(mp, irec->br_startblock))
 			return __this_address;
 		if (!xfs_verify_rtbno(mp, endfsb))
author NAK
#1 lore raw
Quoted 7 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

The realtime flag only applies to the data fork, so don't use the realtime block number checks on the attr fork of a realtime file.

Fixes 30b0984d9117 ("xfs: refactor bmap record validation")

NAK, I should've sent this from my stable tree, not my dev tree.

--D

Quoted 17 lines
---
 fs/xfs/libxfs/xfs_bmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/libxfs/xfs_bmap.c +1 -1
index ce2e702b6b43..d35250c9bb07 100644
@@ -6310,7 +6310,7 @@ xfs_bmap_validate_extent_raw(
 	xfs_fsblock_t		endfsb;
 
 	endfsb = irec->br_startblock + irec->br_blockcount - 1;
-	if (isrt) {
+	if (isrt && whichfork == XFS_DATA_FORK) {
 		if (!xfs_verify_rtbno(mp, irec->br_startblock))
 			return __this_address;
 		if (!xfs_verify_rtbno(mp, endfsb))