drm/mediatek: Use CPU when fail to get cmdq event
Subsystems (3)
Chun-Kuang Hu
maintainerPATCH 1/1 drm/mediatek: Use CPU when fail to get cmdq event
Even though cmdq client is created successfully, without the cmdq event, cmdq could not work correctly, so use CPU when fail to get cmdq event.
Fixes 60fa8c13ab1a ("drm/mediatek: Move gce event property to mutex device node")
Signed-off-by Chun-Kuang Hu <[email protected]>
--- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)
drivers/gpu/drm/mediatek/mtk_drm_crtc.c +13 -7
@@ -831,13 +831,19 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, drm_crtc_index(&mtk_crtc->base)); mtk_crtc->cmdq_client = NULL; } - ret =of_property_read_u32_index (priv->mutex_node, -"mediatek,gce-events" , -drm_crtc_index (&mtk_crtc->base), - &mtk_crtc->cmdq_event); -if (ret) -dev_dbg (dev,"mtk_crtc %d failed to get mediatek,gce-events property\n" , -drm_crtc_index (&mtk_crtc->base)); + +if (mtk_crtc->cmdq_client) { + ret =of_property_read_u32_index (priv->mutex_node, +"mediatek,gce-events" , +drm_crtc_index (&mtk_crtc->base), + &mtk_crtc->cmdq_event); +if (ret) { +dev_dbg (dev,"mtk_crtc %d failed to get mediatek,gce-events property\n" , +drm_crtc_index (&mtk_crtc->base)); +cmdq_mbox_destroy (mtk_crtc->cmdq_client); + mtk_crtc->cmdq_client =NULL ; + } + }#endif return 0 ; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chun-Kuang Hu <[email protected]> 於 2020年9月3日 週四 上午6:06寫道:
Quoted 3 lines
Even though cmdq client is created successfully, without the cmdq event, cmdq could not work correctly, so use CPU when fail to get cmdq event.
Applied to mediatek-drm-fixes [1].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes
Regards,
Chun-Kuang.
Quoted 39 lines
Fixes 60fa8c13ab1a ("drm/mediatek: Move gce event property to mutex device node")Signed-off-by Chun-Kuang Hu <[email protected]>--- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)drivers/gpu/drm/mediatek/mtk_drm_crtc.c +13
-8@@ -831,13 +831,19 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, drm_crtc_index(&mtk_crtc->base)); mtk_crtc->cmdq_client = NULL; } - ret =of_property_read_u32_index (priv->mutex_node, -"mediatek,gce-events" , -drm_crtc_index (&mtk_crtc->base), - &mtk_crtc->cmdq_event); -if (ret) -dev_dbg (dev,"mtk_crtc %d failed to get mediatek,gce-events property\n" , -drm_crtc_index (&mtk_crtc->base)); + +if (mtk_crtc->cmdq_client) { + ret =of_property_read_u32_index (priv->mutex_node, +"mediatek,gce-events" , +drm_crtc_index (&mtk_crtc->base), + &mtk_crtc->cmdq_event); +if (ret) { +dev_dbg (dev,"mtk_crtc %d failed to get mediatek,gce-events property\n" , +drm_crtc_index (&mtk_crtc->base)); +cmdq_mbox_destroy (mtk_crtc->cmdq_client); + mtk_crtc->cmdq_client =NULL ; + } + }#endif return 0 ; } --
Quoted 2 lines
2.17.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel