Skip to contentSkip to conversation

mmc: s3cmci: Drop unused variables in dbg_dumpregs

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Sep 3, 2020 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: s3cmci: Drop unused variables in dbg_dumpregs

The 'imask' and 'bsize' are not used in dbg_dumpregs:

drivers/mmc/host/s3cmci.c:149:36: warning: variable 'imask' set but not used [-Wunused-but-set-variable] drivers/mmc/host/s3cmci.c:148:63: warning: variable 'bsize' set but not used [-Wunused-but-set-variable]

---
 drivers/mmc/host/s3cmci.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/s3cmci.c +2 -4
index ac94f926624d..40329aeacfdf 100644
@@ -145,8 +145,8 @@ static void s3cmci_reset(struct s3cmci_host *host);
 
 static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
 {
-	u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer, bsize;
-	u32 datcon, datcnt, datsta, fsta, imask;
+	u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer;
+	u32 datcon, datcnt, datsta, fsta;
 
 	con 	= readl(host->base + S3C2410_SDICON);
 	pre 	= readl(host->base + S3C2410_SDIPRE);
@@ -158,12 +158,10 @@ static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
 	r2 	= readl(host->base + S3C2410_SDIRSP2);
 	r3 	= readl(host->base + S3C2410_SDIRSP3);
 	timer 	= readl(host->base + S3C2410_SDITIMER);
-	bsize 	= readl(host->base + S3C2410_SDIBSIZE);
 	datcon 	= readl(host->base + S3C2410_SDIDCON);
 	datcnt 	= readl(host->base + S3C2410_SDIDCNT);
 	datsta 	= readl(host->base + S3C2410_SDIDSTA);
 	fsta 	= readl(host->base + S3C2410_SDIFSTA);
-	imask   = readl(host->base + host->sdiimsk);
 
 	dbg(host, dbg_debug, "%s  CON:[%08x]  PRE:[%08x]  TMR:[%08x]\n",
 				prefix, con, pre, timer);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Krzysztof Kozlowski

The 'imask' and 'bsize' are not used in dbg_dumpregs:

drivers/mmc/host/s3cmci.c:149:36: warning: variable 'imask' set but not used [-Wunused-but-set-variable] drivers/mmc/host/s3cmci.c:148:63: warning: variable 'bsize' set but not used [-Wunused-but-set-variable]

Applied for next, thanks!

Kind regards
Uffe

Quoted 35 lines
---
 drivers/mmc/host/s3cmci.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/s3cmci.c +2 -5
index ac94f926624d..40329aeacfdf 100644
@@ -145,8 +145,8 @@ static void s3cmci_reset(struct s3cmci_host *host);
 
 static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
 {
-       u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer, bsize;
-       u32 datcon, datcnt, datsta, fsta, imask;
+       u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer;
+       u32 datcon, datcnt, datsta, fsta;
 
        con     = readl(host->base + S3C2410_SDICON);
        pre     = readl(host->base + S3C2410_SDIPRE);
@@ -158,12 +158,10 @@ static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
        r2      = readl(host->base + S3C2410_SDIRSP2);
        r3      = readl(host->base + S3C2410_SDIRSP3);
        timer   = readl(host->base + S3C2410_SDITIMER);
-       bsize   = readl(host->base + S3C2410_SDIBSIZE);
        datcon  = readl(host->base + S3C2410_SDIDCON);
        datcnt  = readl(host->base + S3C2410_SDIDCNT);
        datsta  = readl(host->base + S3C2410_SDIDSTA);
        fsta    = readl(host->base + S3C2410_SDIFSTA);
-       imask   = readl(host->base + host->sdiimsk);
 
        dbg(host, dbg_debug, "%s  CON:[%08x]  PRE:[%08x]  TMR:[%08x]\n",
                                prefix, con, pre, timer);
--

2.17.1