Skip to contentSkip to conversation

media: platform: vpdma.c: fix comparison to bool

PATCH New Daniel W. S. Almeida 1 participant 1 message Sep 3, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 media: platform: vpdma.c: fix comparison to bool

From: "Daniel W. S. Almeida" <[email protected]>

Fix the following coccinelle report:

drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to bool

Found using - Coccinelle (http://coccinelle.lip6.fr)

---
 drivers/media/platform/ti-vpe/vpdma.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/media/platform/ti-vpe/vpdma.c +4 -5
index 2e5148ae7a0f..5893917ce50d 100644
@@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
 	unsigned long flags;
 
 	spin_lock_irqsave(&vpdma->lock, flags);
-	for (i = 0; i < VPDMA_MAX_NUM_LIST &&
-	    vpdma->hwlist_used[i] == true; i++)
-		;
-
-	if (i < VPDMA_MAX_NUM_LIST) {
+	for (i = 0; i < VPDMA_MAX_NUM_LIST; i++) {
+		if (vpdma->hwlist_used[i])
+			continue;
 		list_num = i;
 		vpdma->hwlist_used[i] = true;
 		vpdma->hwlist_priv[i] = priv;
+		break;
 	}
 	spin_unlock_irqrestore(&vpdma->lock, flags);
 
Signature · 1 line
2.28.0