Skip to contentSkip to conversation

dt-bindings: gpu: arm,mali-midgard: Add missing properties

PATCH Applied Krzysztof Kozlowski 2 participants 12 messages Sep 3, 2020 – Sep 16, 2020

Subsystems (4)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v2 1/6 dt-bindings: gpu: arm,mali-midgard: Add missing properties

Add common properties appearing in DTSes (opp-table) to fix dtbs_check warnings like:

arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+'

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +1 -0
index 80d519a76db2..e9c42b59f30f 100644
@@ -74,6 +74,7 @@ properties:
       - const: bus
 
   mali-supply: true
+  opp-table: true
 
   power-domains:
     maxItems: 1
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH v2 2/6 dt-bindings: gpu: arm,mali-utgard: Add missing properties

Add common properties appearing in DTSes (opp-table) to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos4210-i9100.dt.yaml: gpu@13000000:
'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+'

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml +2 -0
index d4d785790eaa..30d421e6ba38 100644
@@ -101,6 +101,8 @@ properties:
 
   mali-supply: true
 
+  opp-table: true
+
   power-domains:
     maxItems: 1
 
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#3 lore raw

PATCH v2 3/6 dt-bindings: gpu: arm,mali-utgard: Correct Maxime's email

In reply to Krzysztof Kozlowski

Update the address of Maxime Ripard as one in @free-electrons.com does not work.

---

Changes since v1:
1. Add Ack

---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml +1 -1
index 30d421e6ba38..eceaa176bd57 100644
@@ -8,7 +8,7 @@ title: ARM Mali Utgard GPU
 
 maintainers:
   - Rob Herring <[email protected]>
-  - Maxime Ripard <[email protected]>
+  - Maxime Ripard <[email protected]>
   - Heiko Stuebner <[email protected]>
 
 properties:
Signature · 1 line
2.17.1
author maintainer
#5 lore raw

PATCH v2 4/6 dt-bindings: gpu: samsung-rotator: Add missing properties

In reply to Krzysztof Kozlowski

Add common properties appearing in DTSes (iommus, power-domains) to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rotator@12810000:
'iommus', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml +3 -0
index 665c6e3b31d3..f480174fe0d3 100644
@@ -22,6 +22,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  iommus: true
+  power-domains: true
+
   clocks:
     maxItems: 1
 
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#7 lore raw

PATCH v2 5/6 ARM: dts: exynos: Align OPP table name with dt-schema

In reply to Krzysztof Kozlowski

Device tree nodes should have hyphens instead of underscores. This is also expected by the bindings.

---

Changes since v1:
1. New patch

---
 arch/arm/boot/dts/exynos4412.dtsi | 16 ++++++++--------
 arch/arm/boot/dts/exynos5250.dtsi |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)
arch/arm/boot/dts/exynos4412.dtsi +8 -8
index c74b1be12671..e76881dc0014 100644
@@ -76,7 +76,7 @@
 		};
 	};
 
-	cpu0_opp_table: opp_table0 {
+	cpu0_opp_table: opp-table0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -402,7 +402,7 @@
 			status = "disabled";
 		};
 
-		bus_dmc_opp_table: opp_table1 {
+		bus_dmc_opp_table: opp-table1 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -429,7 +429,7 @@
 			};
 		};
 
-		bus_acp_opp_table: opp_table2 {
+		bus_acp_opp_table: opp-table2 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -495,7 +495,7 @@
 			status = "disabled";
 		};
 
-		bus_leftbus_opp_table: opp_table3 {
+		bus_leftbus_opp_table: opp-table3 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -518,7 +518,7 @@
 			};
 		};
 
-		bus_display_opp_table: opp_table4 {
+		bus_display_opp_table: opp-table4 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -530,7 +530,7 @@
 			};
 		};
 
-		bus_fsys_opp_table: opp_table5 {
+		bus_fsys_opp_table: opp-table5 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -542,7 +542,7 @@
 			};
 		};
 
-		bus_peri_opp_table: opp_table6 {
+		bus_peri_opp_table: opp-table6 {
 			compatible = "operating-points-v2";
 			opp-shared;
 
@@ -734,7 +734,7 @@
 			  "pmu";
 	operating-points-v2 = <&gpu_opp_table>;
 
-	gpu_opp_table: opp_table {
+	gpu_opp_table: opp-table {
 		compatible = "operating-points-v2";
 
 		opp-160000000 {
arch/arm/boot/dts/exynos5250.dtsi +1 -1
index e09db3cecbff..bd2d8835dd36 100644
@@ -330,7 +330,7 @@
 			power-domains = <&pd_g3d>;
 			status = "disabled";
 
-			gpu_opp_table: gpu-opp-table {
+			gpu_opp_table: opp-table {
 				compatible = "operating-points-v2";
 
 				opp-100000000 {
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#9 lore raw

PATCH v2 6/6 arm64: dts: exynos: Align OPP table name with dt-schema

In reply to Krzysztof Kozlowski

Device tree nodes should have hyphens instead of underscores. This is also expected by the bindings.

---

Changes since v1:
1. New patch

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1
index b2eebdd88c3c..9651bb9fdadc 100644
@@ -1087,7 +1087,7 @@
 			operating-points-v2 = <&gpu_opp_table>;
 			status = "disabled";
 
-			gpu_opp_table: opp_table {
+			gpu_opp_table: opp-table {
 				compatible = "operating-points-v2";
 
 				opp-160000000 {
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#6 lore raw

Re: [PATCH v2 4/6] dt-bindings: gpu: samsung-rotator: Add missing properties

In reply to Krzysztof Kozlowski
Quoted 21 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (iommus, power-domains) to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rotator@12810000:
'iommus', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml +0 -0
index 665c6e3b31d3..f480174fe0d3 100644

Documentation/devicetree/bindings/gpu/samsung-rotator.yaml properties: · line 26

Quoted 5 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml +2 -0
@@ -22,6 +22,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  iommus: true
+  power-domains: true

These need to define how many. I assume 1, so 'maxItems: 1'.

Quoted 7 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml +1 -0
+
   clocks:
     maxItems: 1
 
Signature · 1 line
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#11 lore raw

Re: [PATCH v2 1/6] dt-bindings: gpu: arm, mali-midgard: Add missing properties

In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (opp-table) to fix dtbs_check warnings like:

arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+'

Quoted 8 lines

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#2 lore raw

Re: [PATCH v2 2/6] dt-bindings: gpu: arm, mali-utgard: Add missing properties

In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (opp-table) to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos4210-i9100.dt.yaml: gpu@13000000:
'opp-table' does not match any of the regexes: 'pinctrl-[0-9]+'

Quoted 8 lines

---

Changes since v1:
1. Add properties instead of using unevaluated

---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#4 lore raw

Re: [PATCH v2 3/6] dt-bindings: gpu: arm, mali-utgard: Correct Maxime's email

In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

Update the address of Maxime Ripard as one in @free-electrons.com does not work.

Quoted 8 lines

---

Changes since v1:
1. Add Ack

---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer Applied
#8 lore raw

Re: [PATCH v2 5/6] ARM: dts: exynos: Align OPP table name with dt-schema

In reply to Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski

Device tree nodes should have hyphens instead of underscores. This is also expected by the bindings.

Quoted 8 lines

---

Changes since v1:
1. New patch

---
 arch/arm/boot/dts/exynos4412.dtsi | 16 ++++++++--------
 arch/arm/boot/dts/exynos5250.dtsi |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

Applied.

Best regards,
Krzysztof

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer Applied
#10 lore raw

Re: [PATCH v2 6/6] arm64: dts: exynos: Align OPP table name with dt-schema

In reply to Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski

Device tree nodes should have hyphens instead of underscores. This is also expected by the bindings.

---

Changes since v1:
1. New patch

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-

Applied.

Best regards,
Krzysztof

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel