selftests/bpf: Fix check in global_data_init.
Subsystems (5)
PATCH 1/1 selftests/bpf: Fix check in global_data_init.
The returned value of bpf_object__open_file() should be checked with libbpf_get_error() rather than NULL. This fix prevents test_progs from crash when test_global_data.o is not present.
Signed-off-by Hao Luo <[email protected]>
--- tools/testing/selftests/bpf/prog_tests/global_data_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/global_data_init.c +2 -1
@@ -12,7 +12,8 @@ void test_global_data_init(void)size_t sz; obj =bpf_object__open_file (file,NULL ); -if (CHECK_FAIL (!obj)) + err =libbpf_get_error (obj); +if (CHECK_FAIL (err))return ; map =bpf_object__find_map_by_name (obj,"test_glo.rodata" );
Signature · 1 line
2.28.0.526.ge36021eeef-goog
Quoted 7 lines · Hao Luo
The returned value of
bpf_object__open_file()should be checked withlibbpf_get_error()rather than NULL. This fix preventstest_progsfrom crash when test_global_data.o is not present.Signed-off-by Hao Luo <[email protected]>---
thanks!
Acked-by Andrii Nakryiko <[email protected]>
Quoted 20 lines
tools/testing/selftests/bpf/prog_tests/global_data_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/bpf/prog_tests/global_data_init.c +2
-2@@ -12,7 +12,8 @@ void test_global_data_init(void)size_t sz; obj =bpf_object__open_file (file,NULL ); -if (CHECK_FAIL (!obj)) + err =libbpf_get_error (obj); +if (CHECK_FAIL (err))return ; map =bpf_object__find_map_by_name (obj,"test_glo.rodata" ); --2.28.0.526.ge36021eeef-goog
Alexei Starovoitov
AppliedQuoted 7 lines · Andrii Nakryiko
Quoted 5 lines · Hao Luo
The returned value of
bpf_object__open_file()should be checked withlibbpf_get_error()rather than NULL. This fix preventstest_progsfrom crash when test_global_data.o is not present.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Hao Luo <[email protected]>---
thanks!
Acked-by Andrii Nakryiko <[email protected]>
Applied. Thanks